Skip to content

Commit fc354e8

Browse files
committed
Constructor shoud use an interface, so that any class implementing the interface can be passed into this class.
1 parent 3991d65 commit fc354e8

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

lib/internal/Magento/Framework/ObjectManager/Definition/Compiled.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,15 +18,15 @@ abstract class Compiled implements \Magento\Framework\ObjectManager\DefinitionIn
1818
protected $_definitions;
1919

2020
/**
21-
* @var \Magento\Framework\Code\Reader\ClassReader
21+
* @var \Magento\Framework\Code\Reader\ClassReaderInterface
2222
*/
2323
protected $reader ;
2424

2525
/**
2626
* @param array $definitions
27-
* @param \Magento\Framework\Code\Reader\ClassReader $reader
27+
* @param \Magento\Framework\Code\Reader\ClassReaderInterface $reader
2828
*/
29-
public function __construct(array $definitions, \Magento\Framework\Code\Reader\ClassReader $reader = null)
29+
public function __construct(array $definitions, \Magento\Framework\Code\Reader\ClassReaderInterface $reader = null)
3030
{
3131
list($this->_signatures, $this->_definitions) = $definitions;
3232
$this->reader = $reader ?: new \Magento\Framework\Code\Reader\ClassReader();

lib/internal/Magento/Framework/ObjectManager/Definition/Runtime.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,9 @@ class Runtime implements \Magento\Framework\ObjectManager\DefinitionInterface
1515
protected $_definitions = [];
1616

1717
/**
18-
* @param \Magento\Framework\Code\Reader\ClassReader $reader
18+
* @param \Magento\Framework\Code\Reader\ClassReaderInterface $reader
1919
*/
20-
public function __construct(\Magento\Framework\Code\Reader\ClassReader $reader = null)
20+
public function __construct(\Magento\Framework\Code\Reader\ClassReaderInterface $reader = null)
2121
{
2222
$this->_reader = $reader ?: new \Magento\Framework\Code\Reader\ClassReader();
2323
}

lib/internal/Magento/Framework/ObjectManager/Relations/Runtime.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
class Runtime implements \Magento\Framework\ObjectManager\RelationsInterface
99
{
1010
/**
11-
* @var \Magento\Framework\Code\Reader\ClassReader
11+
* @var \Magento\Framework\Code\Reader\ClassReaderInterface
1212
*/
1313
protected $_classReader;
1414

@@ -20,9 +20,9 @@ class Runtime implements \Magento\Framework\ObjectManager\RelationsInterface
2020
protected $_default = [];
2121

2222
/**
23-
* @param \Magento\Framework\Code\Reader\ClassReader $classReader
23+
* @param \Magento\Framework\Code\Reader\ClassReaderInterface $classReader
2424
*/
25-
public function __construct(\Magento\Framework\Code\Reader\ClassReader $classReader = null)
25+
public function __construct(\Magento\Framework\Code\Reader\ClassReaderInterface $classReader = null)
2626
{
2727
$this->_classReader = $classReader ?: new \Magento\Framework\Code\Reader\ClassReader();
2828
}

0 commit comments

Comments
 (0)