Fixed Codacy issues

gwharton · gwharton · commit fc1027caa080 · 2018-01-31T15:05:54.000Z
Fixed Codacy issues
diff --git a/app/code/Magento/Ups/Model/Carrier.php b/app/code/Magento/Ups/Model/Carrier.php
@@ -797,6 +797,7 @@ private function mapCurrencyCode($code)
      * @return Result
      * @SuppressWarnings(PHPMD.CyclomaticComplexity)
      * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+     * @SuppressWarnings(PHPMD.ElseExpression)
      */
     protected function _parseXmlResponse($xmlResponse)
     {
diff --git a/app/code/Magento/Ups/Test/Unit/Model/CarrierCollectRatesOptionsTest.php b/app/code/Magento/Ups/Test/Unit/Model/CarrierCollectRatesOptionsTest.php
@@ -274,10 +274,9 @@ public function scopeConfigisSetFlag($path)
         if (isset($pathMap[$path])) {
             if ($pathMap[$path]) {
                  return(true);
-            } else {
-                 return(false);
-            }
+            } 
         }
+        return(false);
     }
     
     /**

Original file line number	Diff line number	Diff line change
`@@ -797,6 +797,7 @@ private function mapCurrencyCode($code)`
`797`	`797`	`* @return Result`
`798`	`798`	`* @SuppressWarnings(PHPMD.CyclomaticComplexity)`
`799`	`799`	`* @SuppressWarnings(PHPMD.ExcessiveMethodLength)`
	`800`	`+ * @SuppressWarnings(PHPMD.ElseExpression)`
`800`	`801`	`*/`
`801`	`802`	`protected function _parseXmlResponse($xmlResponse)`
`802`	`803`	`{`
Original file line number	Diff line number	Diff line change
`@@ -274,10 +274,9 @@ public function scopeConfigisSetFlag($path)`
`274`	`274`	`if (isset($pathMap[$path])) {`
`275`	`275`	`if ($pathMap[$path]) {`
`276`	`276`	`return(true);`
`277`		`- } else {`
`278`		`- return(false);`
`279`		`- }`
	`277`	`+ }`
`280`	`278`	`}`
	`279`	`+ return(false);`
`281`	`280`	`}`
`282`	`281`
`283`	`282`	`/**`