Skip to content

Commit fbd4188

Browse files
🔃 [EngCom] Public Pull Requests - 2.2-develop
Accepted Public Pull Requests: - #14504: Check if store id is not null instead of empty (by @quisse) - #14498: fix translation issue with rating stars (by @Karlasa)
2 parents c35ee13 + 975a94a commit fbd4188

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

app/code/Magento/Cms/Model/PageRepository.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ public function __construct(
110110
*/
111111
public function save(\Magento\Cms\Api\Data\PageInterface $page)
112112
{
113-
if (empty($page->getStoreId())) {
113+
if ($page->getStoreId() === null) {
114114
$storeId = $this->storeManager->getStore()->getId();
115115
$page->setStoreId($storeId);
116116
}

app/code/Magento/Review/i18n/en_US.csv

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -133,3 +133,5 @@ Summary,Summary
133133
Active,Active
134134
Inactive,Inactive
135135
"Please select one of each of the ratings above.","Please select one of each of the ratings above."
136+
star,star
137+
stars,stars

app/code/Magento/Review/view/frontend/templates/form.phtml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,9 @@
4040
<label
4141
class="rating-<?= $block->escapeHtmlAttr($iterator) ?>"
4242
for="<?= $block->escapeHtmlAttr(str_replace(' ', '_', $_rating->getRatingCode())) ?>_<?= $block->escapeHtmlAttr($_option->getValue()) ?>"
43-
title="<?= $block->escapeHtmlAttr(__('%1 %2', $iterator, $iterator > 1 ? 'stars' : 'star')) ?>"
43+
title="<?= $block->escapeHtmlAttr(__('%1 %2', $iterator, $iterator > 1 ? __('stars') : __('star'))) ?>"
4444
id="<?= $block->escapeHtmlAttr(str_replace(' ', '_', $_rating->getRatingCode())) ?>_<?= $block->escapeHtmlAttr($_option->getValue()) ?>_label">
45-
<span><?= $block->escapeHtml(__('%1 %2', $iterator, $iterator > 1 ? 'stars' : 'star')) ?></span>
45+
<span><?= $block->escapeHtml(__('%1 %2', $iterator, $iterator > 1 ? __('stars') : __('star'))) ?></span>
4646
</label>
4747
<?php $iterator++; ?>
4848
<?php endforeach; ?>

0 commit comments

Comments
 (0)