ADDED $sortByPosition flag to Magento\Catalog\Model\Category

Denis Ristic · Denis Ristic · commit f77dadbd3ad9 · 2017-10-11T10:38:56.000+02:00
ADDED test testGetChildrenSroted() to integration testsuite Magento\Catalog\Model\Category
diff --git a/app/code/Magento/Catalog/Model/Category.php b/app/code/Magento/Catalog/Model/Category.php
@@ -780,11 +780,12 @@ public function getAllChildren($asArray = false)
     /**
      * Retrieve children ids comma separated
      *
+     * @param boolean $sortByPosition
      * @return string
      */
-    public function getChildren()
+    public function getChildren($sortByPosition = false)
     {
-        return implode(',', $this->getResource()->getChildren($this, false));
+        return implode(',', $this->getResource()->getChildren($this, false, true, $sortByPosition));
     }
 
     /**
diff --git a/dev/tests/integration/testsuite/Magento/Catalog/Model/CategoryTreeTest.php b/dev/tests/integration/testsuite/Magento/Catalog/Model/CategoryTreeTest.php
@@ -128,6 +128,12 @@ public function testGetChildren()
         $this->assertEquals(array_diff([4, 13], explode(',', $this->_model->getChildren())), []);
     }
 
+    public function testGetChildrenSorted()
+    {
+        $this->_model->load(2);
+        $this->assertEquals(array_diff([3, 4, 5], explode(',', $this->_model->getChildren(true))), []);
+    }
+
     public function testGetPathInStore()
     {
         $this->_model->load(5);

Original file line number	Diff line number	Diff line change
`@@ -780,11 +780,12 @@ public function getAllChildren($asArray = false)`
`780`	`780`	`/**`
`781`	`781`	`* Retrieve children ids comma separated`
`782`	`782`	`*`
	`783`	`+ * @param boolean $sortByPosition`
`783`	`784`	`* @return string`
`784`	`785`	`*/`
`785`		`- public function getChildren()`
	`786`	`+ public function getChildren($sortByPosition = false)`
`786`	`787`	`{`
`787`		`- return implode(',', $this->getResource()->getChildren($this, false));`
	`788`	`+ return implode(',', $this->getResource()->getChildren($this, false, true, $sortByPosition));`
`788`	`789`	`}`
`789`	`790`
`790`	`791`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -128,6 +128,12 @@ public function testGetChildren()`
`128`	`128`	`$this->assertEquals(array_diff([4, 13], explode(',', $this->_model->getChildren())), []);`
`129`	`129`	`}`
`130`	`130`
	`131`	`+ public function testGetChildrenSorted()`
	`132`	`+ {`
	`133`	`+ $this->_model->load(2);`
	`134`	`+ $this->assertEquals(array_diff([3, 4, 5], explode(',', $this->_model->getChildren(true))), []);`
	`135`	`+ }`
	`136`	`+`
`131`	`137`	`public function testGetPathInStore()`
`132`	`138`	`{`
`133`	`139`	`$this->_model->load(5);`