#13157 - Last Ordered Items block - bad js code

Author: omiroshnichenko

app/code/Magento/Sales/view/frontend/templates/reorder/sidebar.phtml

@@ -51,7 +51,7 @@
             <div id="cart-sidebar-reorder-advice-container"></div>
             <div class="actions-toolbar">
                 <div class="primary"
-                     data-bind="visible: lastOrderedItems.isShowAddToCart">
+                     data-bind="visible: isShowAddToCart">
                     <button type="submit" title="<?= /* @escapeNotVerified */ __('Add to Cart') ?>" class="action tocart primary">
                         <span><?= /* @escapeNotVerified */ __('Add to Cart') ?></span>
                     </button>

app/code/Magento/Sales/view/frontend/web/js/view/last-ordered-items.js

@@ -11,18 +11,37 @@ define([
     'use strict';
 
     return Component.extend({
+        defaults: {
+            isShowAddToCart: false
+        },
+
         /** @inheritdoc */
         initialize: function () {
-            var isShowAddToCart;
-
             this._super();
             this.lastOrderedItems = customerData.get('last-ordered-items');
+            this.lastOrderedItems.subscribe(this.checkSalableItems.bind(this));
+            this.checkSalableItems();
+
+            return this;
+        },
+
+        /** @inheritdoc */
+        initObservable: function () {
+            this._super()
+                .observe('isShowAddToCart');
+
+            return this;
+        },
 
-            isShowAddToCart = _.some(this.lastOrderedItems().items, {
+        /**
+         * Check if items is_saleable and change add to cart button visibility.
+         */
+        checkSalableItems: function () {
+            var isShowAddToCart = _.some(this.lastOrderedItems().items, {
                 'is_saleable': true
             });
 
-            this.lastOrderedItems.isShowAddToCart = isShowAddToCart;
+            this.isShowAddToCart(isShowAddToCart);
         }
     });
 });