ENGCOM-2658: [Braintree] Removed unnecessary unsets from models #17372

Stanislav Idolov · web-flow · commit e53d0cd1f90d · 2018-08-07T16:43:21.000+03:00
diff --git a/app/code/Magento/Braintree/Gateway/Http/Client/TransactionRefund.php b/app/code/Magento/Braintree/Gateway/Http/Client/TransactionRefund.php
@@ -17,8 +17,6 @@ class TransactionRefund extends AbstractTransaction
     protected function process(array $data)
     {
         $storeId = $data['store_id'] ?? null;
-        // sending store id and other additional keys are restricted by Braintree API
-        unset($data['store_id']);
 
         return $this->adapterFactory->create($storeId)
             ->refund($data['transaction_id'], $data[PaymentDataBuilder::AMOUNT]);
diff --git a/app/code/Magento/Braintree/Gateway/Http/Client/TransactionSubmitForSettlement.php b/app/code/Magento/Braintree/Gateway/Http/Client/TransactionSubmitForSettlement.php
@@ -19,8 +19,6 @@ class TransactionSubmitForSettlement extends AbstractTransaction
     protected function process(array $data)
     {
         $storeId = $data['store_id'] ?? null;
-        // sending store id and other additional keys are restricted by Braintree API
-        unset($data['store_id']);
 
         return  $this->adapterFactory->create($storeId)
             ->submitForSettlement($data[CaptureDataBuilder::TRANSACTION_ID], $data[PaymentDataBuilder::AMOUNT]);
diff --git a/app/code/Magento/Braintree/Gateway/Http/Client/TransactionVoid.php b/app/code/Magento/Braintree/Gateway/Http/Client/TransactionVoid.php
@@ -15,8 +15,6 @@ class TransactionVoid extends AbstractTransaction
     protected function process(array $data)
     {
         $storeId = $data['store_id'] ?? null;
-        // sending store id and other additional keys are restricted by Braintree API
-        unset($data['store_id']);
 
         return $this->adapterFactory->create($storeId)->void($data['transaction_id']);
     }

Original file line number	Diff line number	Diff line change
`@@ -17,8 +17,6 @@ class TransactionRefund extends AbstractTransaction`
`17`	`17`	`protected function process(array $data)`
`18`	`18`	`{`
`19`	`19`	`$storeId = $data['store_id'] ?? null;`
`20`		`- // sending store id and other additional keys are restricted by Braintree API`
`21`		`- unset($data['store_id']);`
`22`	`20`
`23`	`21`	`return $this->adapterFactory->create($storeId)`
`24`	`22`	`->refund($data['transaction_id'], $data[PaymentDataBuilder::AMOUNT]);`
Original file line number	Diff line number	Diff line change
`@@ -19,8 +19,6 @@ class TransactionSubmitForSettlement extends AbstractTransaction`
`19`	`19`	`protected function process(array $data)`
`20`	`20`	`{`
`21`	`21`	`$storeId = $data['store_id'] ?? null;`
`22`		`- // sending store id and other additional keys are restricted by Braintree API`
`23`		`- unset($data['store_id']);`
`24`	`22`
`25`	`23`	`return $this->adapterFactory->create($storeId)`
`26`	`24`	`->submitForSettlement($data[CaptureDataBuilder::TRANSACTION_ID], $data[PaymentDataBuilder::AMOUNT]);`
Original file line number	Diff line number	Diff line change
`@@ -15,8 +15,6 @@ class TransactionVoid extends AbstractTransaction`
`15`	`15`	`protected function process(array $data)`
`16`	`16`	`{`
`17`	`17`	`$storeId = $data['store_id'] ?? null;`
`18`		`- // sending store id and other additional keys are restricted by Braintree API`
`19`		`- unset($data['store_id']);`
`20`	`18`
`21`	`19`	`return $this->adapterFactory->create($storeId)->void($data['transaction_id']);`
`22`	`20`	`}`