ENGCOM-3019: Replace intval() function by using direct type casting to (int) where no default value is needed #18142

Author: Stanislav Idolov

lib/internal/Magento/Framework/DB/Adapter/Pdo/Mysql.php

@@ -3857,13 +3857,13 @@ protected function _parseTextSize($size)
 
         switch ($last) {
             case 'k':
-                $size = intval($size) * 1024;
+                $size = (int)$size * 1024;
                 break;
             case 'm':
-                $size = intval($size) * 1024 * 1024;
+                $size = (int)$size * 1024 * 1024;
                 break;
             case 'g':
-                $size = intval($size) * 1024 * 1024 * 1024;
+                $size = (int)$size * 1024 * 1024 * 1024;
                 break;
         }
 
@@ -3874,7 +3874,7 @@ protected function _parseTextSize($size)
             return Table::MAX_TEXT_SIZE;
         }
 
-        return intval($size);
+        return (int)$size;
     }
 
     /**

lib/internal/Magento/Framework/DB/Helper.php

@@ -153,12 +153,12 @@ protected function _prepareHaving(\Magento\Framework\DB\Select $select, $autoRes
     protected function _assembleLimit($query, $limitCount, $limitOffset, $columnList = [])
     {
         if ($limitCount !== null) {
-            $limitCount = intval($limitCount);
+            $limitCount = (int)$limitCount;
             if ($limitCount <= 0) {
                 //throw new \Exception("LIMIT argument count={$limitCount} is not valid");
             }
 
-            $limitOffset = intval($limitOffset);
+            $limitOffset = (int)$limitOffset;
             if ($limitOffset < 0) {
                 //throw new \Exception("LIMIT argument offset={$limitOffset} is not valid");
             }

lib/internal/Magento/Framework/DB/Query.php

@@ -142,7 +142,7 @@ public function getSize()
             $sql = $this->getSelectCountSql();
             $this->totalRecords = $this->getConnection()->fetchOne($sql, $this->bindParams);
         }
-        return intval($this->totalRecords);
+        return (int)$this->totalRecords;
     }
 
     /**

lib/internal/Magento/Framework/DB/Query/BatchIterator.php

@@ -165,7 +165,7 @@ private function calculateBatchSize(Select $select)
         );
         $row = $this->connection->fetchRow($wrapperSelect);
         $this->minValue = $row['max'];
-        return intval($row['cnt']);
+        return (int)$row['cnt'];
     }
 
     /**

lib/internal/Magento/Framework/DB/Query/BatchRangeIterator.php

@@ -201,7 +201,7 @@ private function initSelectObject()
             );
             $row = $this->connection->fetchRow($wrapperSelect);
 
-            $this->totalItemCount = intval($row['cnt']);
+            $this->totalItemCount = (int)$row['cnt'];
         }
 
         $rangeField = is_array($this->rangeField) ? $this->rangeField : [$this->rangeField];

lib/internal/Magento/Framework/DB/Sql/LimitExpression.php

@@ -46,14 +46,14 @@ public function __construct(
     public function __toString()
     {
         $sql = $this->sql;
-        $count = intval($this->count);
+        $count = (int)$this->count;
         if ($count <= 0) {
             /** @see Zend_Db_Adapter_Exception */
             #require_once 'Zend/Db/Adapter/Exception.php';
             throw new \Zend_Db_Adapter_Exception("LIMIT argument count=$count is not valid");
         }
 
-        $offset = intval($this->offset);
+        $offset = (int)$this->offset;
         if ($offset < 0) {
             /** @see Zend_Db_Adapter_Exception */
             #require_once 'Zend/Db/Adapter/Exception.php';

lib/internal/Magento/Framework/Data/Argument/Interpreter/ArrayType.php

@@ -90,11 +90,11 @@ private function compareItems($firstItemKey, $secondItemKey, $indexedItems)
         $firstValue = 0;
         $secondValue = 0;
         if (isset($firstItem['sortOrder'])) {
-            $firstValue = intval($firstItem['sortOrder']);
+            $firstValue = (int)$firstItem['sortOrder'];
         }
 
         if (isset($secondItem['sortOrder'])) {
-            $secondValue = intval($secondItem['sortOrder']);
+            $secondValue = (int)$secondItem['sortOrder'];
         }
 
         if ($firstValue == $secondValue) {

lib/internal/Magento/Framework/Data/Collection.php

@@ -285,7 +285,7 @@ public function getSize()
         if ($this->_totalRecords === null) {
             $this->_totalRecords = count($this->getItems());
         }
-        return intval($this->_totalRecords);
+        return (int)$this->_totalRecords;
     }
 
     /**

lib/internal/Magento/Framework/Exception/LocalizedException.php

@@ -33,7 +33,7 @@ class LocalizedException extends \Exception
     public function __construct(Phrase $phrase, \Exception $cause = null, $code = 0)
     {
         $this->phrase = $phrase;
-        parent::__construct($phrase->render(), intval($code), $cause);
+        parent::__construct($phrase->render(), (int)$code, $cause);
     }
 
     /**

lib/internal/Magento/Framework/HTTP/Client/Curl.php

@@ -435,7 +435,7 @@ protected function parseHeaders($ch, $data)
             if (count($line) != 3) {
                 $this->doError("Invalid response line returned from server: " . $data);
             }
-            $this->_responseStatus = intval($line[1]);
+            $this->_responseStatus = (int)$line[1];
         } else {
             $name = $value = '';
             $out = explode(": ", trim($data), 2);