ENGCOM-3343: Fix numeric translation keys being dissolved by array_merge #18968

Stanislav Idolov · web-flow · commit a02d4ee3d2a7 · 2018-11-06T11:21:51.000+02:00
diff --git a/lib/internal/Magento/Framework/App/Language/Dictionary.php b/lib/internal/Magento/Framework/App/Language/Dictionary.php
@@ -111,7 +111,9 @@ public function getDictionary($languageCode)
             /** @var Config $languageConfig */
             $languageConfig = $packInfo['language'];
             $dictionary = $this->readPackCsv($languageConfig->getVendor(), $languageConfig->getPackage());
-            $result = array_merge($result, $dictionary);
+            foreach ($dictionary as $key => $value) {
+                $result[$key] = $value;
+            }
         }
         return $result;
     }

Original file line number	Diff line number	Diff line change
`@@ -111,7 +111,9 @@ public function getDictionary($languageCode)`
`111`	`111`	`/** @var Config $languageConfig */`
`112`	`112`	`$languageConfig = $packInfo['language'];`
`113`	`113`	`$dictionary = $this->readPackCsv($languageConfig->getVendor(), $languageConfig->getPackage());`
`114`		`- $result = array_merge($result, $dictionary);`
	`114`	`+ foreach ($dictionary as $key => $value) {`
	`115`	`+ $result[$key] = $value;`
	`116`	`+ }`
`115`	`117`	`}`
`116`	`118`	`return $result;`
`117`	`119`	`}`