ENGCOM-3000: Update shipment collection to unserialize \packages\ attribute after load #17679

magento-engcom-team · magento-engcom-team · commit 862572606a8b · 2018-09-18T05:56:15.000-05:00
- Merge Pull Request #17679 from dnsv/magento2:shipment-collection-unserialize - Merged commits: 1. 8f4efee
diff --git a/app/code/Magento/Sales/Model/ResourceModel/Order/Shipment/Collection.php b/app/code/Magento/Sales/Model/ResourceModel/Order/Shipment/Collection.php
@@ -57,14 +57,16 @@ protected function _construct()
     }
 
     /**
-     * Used to emulate after load functionality for each item without loading them
+     * Unserialize packages in each item
      *
      * @return $this
      */
     protected function _afterLoad()
     {
-        $this->walk('afterLoad');
+        foreach ($this->_items as $item) {
+            $this->getResource()->unserializeFields($item);
+        }
 
-        return $this;
+        return parent::_afterLoad();
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -57,14 +57,16 @@ protected function _construct()`
`57`	`57`	`}`
`58`	`58`
`59`	`59`	`/**`
`60`		`- * Used to emulate after load functionality for each item without loading them`
	`60`	`+ * Unserialize packages in each item`
`61`	`61`	`*`
`62`	`62`	`* @return $this`
`63`	`63`	`*/`
`64`	`64`	`protected function _afterLoad()`
`65`	`65`	`{`
`66`		`- $this->walk('afterLoad');`
	`66`	`+ foreach ($this->_items as $item) {`
	`67`	`+ $this->getResource()->unserializeFields($item);`
	`68`	`+ }`
`67`	`69`
`68`		`- return $this;`
	`70`	`+ return parent::_afterLoad();`
`69`	`71`	`}`
`70`	`72`	`}`