Skip to content

Commit 85e6dee

Browse files
author
Yuriy Tkachenko
committed
Refactor logger instance usage
1 parent cd3ad3b commit 85e6dee

File tree

1 file changed

+12
-19
lines changed

1 file changed

+12
-19
lines changed

lib/internal/Magento/Framework/ObjectManager/Factory/AbstractFactory.php

Lines changed: 12 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,9 @@
77

88
use Magento\Framework\Exception\RuntimeException;
99
use Magento\Framework\ObjectManagerInterface;
10+
use Magento\Framework\Phrase;
1011
use Psr\Log\LoggerInterface;
12+
use Magento\Framework\App\ObjectManager;
1113

1214
abstract class AbstractFactory implements \Magento\Framework\ObjectManager\FactoryInterface
1315
{
@@ -106,34 +108,25 @@ public function getDefinitions()
106108
* @param array $args
107109
*
108110
* @return object
109-
* @throws \Exception
111+
* @throws RuntimeException
110112
*/
111113
protected function createObject($type, $args)
112114
{
113115
try {
114116
return new $type(...array_values($args));
115117
} catch (\Throwable $e) {
116-
$this->getLogger()->critical(__(
117-
'Object create error: %1, %2',
118-
[
119-
$type,
120-
$e->getMessage()
121-
]
122-
));
123-
throw new RuntimeException(__($e->getMessage()));
118+
/** @var LoggerInterface $logger */
119+
$logger = ObjectManager::getInstance()->get(LoggerInterface::class);
120+
$logger->critical(
121+
sprintf('Create object error: %s, %s', $type, $e->getMessage())
122+
);
123+
124+
throw new RuntimeException(
125+
new Phrase('Create object error')
126+
);
124127
}
125128
}
126129

127-
/**
128-
* Logger Instance
129-
*
130-
* @return LoggerInterface
131-
*/
132-
protected function getLogger()
133-
{
134-
return $this->objectManager->get(LoggerInterface::class);
135-
}
136-
137130
/**
138131
* Resolve an argument
139132
*

0 commit comments

Comments
 (0)