MC-32977: Unskip StorefrontButtonsInlineTranslationTest (MC-12735) and check it green on Jenkins

Author: viktorpetryk

app/code/Magento/Translation/Test/Mftf/ActionGroup/AdminTranslateElementActionGroup.xml

@@ -8,9 +8,9 @@
 
 <actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
               xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
-    <actionGroup name="AdminTranslateElementActionGroup" deprecated="Avoid using super-ActionGroups. Use StorefrontOpenInlineTranslationPopupActionGroup, AssertStorefrontInlineTranslationPopupAppearsActionGroup, StorefrontFillTranslationFieldActionGroup and StorefrontSubmitInlineTranslationFormActionGroup">
+    <actionGroup name="AdminTranslateElementActionGroup" deprecated="Avoid using super-ActionGroups. Use StorefrontOpenInlineTranslationPopupActionGroup, StorefrontFillCustomTranslationFieldActionGroup and StorefrontSubmitInlineTranslationFormActionGroup">
         <annotations>
-            <description>DEPRECATED. Avoid using super-ActionGroups. Use StorefrontOpenInlineTranslationPopupActionGroup, AssertStorefrontInlineTranslationPopupAppearsActionGroup, StorefrontFillTranslationFieldActionGroup and StorefrontSubmitInlineTranslationFormActionGroup.</description>
+            <description>DEPRECATED. Avoid using super-ActionGroups. Use StorefrontOpenInlineTranslationPopupActionGroup, StorefrontFillCustomTranslationFieldActionGroup and StorefrontSubmitInlineTranslationFormActionGroup.</description>
         </annotations>
         <arguments>
             <argument name="elementSelector" type="string"/>

app/code/Magento/Translation/Test/Mftf/ActionGroup/AssertStorefrontInlineTranslationPopupAppearsActionGroup.xml

@@ -8,15 +8,15 @@
 
 <actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
               xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
-    <actionGroup name="StorefrontFillTranslationFieldActionGroup">
+    <actionGroup name="StorefrontFillCustomTranslationFieldActionGroup">
         <annotations>
-            <description>Fill the field in the Inline Translation form by provided text.</description>
+            <description>Fill the field in the Inline Translation form by provided text on Storefront.</description>
         </annotations>
         <arguments>
             <argument name="translateText" type="string" defaultValue="Translated"/>
         </arguments>
 
-        <clearField selector="{{InlineTranslationModeSection.inputCustomTranslate}}" stepKey="clearField"/>
-        <fillField selector="{{InlineTranslationModeSection.inputCustomTranslate}}" userInput="{{translateText}}" stepKey="fillTranslateField"/>
+        <clearField selector="{{InlineTranslationModeSection.inputCustomTranslate}}" stepKey="clearCustomTranslateField"/>
+        <fillField selector="{{InlineTranslationModeSection.inputCustomTranslate}}" userInput="{{translateText}}" stepKey="fillCustomTranslateField"/>
     </actionGroup>
 </actionGroups>

app/code/Magento/Translation/Test/Mftf/ActionGroup/StorefrontFillTranslationFieldActionGroup.xml renamed to app/code/Magento/Translation/Test/Mftf/ActionGroup/StorefrontFillCustomTranslationFieldActionGroup.xml

@@ -10,13 +10,15 @@
               xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
     <actionGroup name="StorefrontOpenInlineTranslationPopupActionGroup">
         <annotations>
-            <description>Open the Inline Translation popup for provided element.</description>
+            <description>Open the Inline Translation popup for provided element on Storefront.</description>
         </annotations>
         <arguments>
             <argument name="elementSelector" type="string" defaultValue="{{StorefrontHeaderSection.welcomeMessage}}"/>
         </arguments>
 
         <executeJS function="jQuery('{{elementSelector}}').mousemove()" stepKey="moveMouseOverSelector"/>
         <executeJS function="jQuery('{{InlineTranslationModeSection.bookIcon}}').click()" stepKey="clickBookIcon"/>
+        <waitForElementVisible selector="{{InlineTranslationModeSection.popUpTranslate}}" stepKey="waitForTranslationPopupAppear"/>
+        <seeElement selector="{{InlineTranslationModeSection.popUpTranslate}}" stepKey="seeTranslateForm"/>
     </actionGroup>
 </actionGroups>

app/code/Magento/Translation/Test/Mftf/ActionGroup/StorefrontOpenInlineTranslationPopupActionGroup.xml

@@ -10,9 +10,11 @@
               xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
     <actionGroup name="StorefrontSubmitInlineTranslationFormActionGroup">
         <annotations>
-            <description>Click on the Inline Translation form submit button.</description>
+            <description>Click on the Inline Translation form submit button on Storefront.</description>
         </annotations>
 
         <click selector="{{InlineTranslationModeSection.buttonSubmit}}" stepKey="clickSubmitButton"/>
+        <waitForElementNotVisible selector="{{InlineTranslationModeSection.popUpTranslate}}" stepKey="waitForTranslationPopupDisappear"/>
+        <dontSeeElement selector="{{InlineTranslationModeSection.popUpTranslate}}" stepKey="dontSeeTranslateForm"/>
     </actionGroup>
 </actionGroups>

app/code/Magento/Translation/Test/Mftf/ActionGroup/StorefrontSubmitInlineTranslationFormActionGroup.xml

@@ -12,7 +12,7 @@
         <annotations>
             <features value="Translation"/>
             <stories value="Inline Translation"/>
-            <title value="[Inline Translation] Buttons inline translation"/>
+            <title value="Buttons inline translation"/>
             <description value="A merchant should be able to translate buttons by an inline translation tool"/>
             <severity value="CRITICAL"/>
             <testCaseId value="MC-12735"/>
@@ -59,8 +59,5 @@
         <actionGroup ref="StorefrontOpenInlineTranslationPopupActionGroup" stepKey="openInlineTranslationPopup">
             <argument name="elementSelector" value="{{StorefrontMinicartSection.goToCheckout}}"/>
         </actionGroup>
-
-        <!-- Assert that Inline Translation popup appears -->
-        <actionGroup ref="AssertStorefrontInlineTranslationPopupAppearsActionGroup" stepKey="assertInlineTranslationPopupAppears"/>
     </test>
 </tests>