🔃 [Magento Community Engineering] Community Contributions - 2.3-develop

Accepted Community Pull Requests:
 - #22003: Do not validate length and input rule if attribute value is required but empty (by @VincentMarmiesse)
 - #23325: Fix unexpected diff between builds in generated/metadata directory (by @ihor-sviziev)
 - #24104: Resolve Console error when clicking select all at "Newsletter Problems Report" (issue 24102) (by @edenduong)
 - #24017: ImportExport module missing some translation (by @edenduong)


Fixed GitHub Issues:
 - #23324: [Reproducible Builds] Diff in generated/metadata between the builds (reported by @ihor-sviziev) has been fixed in #23325 by @ihor-sviziev in 2.3-develop branch
   Related commits:
     1. d8486ba

 - #24102: Console error when clicking checkbox at "Newsletter Problems Report" (reported by @edenduong) has been fixed in #24104 by @edenduong in 2.3-develop branch
   Related commits:
     1. d7606f4
     2. 86d5c22

Author: magento-engcom-team

app/code/Magento/Eav/Model/Attribute/Data/Text.php

@@ -75,6 +75,8 @@ public function validateValue($value)
         if (empty($value) && $value !== '0' && $attribute->getDefaultValue() === null) {
             $label = __($attribute->getStoreLabel());
             $errors[] = __('"%1" is a required value.', $label);
+
+            return $errors;
         }
 
         $validateLengthResult = $this->validateLength($attribute, $value);

app/code/Magento/ImportExport/i18n/en_US.csv

@@ -123,3 +123,5 @@ Summary,Summary
 "New product data is added to existing product data entries in the database. All fields except SKU can be updated.","New product data is added to existing product data entries in the database. All fields except SKU can be updated."
 "All existing product data is replaced with the imported new data. <b>Exercise caution when replacing data. All existing product data will be completely cleared and all references in the system will be lost.</b>","All existing product data is replaced with the imported new data. <b>Exercise caution when replacing data. All existing product data will be completely cleared and all references in the system will be lost.</b>"
 "Any entities in the import data that match existing entities in the database are deleted from the database.","Any entities in the import data that match existing entities in the database are deleted from the database."
+"Invalid data","Invalid data"
+"Invalid response","Invalid response"

app/code/Magento/ImportExport/view/adminhtml/templates/export/form/before.phtml

@@ -89,7 +89,7 @@ require([
             form.action   = oldAction;
         } else {
             alert({
-                content: 'Invalid data'
+                content: '<?= $block->escapeHtml(__('Invalid data')); ?>'
             });
         }
     };

app/code/Magento/ImportExport/view/adminhtml/templates/import/form/before.phtml

@@ -209,7 +209,7 @@ require([
         postToFrameProcessResponse: function(response) {
             if ('object' != typeof(response)) {
                 alert({
-                    content: 'Invalid response'
+                    content: '<?= $block->escapeHtml(__('Invalid response')); ?>'
                 });
 
                 return false;

app/code/Magento/Newsletter/view/adminhtml/templates/problem/list.phtml

@@ -17,10 +17,12 @@ require(["prototype", "mage/adminhtml/events"], function(){
 
     problemController = {
         checkCheckboxes:function (controlCheckbox) {
-            var elements = $('problemGrid').getElementsByClassName('problemCheckbox');
-            elements.each(function (obj) {
-                obj.checked = controlCheckbox.checked;
-            });
+            var elements = $$('input.problemCheckbox');
+            if (elements && elements.length) {
+                elements.each(function (obj) {
+                    obj.checked = controlCheckbox.checked;
+                });
+            }
         },
         rowClick:function (e) {
             if (!Event.element(e).hasClassName('problemCheckbox')) {

setup/src/Magento/Setup/Module/Di/App/Task/Operation/Area.php

@@ -88,6 +88,8 @@ public function doOperation()
             }
         }
 
+        $this->sortDefinitions($definitionsCollection);
+
         $areaCodes = array_merge([App\Area::AREA_GLOBAL], $this->areaList->getCodes());
         foreach ($areaCodes as $areaCode) {
             $config = $this->configReader->generateCachePerScope($definitionsCollection, $areaCode);
@@ -124,4 +126,18 @@ public function getName()
     {
         return 'Area configuration aggregation';
     }
+
+    /**
+     * Sort definitions to make reproducible result
+     *
+     * @param DefinitionsCollection $definitionsCollection
+     */
+    private function sortDefinitions(DefinitionsCollection $definitionsCollection): void
+    {
+        $definitions = $definitionsCollection->getCollection();
+
+        ksort($definitions);
+
+        $definitionsCollection->initialize($definitions);
+    }
 }