ENGCOM-3034: [Forwardport] Fix module uninstall shell command and composer removal w/out regression #18205

magento-engcom-team · magento-engcom-team · commit 740ec507ff3a · 2018-09-24T03:48:17.000-05:00
- Merge Pull Request #18205 from mage2pratik/magento2:2.3-develop-PR-port-18002 - Merged commits: 1. 8b9fff5 2. fa4289f
diff --git a/dev/tests/integration/testsuite/Magento/Framework/Composer/RemoveTest.php b/dev/tests/integration/testsuite/Magento/Framework/Composer/RemoveTest.php
@@ -24,7 +24,7 @@ public function testRemove()
                 [
                     'command' => 'remove',
                     'packages' => ['magento/package-a', 'magento/package-b'],
-                    '--no-update' => true,
+                    '--no-update-with-dependencies' => true,
                 ]
             );
         $composerAppFactory->expects($this->once())
diff --git a/lib/internal/Magento/Framework/Composer/Remove.php b/lib/internal/Magento/Framework/Composer/Remove.php
@@ -46,7 +46,7 @@ public function remove(array $packages)
             [
                 'command' => 'remove',
                 'packages' => $packages,
-                '--no-update' => true,
+                '--no-update-with-dependencies' => true,
             ]
         );
     }

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ public function testRemove()`
`24`	`24`	`[`
`25`	`25`	`'command' => 'remove',`
`26`	`26`	`'packages' => ['magento/package-a', 'magento/package-b'],`
`27`		`- '--no-update' => true,`
	`27`	`+ '--no-update-with-dependencies' => true,`
`28`	`28`	`]`
`29`	`29`	`);`
`30`	`30`	`$composerAppFactory->expects($this->once())`
Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ public function remove(array $packages)`
`46`	`46`	`[`
`47`	`47`	`'command' => 'remove',`
`48`	`48`	`'packages' => $packages,`
`49`		`- '--no-update' => true,`
	`49`	`+ '--no-update-with-dependencies' => true,`
`50`	`50`	`]`
`51`	`51`	`);`
`52`	`52`	`}`