MAGETWO-90182: Fix unit tests

Author: Eric Bohanon

app/code/Magento/Bundle/Test/Unit/Model/OptionRepositoryTest.php

@@ -14,11 +14,6 @@
  */
 class OptionRepositoryTest extends \PHPUnit\Framework\TestCase
 {
-    /**
-     * @var \PHPUnit_Framework_MockObject_MockObject
-     */
-    protected $metadataPoolMock;
-
     /**
      * @var \Magento\Bundle\Model\OptionRepository
      */
@@ -67,12 +62,12 @@ class OptionRepositoryTest extends \PHPUnit\Framework\TestCase
     /**
      * @var \PHPUnit_Framework_MockObject_MockObject
      */
-    protected $linkListMock;
+    protected $dataObjectHelperMock;
 
     /**
-     * @var \PHPUnit_Framework_MockObject_MockObject
+     * @var \Magento\Bundle\Model\Option\SaveAction|\PHPUnit_Framework_MockObject_MockObject
      */
-    protected $dataObjectHelperMock;
+    private $optionSaveActionMock;
 
     protected function setUp()
     {
@@ -94,24 +89,18 @@ protected function setUp()
         $this->storeManagerMock = $this->createMock(\Magento\Store\Model\StoreManagerInterface::class);
         $this->linkManagementMock = $this->createMock(\Magento\Bundle\Api\ProductLinkManagementInterface::class);
         $this->optionListMock = $this->createMock(\Magento\Bundle\Model\Product\OptionList::class);
-        $this->linkListMock = $this->createMock(\Magento\Bundle\Model\Product\LinksList::class);
-        $this->metadataPoolMock = $this->createMock(\Magento\Framework\EntityManager\MetadataPool::class);
+        $this->optionSaveActionMock = $this->createMock(\Magento\Bundle\Model\Option\SaveAction::class);
 
         $this->model = new OptionRepository(
             $this->productRepositoryMock,
             $this->typeMock,
             $this->optionFactoryMock,
             $this->optionResourceMock,
-            $this->storeManagerMock,
             $this->linkManagementMock,
             $this->optionListMock,
-            $this->linkListMock,
-            $this->dataObjectHelperMock
+            $this->dataObjectHelperMock,
+            $this->optionSaveActionMock
         );
-        $refClass = new \ReflectionClass(OptionRepository::class);
-        $refProperty = $refClass->getProperty('metadataPool');
-        $refProperty->setAccessible(true);
-        $refProperty->setValue($this->model, $this->metadataPoolMock);
     }
 
     /**
@@ -174,7 +163,7 @@ public function testGet()
         $productMock->expects($this->once())
             ->method('getTypeId')
             ->willReturn(\Magento\Catalog\Model\Product\Type::TYPE_BUNDLE);
-        $productMock->expects($this->once())->method('getSku')->willReturn($productSku);
+        $productMock->expects($this->exactly(2))->method('getSku')->willReturn($productSku);
 
         $this->productRepositoryMock->expects($this->once())
             ->method('get')
@@ -194,7 +183,6 @@ public function testGet()
         $optionMock->expects($this->once())->method('getData')->willReturn($optionData);
 
         $linkMock = ['item'];
-        $this->linkListMock->expects($this->once())->method('getItems')->with($productMock, 100)->willReturn($linkMock);
 
         $newOptionMock = $this->createMock(\Magento\Bundle\Api\Data\OptionInterface::class);
         $this->dataObjectHelperMock->expects($this->once())
@@ -207,10 +195,10 @@ public function testGet()
             ->with($optionData['title'])
             ->willReturnSelf();
         $newOptionMock->expects($this->once())->method('setSku')->with()->willReturnSelf();
-        $newOptionMock->expects($this->once())
-            ->method('setProductLinks')
-            ->with($linkMock)
-            ->willReturnSelf();
+        $this->linkManagementMock->expects($this->once())
+            ->method('getChildren')
+            ->with($productSku, $optionId)
+            ->willReturn($linkMock);
 
         $this->optionFactoryMock->expects($this->once())->method('create')->willReturn($newOptionMock);
 
@@ -272,172 +260,67 @@ public function testDeleteById()
      */
     public function testSaveExistingOption()
     {
-        $productId = 1;
-
-        $storeId = 2;
         $optionId = 5;
-        $existingLinkToUpdateId = '23';
+
+        $productSku = 'sku';
 
         $productMock = $this->createMock(\Magento\Catalog\Model\Product::class);
-        $productMock->expects($this->once())->method('getData')->willReturn($productId);
-        $productMock->expects($this->once())->method('getStoreId')->willReturn($storeId);
-        $optionCollectionMock = $this->getMockBuilder(\Magento\Bundle\Model\ResourceModel\Option\Collection::class)
-            ->disableOriginalConstructor()
-            ->getMock();
-        $this->typeMock->expects($this->once())
-            ->method('getOptionsCollection')
-            ->with($productMock)
-            ->willReturn($optionCollectionMock);
-        $optionCollectionMock->expects($this->once())->method('setIdFilter')->with($optionId)->willReturnSelf();
+        $productMock->expects($this->once())->method('getSku')->willReturn($productSku);
 
         $optionMock = $this->createPartialMock(
             \Magento\Bundle\Model\Option::class,
             ['setStoreId', 'setParentId', 'getProductLinks', 'getOptionId', 'getResource']
         );
-        $optionCollectionMock->expects($this->once())->method('getFirstItem')->willReturn($optionMock);
 
-        $metadataMock = $this->createMock(\Magento\Framework\EntityManager\EntityMetadata::class);
-        $metadataMock->expects($this->once())->method('getLinkField')->willReturn('product_option');
-
-        $this->metadataPoolMock->expects($this->once())->method('getMetadata')
-            ->with(\Magento\Catalog\Api\Data\ProductInterface::class)
-            ->willReturn($metadataMock);
         $optionMock->expects($this->atLeastOnce())->method('getOptionId')->willReturn($optionId);
 
-        $productLinkUpdate = $this->createMock(\Magento\Bundle\Api\Data\LinkInterface::class);
-        $productLinkUpdate->expects($this->any())->method('getId')->willReturn($existingLinkToUpdateId);
-        $productLinkNew = $this->createMock(\Magento\Bundle\Api\Data\LinkInterface::class);
-        $productLinkNew->expects($this->any())->method('getId')->willReturn(null);
-        $optionMock->expects($this->exactly(2))
-            ->method('getProductLinks')
-            ->willReturn([$productLinkUpdate, $productLinkNew]);
+        $this->optionSaveActionMock->expects($this->once())->method('save')->with($productMock, $optionMock)
+            ->willReturn($optionMock);
+
+        $this->productRepositoryMock
+            ->expects($this->once())
+            ->method('get')
+            ->with($productSku)
+            ->willReturn($productMock);
 
-        $this->linkManagementMock->expects($this->exactly(2))
-            ->method('addChild')
+        $this->productRepositoryMock
+            ->expects($this->once())
+            ->method('save')
             ->with($productMock);
+
         $this->assertEquals($optionId, $this->model->save($productMock, $optionMock));
     }
 
     public function testSaveNewOption()
     {
-        $productId = 1;
-        $productSku = 'bundle_sku';
-        $storeId = 2;
         $optionId = 5;
 
-        $productMock = $this->createMock(\Magento\Catalog\Model\Product::class);
-        $productMock->expects($this->once())->method('getData')->willReturn($productId);
-        $productMock->expects($this->once())->method('getStoreId')->willReturn($storeId);
-        $productMock->expects($this->any())->method('getSku')->willReturn($productSku);
+        $productSku = 'sku';
 
-        $optionCollectionMock = $this->getMockBuilder(\Magento\Bundle\Model\ResourceModel\Option\Collection::class)
-            ->disableOriginalConstructor()
-            ->getMock();
-        $this->typeMock->expects($this->once())
-            ->method('getOptionsCollection')
-            ->with($productMock)
-            ->willReturn($optionCollectionMock);
-        $optionCollectionMock->expects($this->once())->method('setIdFilter')->with($optionId)->willReturnSelf();
+        $productMock = $this->createMock(\Magento\Catalog\Model\Product::class);
+        $productMock->expects($this->once())->method('getSku')->willReturn($productSku);
 
         $optionMock = $this->createPartialMock(
             \Magento\Bundle\Model\Option::class,
-            [
-                'setStoreId',
-                'setParentId',
-                'getProductLinks',
-                'getOptionId',
-                'setOptionId',
-                'setDefaultTitle',
-                'getTitle',
-                'getResource'
-            ]
-        );
-        $optionCollectionMock->expects($this->once())->method('getFirstItem')->willReturn($optionMock);
-        $metadataMock = $this->createMock(
-            \Magento\Framework\EntityManager\EntityMetadata::class
+            ['setStoreId', 'setParentId', 'getProductLinks', 'getOptionId', 'getResource']
         );
-        $metadataMock->expects($this->once())->method('getLinkField')->willReturn('product_option');
-
-        $this->metadataPoolMock->expects($this->once())->method('getMetadata')
-            ->with(\Magento\Catalog\Api\Data\ProductInterface::class)
-            ->willReturn($metadataMock);
-        $optionMock->method('getOptionId')
-            ->willReturn($optionId);
-
-        $productLink1 = $this->createMock(\Magento\Bundle\Api\Data\LinkInterface::class);
-        $productLink2 = $this->createMock(\Magento\Bundle\Api\Data\LinkInterface::class);
-        $optionMock->expects($this->exactly(2))
-            ->method('getProductLinks')
-            ->willReturn([$productLink1, $productLink2]);
-
-        $this->optionResourceMock->expects($this->once())->method('save')->with($optionMock)->willReturnSelf();
-        $this->linkManagementMock->expects($this->at(0))
-            ->method('addChild')
-            ->with($productMock, $optionId, $productLink1);
-        $this->linkManagementMock->expects($this->at(1))
-            ->method('addChild')
-            ->with($productMock, $optionId, $productLink2);
-        $this->assertEquals($optionId, $this->model->save($productMock, $optionMock));
-    }
 
-    /**
-     * @expectedException \Magento\Framework\Exception\CouldNotSaveException
-     * @expectedExceptionMessage The option couldn't be saved.
-     */
-    public function testSaveCanNotSave()
-    {
-        $productId = 1;
-        $productSku = 'bundle_sku';
-        $storeId = 2;
-        $optionId = 5;
+        $optionMock->expects($this->atLeastOnce())->method('getOptionId')->willReturn($optionId);
 
-        $productMock = $this->createMock(\Magento\Catalog\Model\Product::class);
-        $productMock->expects($this->once())->method('getData')->willReturn($productId);
-        $productMock->expects($this->once())->method('getStoreId')->willReturn($storeId);
-        $productMock->expects($this->any())->method('getSku')->willReturn($productSku);
+        $this->optionSaveActionMock->expects($this->once())->method('save')->with($productMock, $optionMock)
+            ->willReturn($optionMock);
 
-        $optionCollectionMock = $this->getMockBuilder(\Magento\Bundle\Model\ResourceModel\Option\Collection::class)
-            ->disableOriginalConstructor()
-            ->getMock();
-        $this->typeMock->expects($this->once())
-            ->method('getOptionsCollection')
-            ->with($productMock)
-            ->willReturn($optionCollectionMock);
-        $optionCollectionMock->expects($this->once())->method('setIdFilter')->with($optionId)->willReturnSelf();
+        $this->productRepositoryMock
+            ->expects($this->once())
+            ->method('get')
+            ->with($productSku)
+            ->willReturn($productMock);
 
-        $optionMock = $this->createPartialMock(
-            \Magento\Bundle\Model\Option::class,
-            [
-                'setStoreId',
-                'setParentId',
-                'getProductLinks',
-                'getOptionId',
-                'setOptionId',
-                'setDefaultTitle',
-                'getTitle',
-                'getResource'
-            ]
-        );
-        $optionCollectionMock->expects($this->once())->method('getFirstItem')->willReturn($optionMock);
-        $metadataMock = $this->createMock(
-            \Magento\Framework\EntityManager\EntityMetadata::class
-        );
-        $metadataMock->expects($this->once())->method('getLinkField')->willReturn('product_option');
-
-        $this->metadataPoolMock->expects($this->once())->method('getMetadata')
-            ->with(\Magento\Catalog\Api\Data\ProductInterface::class)
-            ->willReturn($metadataMock);
-        $optionMock->method('getOptionId')->willReturn($optionId);
-
-        $productLink1 = $this->createMock(\Magento\Bundle\Api\Data\LinkInterface::class);
-        $productLink2 = $this->createMock(\Magento\Bundle\Api\Data\LinkInterface::class);
-        $optionMock->expects($this->exactly(2))
-            ->method('getProductLinks')
-            ->willReturn([$productLink1, $productLink2]);
-
-        $this->optionResourceMock->expects($this->once())->method('save')->with($optionMock)
-            ->willThrowException($this->createMock(\Exception::class));
-        $this->model->save($productMock, $optionMock);
+        $this->productRepositoryMock
+            ->expects($this->once())
+            ->method('save')
+            ->with($productMock);
+        $this->assertEquals($optionId, $this->model->save($productMock, $optionMock));
     }
 
     public function testGetList()