MAGETWO-92154: [Backport to 2.2] Unlock Locales Editing when SCD on Demand Mode is Enabled

Author: Yevhen Miroshnychenko

app/code/Magento/Config/Test/Unit/Model/Config/Structure/ElementVisibility/ConcealInProductionTest.php

@@ -55,8 +55,9 @@ protected function setUp()
      * @param bool $isDisabled
      * @param bool $isHidden
      * @dataProvider disabledDataProvider
+     * @return void
      */
-    public function testCheckVisibility(string $path, string $mageMode, bool $isHidden, bool $isDisabled): void
+    public function testCheckVisibility(string $path, string $mageMode, bool $isHidden, bool $isDisabled)
     {
         $this->stateMock->expects($this->any())
             ->method('getMode')

app/code/Magento/Config/Test/Unit/Model/Config/Structure/ElementVisibility/ConcealInProductionWithoutScdOnDemandTest.php

@@ -69,7 +69,10 @@ protected function setUp()
         );
     }
 
-    public function testIsHiddenScdOnDemandEnabled(): void
+    /**
+     * @return void
+     */
+    public function testIsHiddenScdOnDemandEnabled()
     {
         $path = 'section1/group1/field1';
         $this->deploymentConfigMock->expects($this->once())
@@ -82,7 +85,10 @@ public function testIsHiddenScdOnDemandEnabled(): void
         $this->assertFalse($this->model->isHidden($path));
     }
 
-    public function testIsDisabledScdOnDemandEnabled(): void
+    /**
+     * @return void
+     */
+    public function testIsDisabledScdOnDemandEnabled()
     {
         $path = 'section1/group1/field1';
         $this->deploymentConfigMock->expects($this->once())
@@ -99,8 +105,9 @@ public function testIsDisabledScdOnDemandEnabled(): void
      * @param bool $isHidden
      *
      * @dataProvider visibilityDataProvider
+     * @return void
      */
-    public function testIsHiddenScdOnDemandDisabled(bool $isHidden): void
+    public function testIsHiddenScdOnDemandDisabled(bool $isHidden)
     {
         $path = 'section1/group1/field1';
         $this->deploymentConfigMock->expects($this->once())
@@ -119,8 +126,9 @@ public function testIsHiddenScdOnDemandDisabled(bool $isHidden): void
      * @param bool $isDisabled
      *
      * @dataProvider visibilityDataProvider
+     * @return void
      */
-    public function testIsDisabledScdOnDemandDisabled(bool $isDisabled): void
+    public function testIsDisabledScdOnDemandDisabled(bool $isDisabled)
     {
         $path = 'section1/group1/field1';
         $this->deploymentConfigMock->expects($this->once())

lib/internal/Magento/Framework/Locale/Test/Unit/Deployed/OptionsTest.php

@@ -87,7 +87,7 @@ protected function setUp()
      *
      * @dataProvider getFullLocalesDataProvider
      */
-    public function testGetOptionLocalesFull(string $mode, int $scdOnDemand, array $locales): void
+    public function testGetOptionLocalesFull(string $mode, int $scdOnDemand, array $locales)
     {
         $this->localeListsMock->expects($this->once())
             ->method('getOptionLocales')
@@ -106,7 +106,7 @@ public function testGetOptionLocalesFull(string $mode, int $scdOnDemand, array $
      *
      * @dataProvider getFullLocalesDataProvider
      */
-    public function testGetTranslatedOptionLocalesFull(string $mode, int $scdOnDemand, array $locales): void
+    public function testGetTranslatedOptionLocalesFull(string $mode, int $scdOnDemand, array $locales)
     {
         $this->localeListsMock->expects($this->once())
             ->method('getTranslatedOptionLocales')
@@ -133,7 +133,7 @@ public function testGetOptionLocalesLimited(
         array $locales,
         array $expectedLocales,
         array $deployedCodes
-    ): void {
+    ) {
         $this->localeListsMock->expects($this->once())
             ->method('getOptionLocales')
             ->willReturn($locales);
@@ -159,7 +159,7 @@ public function testGetTranslatedOptionLocalesLimited(
         array $locales,
         array $expectedLocales,
         array $deployedCodes
-    ): void {
+    ) {
         $this->localeListsMock->expects($this->once())
             ->method('getTranslatedOptionLocales')
             ->willReturn($locales);
@@ -175,7 +175,7 @@ public function testGetTranslatedOptionLocalesLimited(
      * @param array $deployedCodes
      * @return void
      */
-    private function prepareGetLocalesLimited(string $mode, int $scdOnDemand, $deployedCodes): void
+    private function prepareGetLocalesLimited(string $mode, int $scdOnDemand, $deployedCodes)
     {
         $this->stateMock->expects($this->once())
             ->method('getMode')
@@ -209,7 +209,7 @@ private function prepareGetLocalesLimited(string $mode, int $scdOnDemand, $deplo
      * @param int $scdOnDemand
      * @return void
      */
-    private function prepareGetLocalesFull(string $mode, int $scdOnDemand): void
+    private function prepareGetLocalesFull(string $mode, int $scdOnDemand)
     {
         $this->stateMock->expects($this->once())
             ->method('getMode')