MAGETWO-61353: Gift Card Accounts are not being generated with Auth&Capture payment action on Authorize.net DP enabled

- introduce service class for parameters settings

Author: cpartica

app/code/Magento/Authorizenet/Controller/Adminhtml/Authorizenet/Directpost/Payment/Redirect.php

@@ -129,7 +129,9 @@ public function execute()
             $this->_returnQuote($cancelOrder, $redirectParams['error_msg']);
         }
 
-        $this->_coreRegistry->register(Iframe::REGISTRY_KEY, array_merge($params, $redirectParams));
+        $this->_objectManager->get(\Magento\Payment\Model\IframeService::class)->setParams(
+            array_merge($params, $redirectParams)
+        );
         return $this->resultLayoutFactory->create();
     }
 }

app/code/Magento/Authorizenet/Controller/Directpost/Payment.php

@@ -17,6 +17,7 @@ abstract class Payment extends \Magento\Framework\App\Action\Action
     /**
      * Core registry
      *
+     * @deprecated
      * @var \Magento\Framework\Registry
      */
     protected $_coreRegistry = null;
@@ -26,20 +27,29 @@ abstract class Payment extends \Magento\Framework\App\Action\Action
      */
     protected $dataFactory;
 
+    /**
+     * @var \Magento\Payment\Model\IframeService
+     */
+    private $iframeService;
+
     /**
      * Constructor
      *
      * @param \Magento\Framework\App\Action\Context $context
      * @param \Magento\Framework\Registry $coreRegistry
      * @param \Magento\Authorizenet\Helper\DataFactory $dataFactory
+     * @param \Magento\Payment\Model\IframeService|null $iframeService
      */
     public function __construct(
         \Magento\Framework\App\Action\Context $context,
         \Magento\Framework\Registry $coreRegistry,
-        \Magento\Authorizenet\Helper\DataFactory $dataFactory
+        \Magento\Authorizenet\Helper\DataFactory $dataFactory,
+        \Magento\Payment\Model\IframeService $iframeService = null
     ) {
         $this->_coreRegistry = $coreRegistry;
         $this->dataFactory = $dataFactory;
+        $this->iframeService = $iframeService ?: \Magento\Framework\App\ObjectManager::getInstance()
+            ->get(\Magento\Payment\Model\IframeService::class);
         parent::__construct($context);
     }
 
@@ -66,19 +76,17 @@ protected function _getDirectPostSession()
      * Action for Authorize.net SIM Relay Request.
      *
      * @param string $area
-     * @param \Magento\Authorizenet\Model\Directpost $paymentMethod
-     * @return \Magento\Framework\Controller\ResultInterface
+     * @return void
+     * @throws \Magento\Framework\Exception\LocalizedException
      */
-    protected function _responseAction($area = 'frontend', \Magento\Authorizenet\Model\Directpost $paymentMethod = null)
+    protected function _responseAction($area = 'frontend')
     {
         $helper = $this->dataFactory->create($area);
-        /** @var \Magento\Framework\View\Result\Page $resultPage */
-        $resultPage =  $this->resultFactory->create(\Magento\Framework\Controller\ResultFactory::TYPE_PAGE);
 
         $params = [];
         $data = $this->getRequest()->getParams();
 
-        $paymentMethod = $this->getPaymentMethod($paymentMethod);
+        $paymentMethod = $this->_objectManager->create(\Magento\Authorizenet\Model\Directpost::class);
 
         $result = [];
         if (!empty($data['x_invoice_num'])) {
@@ -113,21 +121,8 @@ protected function _responseAction($area = 'frontend', \Magento\Authorizenet\Mod
             $params['redirect'] = $helper->getRedirectIframeUrl($result);
         }
 
-        //registering parameter for iframe content
-        $this->_coreRegistry->register(Iframe::REGISTRY_KEY, $params);
-        return $resultPage;
-    }
-
-    /**
-     * @param \Magento\Authorizenet\Model\Directpost|null $paymentMethod
-     * @return \Magento\Authorizenet\Model\Directpost
-     */
-    private function getPaymentMethod(\Magento\Authorizenet\Model\Directpost $paymentMethod = null)
-    {
-        if (empty($paymentMethod)) {
-            $paymentMethod = $this->_objectManager->create(\Magento\Authorizenet\Model\Directpost::class);
-        }
-        return $paymentMethod;
+        //registering response parameters for iframe content
+        $this->iframeService->setParams($params);
     }
 
     /**

app/code/Magento/Authorizenet/Controller/Directpost/Payment/BackendResponse.php

@@ -16,6 +16,7 @@ class BackendResponse extends \Magento\Authorizenet\Controller\Directpost\Paymen
      */
     public function execute()
     {
-        return $this->_responseAction('adminhtml');
+        $this->_responseAction('adminhtml');
+        return $this->resultFactory->create(\Magento\Framework\Controller\ResultFactory::TYPE_PAGE);
     }
 }

app/code/Magento/Authorizenet/Controller/Directpost/Payment/Redirect.php

@@ -46,7 +46,7 @@ public function execute()
             unset($params['redirect_parent']);
         }
 
-        $this->_coreRegistry->register(Iframe::REGISTRY_KEY, $params);
+        $this->_objectManager->get(\Magento\Payment\Model\IframeService::class)->setParams($params);
         $this->_view->addPageLayoutHandles();
         $this->_view->loadLayout(false)->renderLayout();
     }

app/code/Magento/Authorizenet/Controller/Directpost/Payment/Response.php

@@ -6,31 +6,8 @@
  */
 namespace Magento\Authorizenet\Controller\Directpost\Payment;
 
-use Magento\Authorizenet\Model\DirectpostFactory;
-
 class Response extends \Magento\Authorizenet\Controller\Directpost\Payment
 {
-    /** @var \Magento\Authorizenet\Model\DirectpostFactory */
-    private $directpostFactory;
-
-    /**
-     * Constructor
-     *
-     * @param \Magento\Framework\App\Action\Context $context
-     * @param \Magento\Framework\Registry $coreRegistry
-     * @param \Magento\Authorizenet\Helper\DataFactory $dataFactory
-     * @param \Magento\Authorizenet\Model\DirectpostFactory|null $directpostFactory
-     */
-    public function __construct(
-        \Magento\Framework\App\Action\Context $context,
-        \Magento\Framework\Registry $coreRegistry,
-        \Magento\Authorizenet\Helper\DataFactory $dataFactory,
-        \Magento\Authorizenet\Model\DirectpostFactory $directpostFactory = null
-    ) {
-        parent::__construct($context, $coreRegistry, $dataFactory);
-        $this->directpostFactory = $directpostFactory ? : $this->_objectManager->create(DirectpostFactory::class);
-    }
-
     /**
      * Response action.
      * Action for Authorize.net SIM Relay Request.
@@ -39,6 +16,7 @@ public function __construct(
      */
     public function execute()
     {
-        return $this->_responseAction('frontend', $this->directpostFactory->create());
+        $this->_responseAction('frontend');
+        return $this->resultFactory->create(\Magento\Framework\Controller\ResultFactory::TYPE_PAGE);
     }
 }

app/code/Magento/Payment/Block/Transparent/Iframe.php

@@ -17,38 +17,51 @@ class Iframe extends \Magento\Framework\View\Element\Template
     /**
      * Core registry
      *
+     * @deprecated
      * @var \Magento\Framework\Registry
      */
     protected $coreRegistry;
 
     /**
-     * Constructor
-     *
+     * @var \Magento\Payment\Model\IframeService
+     */
+    private $iframeService;
+
+    /**
      * @param \Magento\Framework\View\Element\Template\Context $context
      * @param \Magento\Framework\Registry $registry
      * @param array $data
+     * @param \Magento\Payment\Model\IframeService|null $iframeService
      */
     public function __construct(
         \Magento\Framework\View\Element\Template\Context $context,
         \Magento\Framework\Registry $registry,
-        array $data = []
+        array $data = [],
+        \Magento\Payment\Model\IframeService $iframeService = null
     ) {
         $this->coreRegistry = $registry;
+        $this->iframeService = $iframeService ?: \Magento\Framework\App\ObjectManager::getInstance()
+            ->get(\Magento\Payment\Model\IframeService::class);
         parent::__construct($context, $data);
     }
 
     /**
-     * Override this method in descendants to produce html
+     * Set params once per request
+     *
+     * @return $this
+     */
+    public function setParams(array $params)
+    {
+        return $this->iframeService->setParams($params);
+    }
+
+    /**
+     * Return params
      *
-     * @return string
+     * @return $this
      */
-    protected function _toHtml()
+    public function getParams()
     {
-        $params = $this->getParams();
-        if (empty($params)) {
-            $params = $this->coreRegistry->registry(self::REGISTRY_KEY);
-        }
-        $this->setParams($params);
-        return parent::_toHtml();
+        return $this->iframeService->getParams();
     }
 }

app/code/Magento/Payment/Model/IframeService.php

@@ -0,0 +1,59 @@
+<?php
+/**
+ * Copyright © 2013-2017 Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+namespace Magento\Payment\Model;
+
+/**
+ * Class IframeService
+ * Inject this into the response control decision class for payment a method on a single request
+ */
+class IframeService
+{
+    /**
+     * @var array
+     */
+    private $params = [];
+
+    /**
+     * @var bool
+     */
+    private $isParamsSet = false;
+
+    /**
+     * This method can set only once the parameters to prevent other classes from modifying response
+     *
+     * @param array $params
+     * @return $this
+     * @throws \Magento\Framework\Exception\LocalizedException
+     */
+    public function setParams(array $params)
+    {
+        if (!$this->isParamsSet) {
+            $this->params = $params;
+            $this->isParamsSet = true;
+        } else {
+            throw new \Magento\Framework\Exception\LocalizedException(
+                __('Parameters can not be set in the service class more than once per request.')
+            );
+        }
+        return $this;
+    }
+
+    /**
+     * This method can set only once the parameters to prevent other classes from modifying response
+     *
+     * @return array
+     * @throws \Magento\Framework\Exception\LocalizedException
+     */
+    public function getParams()
+    {
+        if (!$this->isParamsSet) {
+            throw new \Magento\Framework\Exception\LocalizedException(
+                __('Parameters are not set on this request.')
+            );
+        }
+        return $this->params;
+    }
+}

app/code/Magento/Paypal/Controller/Transparent/Response.php

@@ -88,7 +88,7 @@ public function execute()
             $parameters['error_msg'] = $exception->getMessage();
         }
 
-        $this->coreRegistry->register(Iframe::REGISTRY_KEY, $parameters);
+        $this->_objectManager->get(\Magento\Payment\Model\IframeService::class)->setParams($parameters);
 
         $resultLayout = $this->resultLayoutFactory->create();
         $resultLayout->addDefaultHandle();