ENGCOM-2417: [Backport] Fix docBlock for hasInvoices(), hasShipments(), hasCreditmemos() #16923

magento-engcom-team · magento-engcom-team · commit 2db8d93fb062 · 2018-07-19T07:33:21.000-05:00
- Merge Pull Request #16923 from eduard13/magento2:2.1-develop-PR-port-16554 - Merged commits: 1. cf759ec 2. 8e8bcfa
diff --git a/app/code/Magento/Sales/Model/Order.php b/app/code/Magento/Sales/Model/Order.php
@@ -1770,7 +1770,7 @@ public function getTracksCollection()
      */
     public function hasInvoices()
     {
-        return $this->getInvoiceCollection()->count();
+        return boolval($this->getInvoiceCollection()->count());
     }
 
     /**
@@ -1780,7 +1780,7 @@ public function hasInvoices()
      */
     public function hasShipments()
     {
-        return $this->getShipmentsCollection()->count();
+        return boolval($this->getShipmentsCollection()->count());
     }
 
     /**
@@ -1790,7 +1790,7 @@ public function hasShipments()
      */
     public function hasCreditmemos()
     {
-        return $this->getCreditmemosCollection()->count();
+        return boolval($this->getCreditmemosCollection()->count());
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -1770,7 +1770,7 @@ public function getTracksCollection()`
`1770`	`1770`	`*/`
`1771`	`1771`	`public function hasInvoices()`
`1772`	`1772`	`{`
`1773`		`- return $this->getInvoiceCollection()->count();`
	`1773`	`+ return boolval($this->getInvoiceCollection()->count());`
`1774`	`1774`	`}`
`1775`	`1775`
`1776`	`1776`	`/**`
`@@ -1780,7 +1780,7 @@ public function hasInvoices()`
`1780`	`1780`	`*/`
`1781`	`1781`	`public function hasShipments()`
`1782`	`1782`	`{`
`1783`		`- return $this->getShipmentsCollection()->count();`
	`1783`	`+ return boolval($this->getShipmentsCollection()->count());`
`1784`	`1784`	`}`
`1785`	`1785`
`1786`	`1786`	`/**`
`@@ -1790,7 +1790,7 @@ public function hasShipments()`
`1790`	`1790`	`*/`
`1791`	`1791`	`public function hasCreditmemos()`
`1792`	`1792`	`{`
`1793`		`- return $this->getCreditmemosCollection()->count();`
	`1793`	`+ return boolval($this->getCreditmemosCollection()->count());`
`1794`	`1794`	`}`
`1795`	`1795`
`1796`	`1796`	`/**`