Skip to content

Improved tests logic #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 23, 2020
Merged

Improved tests logic #393

merged 4 commits into from
Nov 23, 2020

Conversation

@drpayyne
Copy link
Contributor

@drpayyne drpayyne commented Nov 14, 2020 •
edited
Loading

Description

Improved logic for 8 tests and made compliant with latest static analysis rules

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@coderimus coderimus self-assigned this Nov 19, 2020
@coderimus coderimus self-requested a review November 19, 2020 08:45
@drpayyne
Copy link
Contributor Author

drpayyne commented Nov 20, 2020

@magento run all tests

@drpayyne
Copy link
Contributor Author

drpayyne commented Nov 20, 2020

Hi @coderimus, I'm not sure what the error is in these failing tests. Could you please? Thanks.

@coderimus coderimus merged commit 3b37a61 into magento:2.1.0-develop Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@coderimus coderimus coderimus approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@coderimus coderimus

Labels

Expert Partner: EY partners-contribution Progress: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@drpayyne @coderimus @magento-engcom-team