Fixed disabling plugin on a startup when Magento not in the root #344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Oh, thx for the quick fix! Checking if that works... |
ihor-sviziev
suggested changes
Oct 23, 2020
Contributor
ihor-sviziev
left a comment
ihor-sviziev
left a comment
There was a problem hiding this comment.
Just checked - the fix works fine! 👍
Could you cover your change with automated test?
Contributor
Author
|
Created an issue #347 for the test coverage. |
ihor-sviziev
approved these changes
Oct 23, 2020
coderimus
approved these changes
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Fixed issue with constant disabling on startup when Magento not in the root.
Fixed Issues (if relevant)
Contribution checklist (*)