Skip to content

Conversation

@drpayyne
Copy link
Contributor

@drpayyne drpayyne commented Oct 22, 2020

Description

Changed validator for com.magento.idea.magento2plugin.actions.generation.dialog.CreateAnObserverDialog. Also fixed PhpClassRule's edge case bug where providing a PHP reserved keyword breaks the code.

Fixed Issues

  1. Change validation for Creating new observer dialog window #283: Change validation for Creating new observer dialog window

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@coderimus coderimus self-assigned this Oct 23, 2020
@coderimus coderimus self-requested a review October 23, 2020 09:12
@coderimus
Copy link
Contributor

Hello @drpayyne
Everything great and I approved this PR. Please, create a backport for the "Also fixed PhpClassRule's edge case bug where providing a PHP reserved keyword breaks the code." to the 2.0.1
Thank you!

@coderimus coderimus merged commit a2257a1 into magento:2.1.0-develop Oct 23, 2020
@coderimus
Copy link
Contributor

@drpayyne please, ignore my comment about the backport. Here we do not need it, I was wrong. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants