Skip to content

Fixed new module action #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 22, 2020
Merged

Fixed new module action #335

merged 3 commits into from
Oct 22, 2020

Conversation

@VitaliyBoyko
Copy link
Contributor

@VitaliyBoyko VitaliyBoyko commented Oct 22, 2020 •
edited by coderimus
Loading

Description (*)
New module action is broken with error:

ava.lang.NumberFormatException: For input string: "any"
	at java.base/java.lang.NumberFormatException.forInputString(NumberFormatException.java:65)
	at java.base/java.lang.Integer.parseInt(Integer.java:652)
	at java.base/java.lang.Integer.parseInt(Integer.java:770)
	at com.magento.idea.magento2plugin.util.magento.MagentoVersionUtil.compare(MagentoVersionUtil.java:90)
	at com.magento.idea.magento2plugin.actions.generation.dialog.NewModuleDial

It happens if the Magento version is set to any in configs.
This PR fixes the issue.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@coderimus coderimus self-requested a review October 22, 2020 18:58
@coderimus coderimus self-assigned this Oct 22, 2020
@coderimus coderimus added the Easy label Oct 22, 2020
@coderimus coderimus merged commit 52f2f43 into 2.0.1-develop Oct 22, 2020
@VitaliyBoyko VitaliyBoyko deleted the fixed-module-generation-for-any-version branch October 23, 2020 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@coderimus coderimus coderimus approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@coderimus coderimus

Labels

Easy Partner: Atwix partners-contribution

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@VitaliyBoyko @coderimus @magento-engcom-team