Skip to content

Adjusted UI form XML to be valid and accessible via the admin #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 21, 2020
Merged

Adjusted UI form XML to be valid and accessible via the admin #313

merged 4 commits into from
Oct 21, 2020

Conversation

@VitaliyBoyko
Copy link
Contributor

@VitaliyBoyko VitaliyBoyko commented Oct 19, 2020 •
edited by coderimus
Loading

Description (*)
Adjusted UI form generation, fixed data provider, and fieldset declarations.
FIxed tests.
Beautified headers in form.

image

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@eduard13 eduard13 self-requested a review October 20, 2020 10:56
@eduard13 eduard13 self-assigned this Oct 20, 2020
eduard13
eduard13 approved these changes Oct 21, 2020
View reviewed changes
Copy link
Contributor

@eduard13 eduard13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@coderimus coderimus merged commit 2cfe5f4 into 2.0.0-develop Oct 21, 2020
@VitaliyBoyko VitaliyBoyko deleted the form-adjustments branch October 21, 2020 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eduard13 eduard13 eduard13 approved these changes

+1 more reviewer

@coderimus coderimus coderimus approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@coderimus coderimus

@eduard13 eduard13

Labels

approved Award: test coverage hacktoberfest-accepted Partner: Atwix partners-contribution QA passed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@VitaliyBoyko @coderimus @eduard13 @magento-engcom-team