Added BoxNotEmptyRule to validate if dropdown option is selected

Author: drpayyne

resources/magento2/validation.properties

@@ -1,4 +1,5 @@
 validator.notEmpty=The {0} field must not be empty
+validator.box.notEmpty=The {0} field must contain a valid selection from the dropdown
 validator.package.validPath=Please specify a valid Magento 2 installation path
 validator.alphaNumericCharacters=The {0} must contain letters and numbers only
 validator.alphaNumericAndUnderscoreCharacters={0} must contain letters, numbers and underscores only

src/com/magento/idea/magento2plugin/actions/generation/dialog/AbstractDialog.java

@@ -184,7 +184,11 @@ private String resolveFieldValueByComponentType(final Object field) {
         if (field instanceof JTextField) {
             return ((JTextField) field).isEditable() ? ((JTextField) field).getText() : null;
         } else if (field instanceof JComboBox) {
-            return ((JComboBox) field).getSelectedItem().toString();
+            try {
+                return ((JComboBox) field).getSelectedItem().toString();
+            } catch (NullPointerException exception) {
+                return "";
+            }
         }
         return null;
     }

src/com/magento/idea/magento2plugin/actions/generation/dialog/NewCronjobDialog.java

@@ -12,6 +12,7 @@
 import com.magento.idea.magento2plugin.actions.generation.data.CrontabXmlData;
 import com.magento.idea.magento2plugin.actions.generation.dialog.validator.annotation.FieldValidation;
 import com.magento.idea.magento2plugin.actions.generation.dialog.validator.annotation.RuleRegistry;
+import com.magento.idea.magento2plugin.actions.generation.dialog.validator.rule.BoxNotEmptyRule;
 import com.magento.idea.magento2plugin.actions.generation.dialog.validator.rule.ConfigPathRule;
 import com.magento.idea.magento2plugin.actions.generation.dialog.validator.rule.CronScheduleRule;
 import com.magento.idea.magento2plugin.actions.generation.dialog.validator.rule.DirectoryRule;
@@ -100,6 +101,8 @@ public class NewCronjobDialog extends AbstractDialog {
             message = {ConfigPathRule.MESSAGE, CONFIG_PATH})
     private JTextField configPathField;
 
+    @FieldValidation(rule = RuleRegistry.BOX_NOT_EMPTY,
+            message = {BoxNotEmptyRule.MESSAGE, CRON_GROUP})
     @FieldValidation(rule = RuleRegistry.NOT_EMPTY,
             message = {NotEmptyRule.MESSAGE, CRON_GROUP})
     private FilteredComboBox cronGroupComboBox;

src/com/magento/idea/magento2plugin/actions/generation/dialog/validator/annotation/RuleRegistry.java

@@ -8,6 +8,7 @@
 import com.magento.idea.magento2plugin.actions.generation.dialog.validator.rule.AclResourceIdRule;
 import com.magento.idea.magento2plugin.actions.generation.dialog.validator.rule.AlphanumericRule;
 import com.magento.idea.magento2plugin.actions.generation.dialog.validator.rule.AlphanumericWithUnderscoreRule;
+import com.magento.idea.magento2plugin.actions.generation.dialog.validator.rule.BoxNotEmptyRule;
 import com.magento.idea.magento2plugin.actions.generation.dialog.validator.rule.ConfigPathRule;
 import com.magento.idea.magento2plugin.actions.generation.dialog.validator.rule.CronScheduleRule;
 import com.magento.idea.magento2plugin.actions.generation.dialog.validator.rule.DirectoryRule;
@@ -23,6 +24,7 @@
 
 public enum RuleRegistry {
     NOT_EMPTY(NotEmptyRule.class),
+    BOX_NOT_EMPTY(BoxNotEmptyRule.class),
     PHP_CLASS(PhpClassRule.class),
     ROUTE_ID(RouteIdRule.class),
     ALPHANUMERIC(AlphanumericRule.class),

src/com/magento/idea/magento2plugin/actions/generation/dialog/validator/rule/BoxNotEmptyRule.java

@@ -0,0 +1,15 @@
+package com.magento.idea.magento2plugin.actions.generation.dialog.validator.rule;
+
+public class BoxNotEmptyRule implements ValidationRule {
+    public static final String MESSAGE = "validator.box.notEmpty";
+    private static final ValidationRule INSTANCE = new BoxNotEmptyRule();
+
+    @Override
+    public boolean check(final String value) {
+        return !value.isEmpty();
+    }
+
+    public static ValidationRule getInstance() {
+        return INSTANCE;
+    }
+}

src/com/magento/idea/magento2plugin/actions/generation/dialog/validator/rule/NotEmptyRule.java

@@ -11,7 +11,7 @@ public class NotEmptyRule implements ValidationRule {
 
     @Override
     public boolean check(final String value) {
-        return value.length() != 0;
+        return !value.isEmpty();
     }
 
     public static ValidationRule getInstance() {