magento/devdocs#: Add info about setPaymentMethodAndPlaceOrder to GraphQL checkout tutorial #4950

atwixfirster · 2019-07-14T05:51:32Z

Purpose of this pull request

This pull request (PR) adds information about setPaymentMethodAndPlaceOrder mutation and provides additional changes for "Step 4. Set the shipping address", "Step 5. Set billing address" "Step 6. Set the shipping method" pages.

Affected DevDocs pages

Links to Magento source code

setPaymentMethodAndPlaceOrder

Thank you!

CC: @keharper

whatsnew
Updated the GraphQL checkout tutorial to include the setPaymentMethodAndPlaceOrder mutation.

…phQL checkout tutorial

devops-devdocs · 2019-07-14T05:53:03Z

An admin must run tests on this PR before it can be merged.

…phQL checkout tutorial

rogyar · 2019-07-15T12:20:52Z

guides/v2.3/graphql/tutorials/checkout/checkout-payment-method.md


+### Set payment method and place order {#setPaymentMethodAndPlaceOrder}
+
+Use the `setPaymentMethodAndPlaceOrder` mutation to set the payment method for your order.


Please, add a clarification here

Suggested change

Use the `setPaymentMethodAndPlaceOrder` mutation to set the payment method for your order.

Use the `setPaymentMethodAndPlaceOrder` mutation to set the payment method and place the order.

good point @rogyar

fixed

…phQL checkout tutorial

rogyar · 2019-07-19T13:28:40Z

guides/v2.3/graphql/tutorials/checkout/checkout-payment-method.md

 }
 ```

+### Set payment method and place order {#setPaymentMethodAndPlaceOrder}


I've just realized that this mutation is not a part of 2.3.2 version. I would suggest splitting this PR into two separate PRs and making the PR with information about setPaymentMethodAndPlaceOrder mutation to the develop branch.

I've created a separate PR #5000 to fix

Remove address_type from shipping_addresses and billing_addresses.

Remove label from selected_shipping_method

Thank you. The only change left is to create a PR to the develop branch.

@rogyar I will reset the target branch for this PR into the develop branch immediately after the next time we sync master and develop.

…phQL checkout tutorial

keharper

@atwixfirster Just one technical question remains, then I can merge the PR.

keharper · 2019-08-17T01:26:32Z

guides/v2.3/graphql/tutorials/checkout/checkout-payment-method.md

+
+**Response**
+
+If the operation is successful, the response contains the code of the selected payment method.


Isn't this the order ID?

order ID, @keharper

…phQL checkout tutorial

keharper · 2019-08-18T22:48:45Z

running tests

keharper

There's a bad link.

keharper · 2019-08-19T00:27:14Z

guides/v2.3/graphql/tutorials/checkout/checkout-payment-method.md

+|Mutation|Description|
+|--- |--- |
+|`setPaymentMethodOnCart`|Sets the payment method for your order|
+|`setPaymentMethodAndPlaceOrder`|Sets the payment method and then immediately places your order. In this case ["Step 10. Place the order"]({{ page.baseurl }}/graphql/tutorials/checkout/checkout-place-order.md) can be skipped|


Suggested change

|`setPaymentMethodAndPlaceOrder`|Sets the payment method and then immediately places your order. In this case ["Step 10. Place the order"]({{ page.baseurl }}/graphql/tutorials/checkout/checkout-place-order.md) can be skipped|

|`setPaymentMethodAndPlaceOrder`|Sets the payment method and then immediately places your order. In this case ["Step 10. Place the order"]({{ page.baseurl }}/graphql/tutorials/checkout/checkout-place-order.html) can be skipped|

Thank you, @keharper

fixed by @keharper ;)

@atwixfirster I can't commit the change. I can only make a suggestion to fix it

Not sure how but you fixed that bug. I've pulled the changes and detected what md extension has been replaced with html.

Please run tests now.

Thank you!

…phQL checkout tutorial

…//github.com/atwixfirster/devdocs into add-info-about-setPaymentMethodAndPlaceOrder

…phQL checkout tutorial

keharper · 2019-08-19T14:15:13Z

running tests

ghost · 2019-08-19T14:46:27Z

Hi @atwixfirster, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

keharper · 2019-08-19T14:46:35Z

Thanks @atwixfirster

meker12 · 2019-08-19T15:44:26Z

@keharper Please add the whatsnew for this PR. Thx.

magento/devdocs#: Add info about setPaymentMethodAndPlaceOrder to Gra…

5621a03

…phQL checkout tutorial

magento-engcom-team added Partner: Atwix partners-contribution PR created by Magento partner labels Jul 14, 2019

magento/devdocs#: Add info about setPaymentMethodAndPlaceOrder to Gra…

0c58fc0

…phQL checkout tutorial

rogyar self-assigned this Jul 15, 2019

rogyar suggested changes Jul 15, 2019

View reviewed changes

rogyar added 2.3.x Magento 2.3 related changes Major Update Significant original updates to existing content labels Jul 15, 2019

magento/devdocs#: Add info about setPaymentMethodAndPlaceOrder to Gra…

c9ecd49

…phQL checkout tutorial

jeff-matthews requested a review from keharper July 15, 2019 13:01

rogyar approved these changes Jul 16, 2019

View reviewed changes

keharper self-assigned this Jul 16, 2019

rogyar suggested changes Jul 19, 2019

View reviewed changes

rogyar added the Waiting for Response Waiting for response from internal/external parties label Jul 19, 2019

atwixfirster and others added 2 commits July 19, 2019 17:19

magento/devdocs#: Add info about setPaymentMethodAndPlaceOrder to Gra…

915f1c0

…phQL checkout tutorial

Merge branch 'master' into add-info-about-setPaymentMethodAndPlaceOrder

7921d27

keharper changed the base branch from master to develop July 22, 2019 14:23

rogyar approved these changes Jul 24, 2019

View reviewed changes

keharper added xx2.3.3 Magento 2.3.3 changes and removed 2.3.x Magento 2.3 related changes labels Jul 25, 2019

m2-community-project bot added the Progress: approved label Jul 31, 2019

keharper reviewed Aug 18, 2019

View reviewed changes

magento/devdocs#: Add info about setPaymentMethodAndPlaceOrder to Gra…

ae0a8e7

…phQL checkout tutorial

keharper added Community Docs impacted by community code contribution and removed Waiting for Response Waiting for response from internal/external parties labels Aug 18, 2019

keharper approved these changes Aug 18, 2019

View reviewed changes

Merge branch 'develop' into add-info-about-setPaymentMethodAndPlaceOrder

ddf8ab4

keharper suggested changes Aug 19, 2019

View reviewed changes

atwixfirster added 3 commits August 19, 2019 03:31

magento/devdocs#: Add info about setPaymentMethodAndPlaceOrder to Gra…

05e8654

…phQL checkout tutorial

Merge branch 'add-info-about-setPaymentMethodAndPlaceOrder' of https:…

fc1b6c4

…//github.com/atwixfirster/devdocs into add-info-about-setPaymentMethodAndPlaceOrder

magento/devdocs#: Add info about setPaymentMethodAndPlaceOrder to Gra…

cac1401

…phQL checkout tutorial

keharper approved these changes Aug 19, 2019

View reviewed changes

keharper merged commit 7fa9962 into magento:develop Aug 19, 2019

m2-community-project bot removed the Progress: approved label Aug 19, 2019


		### Set payment method and place order {#setPaymentMethodAndPlaceOrder}

		Use the `setPaymentMethodAndPlaceOrder` mutation to set the payment method for your order.


		Response

		If the operation is successful, the response contains the code of the selected payment method.

	\|`setPaymentMethodAndPlaceOrder`\|Sets the payment method and then immediately places your order. In this case ["Step 10. Place the order"]({{ page.baseurl }}/graphql/tutorials/checkout/checkout-place-order.md) can be skipped\|
	\|`setPaymentMethodAndPlaceOrder`\|Sets the payment method and then immediately places your order. In this case ["Step 10. Place the order"]({{ page.baseurl }}/graphql/tutorials/checkout/checkout-place-order.html) can be skipped\|

magento/devdocs#: Add info about setPaymentMethodAndPlaceOrder to GraphQL checkout tutorial #4950

magento/devdocs#: Add info about setPaymentMethodAndPlaceOrder to GraphQL checkout tutorial #4950

Uh oh!

Conversation

atwixfirster commented Jul 14, 2019 • edited by keharper Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose of this pull request

Affected DevDocs pages

Links to Magento source code

Uh oh!

devops-devdocs commented Jul 14, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

keharper left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

keharper commented Aug 18, 2019

Uh oh!

keharper left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

keharper commented Aug 19, 2019

Uh oh!

ghost commented Aug 19, 2019

Uh oh!

keharper commented Aug 19, 2019

Uh oh!

meker12 commented Aug 19, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

atwixfirster commented Jul 14, 2019 •

edited by keharper

Loading