Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Commit d3c0b97

Browse files
committed
#8483: Code review changes
1 parent 3bf3d5d commit d3c0b97

File tree

2 files changed

+4
-17
lines changed

2 files changed

+4
-17
lines changed

src/contributor-guide/contributing.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ Review the following supported and accepted pull request rules. We defined these
148148

149149
For complete information about contributing to Magento projects, see the [Beginner Guides](https://github.com/magento/magento2/wiki/Getting-Started) on the Magento 2 repository. These guides help you:
150150

151-
_ Select an issue to work on and self-assign
151+
- Select an issue to work on and self-assign
152152
- Fork a repository
153153
- Create a branch
154154
- Fix/implement the functionality

src/contributor-guide/pull-request-tests.md

Lines changed: 3 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,7 @@ Please see the [Backward Compatibility Development Guide](https://devdocs.magent
2424
Functional Tests are PHPUnit-based tests that check Magento functional behavior from the perspective of a user. They press buttons and links in browser, fill and submit forms, look and check what is displayed in the browser's window like real users.
2525

2626
### Sample Data Tests
27-
Sample Data Tests are functional tests that run on Magento with Sample Data included. Currently they include two kinds of tests:
28-
* Sample Data functional tests which check Magento functional behavior with Sample Data installed
29-
* Installation Functional tests which check Magento installation flow with Sample Data installed
27+
Sample Data Tests are functional tests that run on Magento with Sample Data included.
3028

3129
### Unit Tests
3230
Unit tests are PHPUnit-based (for PHP) and Jasmine-based (for JS) tests which check the behavior of single methods of Magento classes. The purpose is to validate that each unit of Magento performs as designed.
@@ -44,22 +42,11 @@ WebAPI Tests are functional tests that check the behavior of Magento Web API end
4442
* GraphQL WEB API tests
4543

4644
### Static Tests
47-
Static Tests are set of different checks that analyze each single file of Magento code base separately. Most of them analyze the whole Magento code base whereas some run only against the change set. They include:
48-
* Static Integration tests (PHPUnit-based) which check the consistency of Magento instance without installation (configuration files, DB schemes etc.)
49-
* Static Legacy Tests which check Magento code doesn't contain any deprecated approaches and patterns.
50-
* Static PHP, LESS, JS, TS, HTML, GraphQL Code Style tests which check Magento source code against the best practices of programming style (Code style, Mess detector, Copy/Paste detector)
51-
* Static Sanity Check which tests Magento code against dictionary of forbidden words.
52-
* Static Conflicts Check which tests Magento code doesn't contain duplicate file paths between Magento editions and bundle extensions.
45+
Static Tests are set of different checks that analyze each single file of Magento code base separately. Most of them analyze the whole Magento code base whereas some run only against the change set.
5346

5447
### Database Compare
5548

56-
Database Compare is a test which compares DB schema and data between freshly installed Magento instance (from the PR code) and another instance which was upgraded to the PR code from the pre-previous latest minor release Magento version. Usually it runs several separate scenarios:
57-
* Upgrade from the latest pre-previous minor release directly to the PR code (e.g. 2.2.x => 2.4-based PR code)
58-
* Upgrade from the latest pre-previous minor release to previous minor release, and the to the PR code (e.g. 2.2.x => 2.3.x => 2.4-based PR code)
59-
* Upgrade from the latest pre-previous minor release directly to the PR code with sample data (e.g. 2.2.x => 2.4-based PR code)
60-
* Upgrade from the latest pre-previous minor release to previous minor release, and the to the PR code with sample data (e.g. 2.2.x => 2.3.x => 2.4-based PR code)
61-
62-
When testing Magento code with extensions or just extensions, the test installs them on a resulting Magento instance (both on freshly installed Magento instance and upgraded one).
49+
Database Compare is a test which compares DB schema and data between freshly installed Magento instance (from the PR code) and another instance which was upgraded to the PR code from the pre-previous latest minor release Magento version.
6350

6451
### Magento Component Health Index
6552

0 commit comments

Comments
 (0)