magento#7698: Admin Global Search was build in a hurry

Author: RomaKis

app/code/Magento/Backend/Block/GlobalSearch.php

@@ -16,23 +16,6 @@
  */
 class GlobalSearch extends \Magento\Backend\Block\Template
 {
-    const ENTITY_TYPE_PRODUCTS = 'Products';
-    const ENTITY_TYPE_ORDERS = 'Orders';
-    const ENTITY_TYPE_CUSTOMERS = 'Customers';
-    const ENTITY_TYPE_PAGES = 'Pages';
-
-    /**
-     * Affiliation between entity types for global search and corresponding admin resources.
-     *
-     * @var array
-     */
-    private $entityTypes = [
-        self::ENTITY_TYPE_PRODUCTS => \Magento\Catalog\Controller\Adminhtml\Product::ADMIN_RESOURCE,
-        self::ENTITY_TYPE_ORDERS => \Magento\Sales\Controller\Adminhtml\Order::ADMIN_RESOURCE,
-        self::ENTITY_TYPE_CUSTOMERS => \Magento\Customer\Controller\Adminhtml\Index::ADMIN_RESOURCE,
-        self::ENTITY_TYPE_PAGES => \Magento\Cms\Controller\Adminhtml\Page\Index::ADMIN_RESOURCE,
-    ];
-
     /**
      * @var SearchEntityFactory
      */
@@ -43,19 +26,34 @@ class GlobalSearch extends \Magento\Backend\Block\Template
      */
     protected $_template = 'Magento_Backend::system/search.phtml';
 
+    /**
+     * @var array
+     */
+    private $entityResources;
+
+    /**
+     * @var array
+     */
+    private $entityPaths;
+
     /**
      * @param Template\Context $context
      * @param array $data
+     * @param array $entityResources
+     * @param array $entityPaths
      * @param SearchEntityFactory|null $searchEntityFactory
      */
     public function __construct(
         Template\Context $context,
         array $data = [],
+        array $entityResources = [],
+        array $entityPaths = [],
         SearchEntityFactory $searchEntityFactory = null
     ) {
-        $this->searchEntityFactory = $searchEntityFactory ?: ObjectManager::getInstance()->get(
-            SearchEntityFactory::class
-        );
+        $this->entityResources = $entityResources;
+        $this->entityPaths = $entityPaths;
+        $this->searchEntityFactory = $searchEntityFactory ?: ObjectManager::getInstance()
+            ->get(SearchEntityFactory::class);
 
         parent::__construct($context, $data);
     }
@@ -89,7 +87,7 @@ public function getEntitiesToShow()
         $allowedEntityTypes = [];
         $entitiesToShow = [];
 
-        foreach ($this->entityTypes as $entityType => $resource) {
+        foreach ($this->entityResources as $entityType => $resource) {
             if ($this->getAuthorization()->isAllowed($resource)) {
                 $allowedEntityTypes[] = $entityType;
             }
@@ -118,22 +116,7 @@ public function getEntitiesToShow()
      */
     private function getUrlEntityType(string $entityType)
     {
-        $urlPath = '';
-
-        switch ($entityType) {
-            case self::ENTITY_TYPE_PRODUCTS:
-                $urlPath = 'catalog/product/index/';
-                break;
-            case self::ENTITY_TYPE_ORDERS:
-                $urlPath = 'sales/order/index/';
-                break;
-            case self::ENTITY_TYPE_CUSTOMERS:
-                $urlPath = 'customer/index/index/';
-                break;
-            case self::ENTITY_TYPE_PAGES:
-                $urlPath = 'cms/page/index/';
-                break;
-        }
+        $urlPath = $this->entityPaths[$entityType] ?? '';
 
         return $this->getUrl($urlPath);
     }

app/code/Magento/Backend/Test/Unit/Block/GlobalSearchTest.php

@@ -35,6 +35,26 @@ class GlobalSearchTest extends \PHPUnit\Framework\TestCase
      */
     private $searchEntityFactory;
 
+    /**
+     * @var array
+     */
+    private $entityResources = [
+        'Products' => \Magento\Catalog\Controller\Adminhtml\Product::ADMIN_RESOURCE,
+        'Orders' => \Magento\Sales\Controller\Adminhtml\Order::ADMIN_RESOURCE,
+        'Customers' => \Magento\Customer\Controller\Adminhtml\Index::ADMIN_RESOURCE,
+        'Pages' => \Magento\Cms\Controller\Adminhtml\Page\Index::ADMIN_RESOURCE,
+    ];
+
+    /**
+     * @var array
+     */
+    private $entityPaths = [
+        'Products' => 'catalog/product/index/',
+        'Orders' => 'sales/order/index/',
+        'Customers' => 'customer/index/index',
+        'Pages' => 'cms/page/index/',
+    ];
+
     protected function setUp()
     {
         $objectManager = new ObjectManager($this);
@@ -53,6 +73,8 @@ protected function setUp()
             [
                 'context' => $context,
                 'searchEntityFactory' => $this->searchEntityFactory,
+                'entityResources' => $this->entityResources,
+                'entityPaths' => $this->entityPaths,
             ]
         );
     }

app/code/Magento/Backend/etc/adminhtml/di.xml

@@ -155,4 +155,20 @@
             <argument name="defaultClass" xsi:type="string">Magento\Backend\Block\Template</argument>
         </arguments>
     </type>
+    <type name="Magento\Backend\Block\GlobalSearch">
+        <arguments>
+            <argument name="entityResources" xsi:type="array">
+                <item name="Products" xsi:type="string">Magento_Catalog::products</item>
+                <item name="Orders" xsi:type="string">Magento_Sales::sales_order</item>
+                <item name="Customers" xsi:type="string">Magento_Customer::manage</item>
+                <item name="Pages" xsi:type="string">Magento_Cms::page</item>
+            </argument>
+            <argument name="entityPaths" xsi:type="array">
+                <item name="Products" xsi:type="string">catalog/product/index/</item>
+                <item name="Orders" xsi:type="string">sales/order/index/</item>
+                <item name="Customers" xsi:type="string">customer/index/index</item>
+                <item name="Pages" xsi:type="string">cms/page/index/</item>
+            </argument>
+        </arguments>
+    </type>
 </config>