Apply suggestions from code review

Author: edmocosta

spec/plugin_mixin/http_client_ssl_spec.rb

@@ -4,22 +4,22 @@
 require 'stud/temporary'
 
 shared_examples 'setting ca bundles' do |key, type|
-  subject { plugin_class.new(conf).send(:client_config) }
+  subject(:client_config) { plugin_class.new(conf).send(:client_config) }
 
   it 'should correctly set the path' do
-    expect(subject[:ssl][key]).to eql(path), "Expected to find path for #{key}"
+    expect(client_config[:ssl][key]).to eql(path), "Expected to find path for #{key}"
   end
 
   if type == :jks
     let(:store_password) { conf["#{use_deprecated_config ? '' : 'ssl_'}#{key}_password"] }
     let(:store_type) { conf["#{use_deprecated_config ? '' : 'ssl_'}#{key}_type"]}
 
     it 'should set the bundle password' do
-      expect(subject[:ssl]["#{key}_password".to_sym]).to eql(store_password)
+      expect(client_config[:ssl]["#{key}_password".to_sym]).to eql(store_password)
     end
 
     it 'should set the bundle type' do
-      expect(subject[:ssl]["#{key}_type".to_sym]).to eql(store_type)
+      expect(client_config[:ssl]["#{key}_type".to_sym]).to eql(store_type)
     end
   end
 end
@@ -409,7 +409,7 @@ class PluginWithDeprecatedFalse < LogStash::Inputs::Base
       }
     end
 
-    subject { plugin_class.new(settings) }
+    subject(:plugin_instance) { plugin_class.new(settings) }
 
     after do
       File.unlink(cacert)
@@ -420,25 +420,25 @@ class PluginWithDeprecatedFalse < LogStash::Inputs::Base
     end
 
     it 'normalizes deprecated settings' do
-      expect(subject.ssl_certificate_authorities).to eq([cacert])
-      expect(subject.ssl_certificate).to eq(client_cert)
-      expect(subject.ssl_key).to eq(client_key)
-      expect(subject.ssl_keystore_path).to eq(keystore)
-      expect(subject.ssl_keystore_password.value).to eq(keystore_password)
-      expect(subject.ssl_keystore_type).to eq(keystore_type)
-      expect(subject.ssl_truststore_path).to eq(truststore)
-      expect(subject.ssl_truststore_password.value).to eq(truststore_password)
-      expect(subject.ssl_truststore_type).to eq(truststore_type)
-
-      expect(subject.params['ssl_certificate_authorities']).to eq([cacert])
-      expect(subject.params['ssl_certificate']).to eq(client_cert)
-      expect(subject.params['ssl_key']).to eq(client_key)
-      expect(subject.params['ssl_keystore_path']).to eq(keystore)
-      expect(subject.params['ssl_keystore_password'].value).to eq(keystore_password)
-      expect(subject.params['ssl_keystore_type']).to eq(keystore_type)
-      expect(subject.params['ssl_truststore_path']).to eq(truststore)
-      expect(subject.params['ssl_truststore_password'].value).to eq(truststore_password)
-      expect(subject.params['ssl_truststore_type']).to eq(truststore_type)
+      expect(plugin_instance.ssl_certificate_authorities).to eq([cacert])
+      expect(plugin_instance.ssl_certificate).to eq(client_cert)
+      expect(plugin_instance.ssl_key).to eq(client_key)
+      expect(plugin_instance.ssl_keystore_path).to eq(keystore)
+      expect(plugin_instance.ssl_keystore_password.value).to eq(keystore_password)
+      expect(plugin_instance.ssl_keystore_type).to eq(keystore_type)
+      expect(plugin_instance.ssl_truststore_path).to eq(truststore)
+      expect(plugin_instance.ssl_truststore_password.value).to eq(truststore_password)
+      expect(plugin_instance.ssl_truststore_type).to eq(truststore_type)
+
+      expect(plugin_instance.params['ssl_certificate_authorities']).to eq([cacert])
+      expect(plugin_instance.params['ssl_certificate']).to eq(client_cert)
+      expect(plugin_instance.params['ssl_key']).to eq(client_key)
+      expect(plugin_instance.params['ssl_keystore_path']).to eq(keystore)
+      expect(plugin_instance.params['ssl_keystore_password'].value).to eq(keystore_password)
+      expect(plugin_instance.params['ssl_keystore_type']).to eq(keystore_type)
+      expect(plugin_instance.params['ssl_truststore_path']).to eq(truststore)
+      expect(plugin_instance.params['ssl_truststore_password'].value).to eq(truststore_password)
+      expect(plugin_instance.params['ssl_truststore_type']).to eq(truststore_type)
     end
   end