[LLDB][Windows Build]Removed header and validated on new windows machine #96724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@llvm/pr-subscribers-lldb Author: Jacob Lalonde (Jlalond) Changes
In #95312 uint and Full diff: https://github.com/llvm/llvm-project/pull/96724.diff 1 Files Affected:
diff --git a/lldb/source/Plugins/ObjectFile/Minidump/ObjectFileMinidump.cpp b/lldb/source/Plugins/ObjectFile/Minidump/ObjectFileMinidump.cpp
index 3668c37c5191d..7c875aa3223ed 100644
--- a/lldb/source/Plugins/ObjectFile/Minidump/ObjectFileMinidump.cpp
+++ b/lldb/source/Plugins/ObjectFile/Minidump/ObjectFileMinidump.cpp
@@ -18,7 +18,6 @@
#include "lldb/Utility/Log.h"
#include "llvm/Support/FileSystem.h"
-#include <unistd.h>
using namespace lldb;
using namespace lldb_private;
|
Contributor
Author
|
Hey @petrhosek @vvereschaka apologies about the delay, I had to get a Windows machine up to validate this. |
Contributor
|
Thank you @Jlalond , I started checking the local builds on Windows/Linux hosts with these changes. |
Jlalond
changed the title
AlexisPerry
pushed a commit
to llvm-project-tlp/llvm-project
that referenced
this pull request
Jul 9, 2024
 In llvm#95312 uint and `#include <unistd.h>` were introduced. These broke the windows build. I addressed uint in llvm#96564, but include went unfixed. So I acquired myself a windows machine to validate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #95312 uint and
#include <unistd.h>were introduced. These broke the windows build. I addressed uint in #96564, but include went unfixed. So I acquired myself a windows machine to validate.