Skip to content

Conversation

@DavidSpickett
Copy link
Collaborator

To fix CI after #93712 landed.

@DavidSpickett DavidSpickett marked this pull request as ready for review June 17, 2024 15:46
@llvmbot llvmbot added the lldb label Jun 17, 2024
@llvmbot
Copy link
Member

llvmbot commented Jun 17, 2024

@llvm/pr-subscribers-lldb

Author: David Spickett (DavidSpickett)

Changes

To fix CI after #93712 landed.


Full diff: https://github.com/llvm/llvm-project/pull/95806.diff

1 Files Affected:

  • (modified) lldb/test/requirements.txt (+1)
diff --git a/lldb/test/requirements.txt b/lldb/test/requirements.txt
index 83fbe6a5e1b97..708f2327a6a04 100644
--- a/lldb/test/requirements.txt
+++ b/lldb/test/requirements.txt
@@ -4,3 +4,4 @@ psutil>=5.9.4
 # Pexpect tests are known not to work on Windows, so are disabled.
 # See llvm.org/pr22274.
 pexpect>=4.9.0; sys_platform != 'win32'
+packaging

@DavidSpickett
Copy link
Collaborator Author

Still waiting for a Linux CI build, but I assume this would fix the problem so I'm going to merge this now.

@DavidSpickett DavidSpickett merged commit 13c6638 into llvm:main Jun 17, 2024
@DavidSpickett DavidSpickett deleted the lldb-packaging branch June 17, 2024 16:14
@JDevlieghere
Copy link
Member

Thanks!

@DavidSpickett
Copy link
Collaborator Author

Anyone reading this who has an active PR that this would fix, you'll need to rebase it to include this change. If you're unlikely to effect lldb's tests anyway, I suggest waiting until review is complete before doing the rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants