[DAG] Add SpecificFP matcher #167438
Open
[DAG] Add SpecificFP matcher #167438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
ravil-mobile
force-pushed
the
ravil/sd-specific-fp
branch
from
bcd3afc to
485284a
Compare
RKSimon
reviewed
Nov 11, 2025
| if (const auto *CFP = dyn_cast<ConstantFPSDNode>(V.getNode())) | ||
| if (CFP->isExactlyValue(Val)) | ||
| return true; | ||
| return false; |
Collaborator
There was a problem hiding this comment.
Is it possible to add splat handling as well?
RKSimon
reviewed
Nov 11, 2025
Collaborator
There was a problem hiding this comment.
You need to use m_c_BinOp if you want to test for commutation - otherwise you need to swap the operand matchers (or you can add another test and do both!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces SpeficFP matcher for SelectionDAG nodes.
This includes:
Adding SpecificFP_match() in SDPatternMatch.h.
Adding test coverage in SelectionDAGPatternMatchTest.cpp.
Closes #165566