Skip to content

[MLIR][ODS] Re-enable direct implementation of type interfaces with method bodies #166335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2025
Merged

[MLIR][ODS] Re-enable direct implementation of type interfaces with method bodies #166335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions mlir/test/lib/Dialect/Test/TestTypeDefs.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,4 +470,11 @@ def TestMemrefType : Test_Type<"TestMemref",
}];
}

// Test implementation of an interface with methods specifying a
// method body
def TestBaseBody : Test_Type<"TestBaseBody",
[DeclareTypeInterfaceMethods<TestBaseTypeInterfacePrintTypeA>]> {
let mnemonic = "test_base_body";
}

#endif // TEST_TYPEDEFS
6 changes: 4 additions & 2 deletions mlir/tools/mlir-tblgen/AttrOrTypeDefGen.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -637,8 +637,10 @@ void DefGen::emitTraitMethods(const InterfaceTrait &trait) {
for (auto &method : iface.getMethods()) {
// Don't declare if the method has a body. Or if the method has a default
// implementation and the def didn't request that it always be declared.
if (method.getBody() || (method.getDefaultImplementation() &&
!alwaysDeclared.count(method.getName()))) {
if (method.getBody())
continue;
if (method.getDefaultImplementation() &&
!alwaysDeclared.count(method.getName())) {
genTraitMethodUsingDecl(trait, method);
continue;
}
Expand Down