-
Notifications
You must be signed in to change notification settings - Fork 15.2k
[BOLT][NFC] Clean up the outdated option --write-dwp in doc #166150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@llvm/pr-subscribers-bolt Author: Jinjie Huang (Jinjie-Huang) ChangesSince the "--write-dwp" option have been removed in this pr, this patch also cleans up the corresponding documentation. Full diff: https://github.com/llvm/llvm-project/pull/166150.diff 1 Files Affected:
diff --git a/bolt/docs/CommandLineArgumentReference.md b/bolt/docs/CommandLineArgumentReference.md
index d65cf39e16b29..636db823a2da2 100644
--- a/bolt/docs/CommandLineArgumentReference.md
+++ b/bolt/docs/CommandLineArgumentReference.md
@@ -381,11 +381,6 @@
Set verbosity level for diagnostic output
-- `--write-dwp`
-
- Output a single dwarf package file (dwp) instead of multiple non-relocatable
- dwarf object files (dwo).
-
### BOLT optimization options:
- `--align-blocks`
|
paschalis-mpeis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Maybe worth removing the usage of the unsupported test in bolt/test/X86/dwarf4-ftypes-dwp-input-dwp-output.test too?
|
Thanks! The outdated test is removed too. |
|
Thanks Jinjie. I was referring only to the flag on line 11, not to the whole (unsupported) test. |
162bf74 to
7f5fc03
Compare
7f5fc03 to
a645886
Compare
ayermolo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the cleanup!
Since the "--write-dwp" option has been removed in PR, this patch also cleans up the corresponding document and test to avoid misleading issues.