Skip to content

Conversation

@Jinjie-Huang
Copy link
Contributor

@Jinjie-Huang Jinjie-Huang commented Nov 3, 2025

Since the "--write-dwp" option has been removed in PR, this patch also cleans up the corresponding document and test to avoid misleading issues.

@llvmbot llvmbot added the BOLT label Nov 3, 2025
@Jinjie-Huang Jinjie-Huang changed the title [BOLT][NFC] Clean up the outdated options --write-dwp in doc [BOLT][NFC] Clean up the outdated option --write-dwp in doc Nov 3, 2025
@llvmbot
Copy link
Member

llvmbot commented Nov 3, 2025

@llvm/pr-subscribers-bolt

Author: Jinjie Huang (Jinjie-Huang)

Changes

Since the "--write-dwp" option have been removed in this pr, this patch also cleans up the corresponding documentation.


Full diff: https://github.com/llvm/llvm-project/pull/166150.diff

1 Files Affected:

  • (modified) bolt/docs/CommandLineArgumentReference.md (-5)
diff --git a/bolt/docs/CommandLineArgumentReference.md b/bolt/docs/CommandLineArgumentReference.md
index d65cf39e16b29..636db823a2da2 100644
--- a/bolt/docs/CommandLineArgumentReference.md
+++ b/bolt/docs/CommandLineArgumentReference.md
@@ -381,11 +381,6 @@
 
   Set verbosity level for diagnostic output
 
-- `--write-dwp`
-
-  Output a single dwarf package file (dwp) instead of multiple non-relocatable
-  dwarf object files (dwo).
-
 ### BOLT optimization options:
 
 - `--align-blocks`

Copy link
Member

@paschalis-mpeis paschalis-mpeis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Maybe worth removing the usage of the unsupported test in bolt/test/X86/dwarf4-ftypes-dwp-input-dwp-output.test too?

@Jinjie-Huang
Copy link
Contributor Author

Thanks! The outdated test is removed too.

@paschalis-mpeis
Copy link
Member

Thanks Jinjie. I was referring only to the flag on line 11, not to the whole (unsupported) test.
I'll defer to others if they're fine with removing it (cc: @ayermolo, @grigorypas).

@Jinjie-Huang
Copy link
Contributor Author

Jinjie-Huang commented Nov 3, 2025

Got it, It looks like this test aims to compare the pre-BOLT and post-BOLT DWP files for consistency. A better way might be to use llvm-dwp manually and remove the outdated usage. Thanks to recent patch from @Sockke, this test can be re-enabled now.

@Jinjie-Huang Jinjie-Huang force-pushed the clean_write_dwp_in_docs branch from 162bf74 to 7f5fc03 Compare November 3, 2025 12:15
@Jinjie-Huang Jinjie-Huang force-pushed the clean_write_dwp_in_docs branch from 7f5fc03 to a645886 Compare November 3, 2025 12:33
@Jinjie-Huang Jinjie-Huang requested a review from Sockke November 3, 2025 12:48
Copy link
Contributor

@ayermolo ayermolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup!

@Jinjie-Huang Jinjie-Huang merged commit f7be258 into llvm:main Nov 4, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants