From 8c2f955f553f18756241c46d7a64f6887225609b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Storsj=C3=B6?= Date: Wed, 17 Sep 2025 14:29:58 +0300 Subject: [PATCH] Add parentheses to clarify operator ordering in asserts. NFC. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This avoids the following kind of warning with GCC: ../tools/llvm-lipo/llvm-lipo.cpp: In function ‘void printInfo(llvm::LLVMContext&, llvm::ArrayRef >)’: ../tools/llvm-lipo/llvm-lipo.cpp:464:34: warning: suggest parentheses around ‘& ’ within ‘||’ [-Wparentheses] 464 | Binary->isArchive() && "expected MachO binary"); | ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ --- clang/lib/CodeGen/CGHLSLRuntime.cpp | 6 +++--- llvm/tools/llvm-lipo/llvm-lipo.cpp | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/clang/lib/CodeGen/CGHLSLRuntime.cpp b/clang/lib/CodeGen/CGHLSLRuntime.cpp index 49bc408a1b305..cf018c8c7de2a 100644 --- a/clang/lib/CodeGen/CGHLSLRuntime.cpp +++ b/clang/lib/CodeGen/CGHLSLRuntime.cpp @@ -922,9 +922,9 @@ void CGHLSLRuntime::emitInitListOpaqueValues(CodeGenFunction &CGF, std::optional CGHLSLRuntime::emitResourceArraySubscriptExpr( const ArraySubscriptExpr *ArraySubsExpr, CodeGenFunction &CGF) { - assert(ArraySubsExpr->getType()->isHLSLResourceRecord() || - ArraySubsExpr->getType()->isHLSLResourceRecordArray() && - "expected resource array subscript expression"); + assert((ArraySubsExpr->getType()->isHLSLResourceRecord() || + ArraySubsExpr->getType()->isHLSLResourceRecordArray()) && + "expected resource array subscript expression"); // Let clang codegen handle local resource array subscripts, // or when the subscript references on opaque expression (as part of diff --git a/llvm/tools/llvm-lipo/llvm-lipo.cpp b/llvm/tools/llvm-lipo/llvm-lipo.cpp index d4b1f8f3dd7d4..3e1d4165e8ed7 100644 --- a/llvm/tools/llvm-lipo/llvm-lipo.cpp +++ b/llvm/tools/llvm-lipo/llvm-lipo.cpp @@ -460,8 +460,8 @@ printInfo(LLVMContext &LLVMCtx, ArrayRef> InputBinaries) { for (auto &IB : InputBinaries) { const Binary *Binary = IB.getBinary(); if (!Binary->isMachOUniversalBinary()) { - assert(Binary->isMachO() || - Binary->isArchive() && "expected MachO binary"); + assert((Binary->isMachO() || Binary->isArchive()) && + "expected MachO binary"); outs() << "Non-fat file: " << Binary->getFileName() << " is architecture: "; printBinaryArchs(LLVMCtx, Binary, outs());