Skip to content

Conversation

@durin42
Copy link
Contributor

@durin42 durin42 commented Aug 11, 2025

Noticed this in the Rust/LLVM-HEAD CI, which for some obscure reason bothers to build Xtensa.

@llvmbot
Copy link
Member

llvmbot commented Aug 11, 2025

@llvm/pr-subscribers-backend-xtensa

Author: Augie Fackler (durin42)

Changes

Noticed this in the Rust/LLVM-HEAD CI, which for some obscure reason bothers to build Xtensa.


Full diff: https://github.com/llvm/llvm-project/pull/153054.diff

1 Files Affected:

  • (modified) llvm/lib/Target/Xtensa/XtensaISelLowering.cpp (+1-1)
diff --git a/llvm/lib/Target/Xtensa/XtensaISelLowering.cpp b/llvm/lib/Target/Xtensa/XtensaISelLowering.cpp
index 6a07bd865a15a..954e623b8c7c4 100644
--- a/llvm/lib/Target/Xtensa/XtensaISelLowering.cpp
+++ b/llvm/lib/Target/Xtensa/XtensaISelLowering.cpp
@@ -353,7 +353,7 @@ static const MCPhysReg IntRegs[] = {Xtensa::A2, Xtensa::A3, Xtensa::A4,
 
 static bool CC_Xtensa_Custom(unsigned ValNo, MVT ValVT, MVT LocVT,
                              CCValAssign::LocInfo LocInfo,
-                             ISD::ArgFlagsTy ArgFlags, CCState &State) {
+                             ISD::ArgFlagsTy ArgFlags, Type *OrigTy, CCState &State) {
   if (ArgFlags.isByVal()) {
     Align ByValAlign = ArgFlags.getNonZeroByValAlign();
     unsigned ByValSize = ArgFlags.getByValSize();

@github-actions
Copy link

github-actions bot commented Aug 11, 2025

✅ With the latest revision this PR passed the C/C++ code formatter.

Noticed this in the Rust/LLVM-HEAD CI, which for some obscure reason
bothers to build Xtensa.
@durin42 durin42 force-pushed the xtensa-refactor-fix branch from c44335a to 7893f33 Compare August 11, 2025 17:35
@Sterling-Augustine Sterling-Augustine self-requested a review August 11, 2025 17:45
@Sterling-Augustine
Copy link
Contributor

looks good.

Copy link
Contributor

@ilovepi ilovepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We saw the same thing in Fuchsia's Rust CI. Thanks for the fix

@durin42 durin42 merged commit e0f5e28 into llvm:main Aug 11, 2025
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants