-
Notifications
You must be signed in to change notification settings - Fork 15.2k
[AArch64] Removed redundant FMOV instruction for truncstores of f64/f32 via bitcast to i64/i32/i8. #149997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[AArch64] Removed redundant FMOV instruction for truncstores of f64/f32 via bitcast to i64/i32/i8. #149997
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
97f61b4
[AArch64] Add TableGen patterns for truncstore of bitcasted FP values…
Amichaxx 3faa302
Added tests for converting from int to fp, renamed tests
Amichaxx efa6fab
Removed predicates from patterns and feature flags from test
Amichaxx a2169a9
Alignment
Amichaxx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,83 @@ | ||
| ; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 5 | ||
| ; RUN: llc -mtriple=aarch64-unknown-linux-gnu < %s | FileCheck %s | ||
|
|
||
| define void @_Z10test_truncstore_f64toi32Pjd(ptr %n, double %x) { | ||
| ; CHECK-LABEL: _Z10test_truncstore_f64toi32Pjd: | ||
| ; CHECK: // %bb.0: | ||
| ; CHECK-NEXT: str s0, [x0] | ||
| ; CHECK-NEXT: ret | ||
| %i64 = bitcast double %x to i64 | ||
| %conv = trunc i64 %i64 to i32 | ||
| store i32 %conv, ptr %n, align 4 | ||
| ret void | ||
| } | ||
|
|
||
| define void @_Z9test_truncstore_f64toi16Ptd(ptr %n, double %x) { | ||
| ; CHECK-LABEL: _Z9test_truncstore_f64toi16Ptd: | ||
| ; CHECK: // %bb.0: | ||
| ; CHECK-NEXT: str h0, [x0] | ||
| ; CHECK-NEXT: ret | ||
| %i64 = bitcast double %x to i64 | ||
| %conv = trunc i64 %i64 to i16 | ||
| store i16 %conv, ptr %n, align 2 | ||
| ret void | ||
| } | ||
|
|
||
| define void @_Z13test_truncstore_f64toi8Phd(ptr %n, double %x) { | ||
| ; CHECK-LABEL: _Z13test_truncstore_f64toi8Phd: | ||
| ; CHECK: // %bb.0: | ||
| ; CHECK-NEXT: str b0, [x0] | ||
| ; CHECK-NEXT: ret | ||
| %i64 = bitcast double %x to i64 | ||
| %conv = trunc i64 %i64 to i8 | ||
| store i8 %conv, ptr %n, align 1 | ||
| ret void | ||
| } | ||
|
|
||
| define void @_Z17test_truncstore_f32toi16Ptf(ptr %n, float %x) { | ||
| ; CHECK-LABEL: _Z17test_truncstore_f32toi16Ptf: | ||
| ; CHECK: // %bb.0: | ||
| ; CHECK-NEXT: str h0, [x0] | ||
| ; CHECK-NEXT: ret | ||
| %i32 = bitcast float %x to i32 | ||
| %conv = trunc i32 %i32 to i16 | ||
| store i16 %conv, ptr %n, align 2 | ||
| ret void | ||
| } | ||
|
|
||
| define void @_Z16test_truncstore_f32toi8Phf(ptr %n, float %x) { | ||
| ; CHECK-LABEL: _Z16test_truncstore_f32toi8Phf: | ||
| ; CHECK: // %bb.0: | ||
| ; CHECK-NEXT: str b0, [x0] | ||
| ; CHECK-NEXT: ret | ||
| %i32 = bitcast float %x to i32 | ||
| %conv = trunc i32 %i32 to i8 | ||
| store i8 %conv, ptr %n, align 1 | ||
| ret void | ||
| } | ||
|
|
||
| define void @test_truncstore_i64tof32(ptr %n, i64 %x) { | ||
| ; CHECK-LABEL: test_truncstore_i64tof32: | ||
| ; CHECK: // %bb.0: | ||
| ; CHECK-NEXT: fmov d0, x1 | ||
| ; CHECK-NEXT: fcvt s0, d0 | ||
| ; CHECK-NEXT: str s0, [x0] | ||
| ; CHECK-NEXT: ret | ||
| %d = bitcast i64 %x to double | ||
| %f = fptrunc double %d to float | ||
| store float %f, ptr %n, align 4 | ||
| ret void | ||
| } | ||
|
|
||
| define void @test_truncstore_i32tof16(ptr %n, i32 %x) { | ||
| ; CHECK-LABEL: test_truncstore_i32tof16: | ||
| ; CHECK: // %bb.0: | ||
| ; CHECK-NEXT: fmov s0, w1 | ||
| ; CHECK-NEXT: fcvt h0, s0 | ||
| ; CHECK-NEXT: str h0, [x0] | ||
| ; CHECK-NEXT: ret | ||
| %f = bitcast i32 %x to float | ||
| %h = fptrunc float %f to half | ||
| store half %h, ptr %n, align 2 | ||
| ret void | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.