From b343316764b32d60c29ce138e2e965864459f898 Mon Sep 17 00:00:00 2001 From: bassiounix Date: Thu, 10 Jul 2025 07:53:12 +0300 Subject: [PATCH] [libc][math] Refactor frexpf16 implementation to header-only in src/__support/math folder. --- libc/shared/math.h | 1 + libc/shared/math/frexpf16.h | 29 ++++++++++++++++ libc/src/__support/math/CMakeLists.txt | 10 ++++++ libc/src/__support/math/frexpf16.h | 34 +++++++++++++++++++ libc/src/math/generic/CMakeLists.txt | 3 +- libc/src/math/generic/frexpf16.cpp | 7 ++-- .../llvm-project-overlay/libc/BUILD.bazel | 18 +++++++++- 7 files changed, 95 insertions(+), 7 deletions(-) create mode 100644 libc/shared/math/frexpf16.h create mode 100644 libc/src/__support/math/frexpf16.h diff --git a/libc/shared/math.h b/libc/shared/math.h index 4ddc29c7ae834..e6cbf816082e6 100644 --- a/libc/shared/math.h +++ b/libc/shared/math.h @@ -12,5 +12,6 @@ #include "libc_common.h" #include "math/expf.h" +#include "math/frexpf16.h" #endif // LLVM_LIBC_SHARED_MATH_H diff --git a/libc/shared/math/frexpf16.h b/libc/shared/math/frexpf16.h new file mode 100644 index 0000000000000..24b2883a6f910 --- /dev/null +++ b/libc/shared/math/frexpf16.h @@ -0,0 +1,29 @@ +//===-- Shared frexpf16 function --------------------------------*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception +// +//===----------------------------------------------------------------------===// + +#ifndef LLVM_LIBC_SHARED_MATH_FREXPF16_H +#define LLVM_LIBC_SHARED_MATH_FREXPF16_H + +#include "include/llvm-libc-macros/float16-macros.h" +#include "shared/libc_common.h" + +#ifdef LIBC_TYPES_HAS_FLOAT16 + +#include "src/__support/math/frexpf16.h" + +namespace LIBC_NAMESPACE_DECL { +namespace shared { + +using math::frexpf16; + +} // namespace shared +} // namespace LIBC_NAMESPACE_DECL + +#endif // LIBC_TYPES_HAS_FLOAT16 + +#endif // LLVM_LIBC_SHARED_MATH_FREXPF16_H diff --git a/libc/src/__support/math/CMakeLists.txt b/libc/src/__support/math/CMakeLists.txt index 66c1d19a1cab0..b9f21d32ebf86 100644 --- a/libc/src/__support/math/CMakeLists.txt +++ b/libc/src/__support/math/CMakeLists.txt @@ -22,3 +22,13 @@ add_header_library( libc.src.__support.macros.config libc.src.__support.macros.optimization ) + +add_header_library( + frexpf16 + HDRS + frexpf16.h + DEPENDS + libc.src.__support.macros.config + libc.src.__support.macros.properties.types + libc.src.__support.FPUtil.manipulation_functions +) diff --git a/libc/src/__support/math/frexpf16.h b/libc/src/__support/math/frexpf16.h new file mode 100644 index 0000000000000..8deeba0f43e3a --- /dev/null +++ b/libc/src/__support/math/frexpf16.h @@ -0,0 +1,34 @@ +//===-- Implementation header for frexpf16 ----------------------*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception +// +//===----------------------------------------------------------------------===// + +#ifndef LLVM_LIBC_SRC___SUPPORT_MATH_FREXPF16_H +#define LLVM_LIBC_SRC___SUPPORT_MATH_FREXPF16_H + +#include "include/llvm-libc-macros/float16-macros.h" + +#ifdef LIBC_TYPES_HAS_FLOAT16 + +#include "src/__support/FPUtil/ManipulationFunctions.h" +#include "src/__support/common.h" +#include "src/__support/macros/config.h" + +namespace LIBC_NAMESPACE_DECL { + +namespace math { + +static constexpr float16 frexpf16(float16 x, int *exp) { + return fputil::frexp(x, *exp); +} + +} // namespace math + +} // namespace LIBC_NAMESPACE_DECL + +#endif // LIBC_TYPES_HAS_FLOAT16 + +#endif // LLVM_LIBC_SRC___SUPPORT_MATH_FREXPF16_H diff --git a/libc/src/math/generic/CMakeLists.txt b/libc/src/math/generic/CMakeLists.txt index fd1e6c0d648aa..1e54d64427117 100644 --- a/libc/src/math/generic/CMakeLists.txt +++ b/libc/src/math/generic/CMakeLists.txt @@ -1775,8 +1775,7 @@ add_entrypoint_object( HDRS ../frexpf16.h DEPENDS - libc.src.__support.macros.properties.types - libc.src.__support.FPUtil.manipulation_functions + libc.src.__support.math.frexpf16 ) add_entrypoint_object( diff --git a/libc/src/math/generic/frexpf16.cpp b/libc/src/math/generic/frexpf16.cpp index 4571b0d0ea389..fa918fd7ffc39 100644 --- a/libc/src/math/generic/frexpf16.cpp +++ b/libc/src/math/generic/frexpf16.cpp @@ -7,14 +7,13 @@ //===----------------------------------------------------------------------===// #include "src/math/frexpf16.h" -#include "src/__support/FPUtil/ManipulationFunctions.h" -#include "src/__support/common.h" -#include "src/__support/macros/config.h" + +#include "src/__support/math/frexpf16.h" namespace LIBC_NAMESPACE_DECL { LLVM_LIBC_FUNCTION(float16, frexpf16, (float16 x, int *exp)) { - return fputil::frexp(x, *exp); + return math::frexpf16(x, exp); } } // namespace LIBC_NAMESPACE_DECL diff --git a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel index 2484a2f1e2bd7..f6f2973cee322 100644 --- a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel +++ b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel @@ -2096,6 +2096,17 @@ libc_support_library( ], ) +libc_support_library( + name = "__support_math_frexpf16", + hdrs = ["src/__support/math/frexpf16.h"], + deps = [ + ":__support_macros_config", + ":__support_macros_properties_types", + ":__support_fputil_manipulation_functions", + ":llvm_libc_macros_float16_macros" + ], +) + ############################### complex targets ################################ libc_function( @@ -3148,7 +3159,12 @@ libc_math_function(name = "frexpl") libc_math_function(name = "frexpf128") -libc_math_function(name = "frexpf16") +libc_math_function( + name = "frexpf16", + additional_deps = [ + ":__support_math_frexpf16" + ], +) libc_math_function(name = "fromfp")