From 971863e1bc836b1f839e088bb6c051f061ad0d54 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 10 Feb 2025 14:43:12 +0000 Subject: [PATCH 1/2] [llvm][lit] Make Xunit time test regex less strict I got a report that downstream this test failed and the cause was that it took longer than the 1 second we expected to run one of the test cases. There's no reason for this test to be that specific, so I've changed all the [0-1] to [0-9]+. This test does not care whether the times make any sense, only that they exist. A couple exisitng regex here make the decimal point optional, and on my machine I always seem to get `.00`. So I think they are always finding a decimal point anyway. I've left them just on the slim chance that some platform happens to print that time as a single number if it's a whole number of seconds. --- llvm/utils/lit/tests/xunit-output.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/llvm/utils/lit/tests/xunit-output.py b/llvm/utils/lit/tests/xunit-output.py index 392cded4653fe..35e092e9e4e55 100644 --- a/llvm/utils/lit/tests/xunit-output.py +++ b/llvm/utils/lit/tests/xunit-output.py @@ -10,17 +10,17 @@ # CHECK: # CHECK-NEXT: # CHECK-NEXT: -# CHECK-NEXT: +# CHECK-NEXT: # CHECK-NEXT: ]]]]> &"]]> # CHECK-NEXT: -# CHECK-NEXT: +# CHECK-NEXT: # CHECK-NEXT: # CHECK-NEXT: -# CHECK-NEXT: +# CHECK-NEXT: # CHECK-NEXT: # CHECK-NEXT: -# CHECK-NEXT: -# CHECK-NEXT: +# CHECK-NEXT: +# CHECK-NEXT: # CHECK-NEXT: # CHECK-NEXT: # CHECK-NEXT: From 9ffdacf4a6b378e655cb68a8923350fd0b86873d Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 10 Feb 2025 15:03:34 +0000 Subject: [PATCH 2/2] make them all the same --- llvm/utils/lit/tests/xunit-output.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/llvm/utils/lit/tests/xunit-output.py b/llvm/utils/lit/tests/xunit-output.py index 35e092e9e4e55..c6cf3dfc24c81 100644 --- a/llvm/utils/lit/tests/xunit-output.py +++ b/llvm/utils/lit/tests/xunit-output.py @@ -8,8 +8,8 @@ # RUN: FileCheck < %t.xunit.xml %s # CHECK: -# CHECK-NEXT: -# CHECK-NEXT: +# CHECK-NEXT: +# CHECK-NEXT: # CHECK-NEXT: # CHECK-NEXT: ]]]]> &"]]> # CHECK-NEXT: