Skip to content

[BOLT][DWARF] Remove option to write to DWP #100771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 30, 2024
Merged

[BOLT][DWARF] Remove option to write to DWP #100771

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
59ae7da
[BOLT][DWARF][NFC] Remove option to write to DWP
sayhaan Jul 26, 2024
e0b3671
Updates
sayhaan Jul 26, 2024
fe304c6
Updates
sayhaan Jul 29, 2024
6b904fd
Remove unused data structures
sayhaan Jul 29, 2024
9e0aacb
Updates
sayhaan Jul 29, 2024
1ffd76c
Updates
sayhaan Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 0 additions & 37 deletions bolt/include/bolt/Rewrite/DWARFRewriter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
#include "bolt/Core/GDBIndex.h"
#include "llvm/ADT/StringRef.h"
#include "llvm/CodeGen/DIE.h"
#include "llvm/DWP/DWP.h"
#include "llvm/MC/MCContext.h"
#include "llvm/Support/ToolOutputFile.h"
#include <cstdint>
Expand All @@ -41,13 +40,6 @@ class DWARFRewriter {
uint64_t TypeHash;
uint64_t TypeDIERelativeOffset;
};
/// Contains information for CU or TU so we can output correct {cu, tu}-index.
struct UnitMeta {
uint64_t Offset;
uint64_t Length;
uint64_t TUHash;
};
using UnitMetaVectorType = std::vector<UnitMeta>;

private:
BinaryContext &BC;
Expand Down Expand Up @@ -194,35 +186,6 @@ class DWARFRewriter {
const std::string &, DebugLocWriter &,
DebugStrOffsetsWriter &, DebugStrWriter &);
using KnownSectionsEntry = std::pair<MCSection *, DWARFSectionKind>;
struct DWPState {
std::unique_ptr<ToolOutputFile> Out;
std::unique_ptr<BinaryContext> TmpBC;
std::unique_ptr<MCStreamer> Streamer;
std::unique_ptr<DWPStringPool> Strings;
/// Used to store String sections for .dwo files if they are being modified.
std::vector<std::unique_ptr<DebugBufferVector>> StrSections;
const MCObjectFileInfo *MCOFI = nullptr;
const DWARFUnitIndex *CUIndex = nullptr;
std::deque<SmallString<32>> UncompressedSections;
MapVector<uint64_t, UnitIndexEntry> IndexEntries;
MapVector<uint64_t, UnitIndexEntry> TypeIndexEntries;
StringMap<KnownSectionsEntry> KnownSections;
uint32_t ContributionOffsets[8] = {};
uint32_t IndexVersion = 2;
uint64_t DebugInfoSize = 0;
uint16_t Version = 0;
bool IsDWP = false;
};
/// Init .dwp file
void initDWPState(DWPState &);

/// Write out .dwp File
void finalizeDWP(DWPState &);

/// add content of dwo to .dwp file.
void updateDWP(DWARFUnit &, const OverriddenSectionsMap &, const UnitMeta &,
UnitMetaVectorType &, DWPState &, DebugLocWriter &,
DebugStrOffsetsWriter &, DebugStrWriter &);
};

} // namespace bolt
Expand Down
1 change: 0 additions & 1 deletion bolt/lib/Rewrite/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
set(LLVM_LINK_COMPONENTS
Core
DebugInfoDWARF
DWP
JITLink
MC
Object
Expand Down
Loading