[arm] Merge 8807139026b6 into 10.0.1

[DimitryAndric]

Bugzilla Link	45705
Resolution	FIXED
Resolved on	May 19, 2020 12:27
Version	10.0
OS	All
Blocks	#44654
CC	@TNorthover,@tstellar
Fixed by commit(s)	8807139 f3164f7

Extended Description

Please merge https://reviews.llvm.org/rG8807139026b64ac40163bb255dad38a1d8054f08 into 10.0.1. This fixes bug 45677, a fatal backend error when targeting armv5:

Author: David Green
Date: 2020-04-27T10:13:29+01:00
New Revision: 8807139

URL: 8807139
DIFF: https://github.com/llvm/llvm-project/commit/8807139026b64ac40163bb255dad38a1d8054f08.diff

LOG: [ARM] Only produce qadd8b under hasV6Ops

When compiling for a arm5te cpu from clang, the +dsp attribute is set.
This meant we could try and generate qadd8 instructions where we would
end up having no pattern. I've changed the condition here to be hasV6Ops
&& hasDSP, which is what other parts of ARMISelLowering seem to use for
similar instructions.

Fixed #45022 .

Differential Revision: https://reviews.llvm.org/D78877

[DimitryAndric]

assigned to @tstellar

[tstellar]

Tim,

Is this Ok to merge?

https://reviews.llvm.org/rG8807139026b64ac40163bb255dad38a1d8054f08

[TNorthover]

Sorry, for some reason I don't seem to get e-mail notifications for bugs assigned to me so I didn't notice this.

It looks correct to me.

[DimitryAndric]

Tim, there might be something weird with the bugzilla accounts matching your name. E.g. if I type "northover" in the "add users" field, I get these three matches:

t.p.northover@gmail.com (piotr-kosek@tlen.pl)
Tim Northover (t.p.northover@gmail.com)
Tim Northover (tim.northover@arm.com)

For some reason, there is a person at tlen.pl which has your email address as their 'real name'?

[tstellar]

Merged: f3164f7

[TNorthover]

Alas I can't claim that as an excuse, the history clearly shows this bug was assigned to my gmail address so I need to sort out my notifications.

I should probably also disable the ARM one somehow; I don't even need to remember the password from 8 years ago because I'm an admin, muahahahaha!

But that other random address is really weird. They seem to have made just one comment, on #31690 . Might be worth raising on bugs-admin to ping the user and/or change the name.

Thanks for spotting it!