[regression] clang-format / broken c++ for(...) syntax.

[pawelsopensource]

Bugzilla Link	45218
Resolution	FIXED
Resolved on	Sep 08, 2020 10:05
Version	10.0
OS	Linux
Blocks	#43900 #46070
Attachments	fornat description., fornat description.
CC	@zmodem,@mydeveloperday,@owenca,@rjmansfield
Fixed by commit(s)	c81dd3d

Extended Description

hi,
the clang-format-10-rcX introduces a c++ syntax error in shift-right expression:

     unsigned long long v = static_cast< unsigned long long >( t );

•    for ( unsigned i = 0; i< nbits; ++i, bIt.next(), v = v >> 1 )
  

•    for ( unsigned i = 0; i< nbits; ++i, bIt.next(), v = v > > 1 )
  

[zmodem]

Simple repro:

$ echo 'for (unsigned i = 0; i < n; ++i, v = v >> 1)' | bin/clang-format
for (unsigned i = 0; i<n; ++i, v = v> > 1)

Bisection points to the commit below. Owen, can you take a look?

---

commit ac67414
Author: Owen Pan owenpiano@gmail.com
Date: Fri Aug 16 21:49:17 2019 +0000

[clang-format] Fix the bug that joins template closer and > or >>

Also fixes a buggy test case.

See llvm/llvm-project#41749 

Differential Revision: https://reviews.llvm.org/D66332

llvm-svn: 369157

---

[owenca]

The culprit is AnnotatingParser::parseAngle() in clang/lib/Format/TokenAnnotator.cpp. My fix merely uncovered it. :)

Upon reading a '<' token, parseAngle() tries to scan the rest of the line to find a matching '>'. If found, it's given the type TT_TemplateCloser. This should be fixed.

[owenca]

*** Bug llvm/llvm-bugzilla-archive#45648 has been marked as a duplicate of this bug. ***

[mydeveloperday]

See https://reviews.llvm.org/D79293 for a potential fix

[zmodem]

Would be nice to get this fixed for 11.0.0.

[zmodem]

See https://reviews.llvm.org/D79293 for a potential fix

Looks like there's another one in review here: https://reviews.llvm.org/D86581

I'm not sure we can block the release on this, but if that lands soon maybe we can take it.

[zmodem]

See https://reviews.llvm.org/D79293 for a potential fix

Looks like there's another one in review here:
https://reviews.llvm.org/D86581

I'm not sure we can block the release on this, but if that lands soon maybe
we can take it.

MyDeveloperDay: are you committing that? Sounds like it's ready to go.

[mydeveloperday]

Sorry for the delay in landing...

its just been committed as

c81dd3d

[zmodem]

Sorry for the delay in landing...

its just been committed as

c81dd3d

Pushed to 11.x as 42ee33c. Please let me know if there are any follow-ups.

[owenca]

mentioned in issue llvm/llvm-bugzilla-archive#45648

[owenca]

mentioned in issue llvm/llvm-bugzilla-archive#45648

[zmodem]

mentioned in issue #46070