-Wmicrosoft-template changed in 10.0.0

[JVApen]

Bugzilla Link	44794
Resolution	FIXED
Resolved on	Feb 26, 2020 07:11
Version	10.0
OS	Windows NT
Blocks	#43900
CC	@zmodem,@zygoloid,@rnk

Extended Description

On our code base, we had the -Wmicrosoft-template warning active before. With 10.0.0-RC1, I have to suppress this warning again, because it got changed.

Ideally, every warning would have it's own flag, something like: -Wmicrosoft-template-shadowing and be part put in a warning group -Wmicrosoft-template.
This eases upgrades to newer releases, as you don't have to disable warnings that were previously active.

Not sure if this is feasible within the RC time, however, updating the release note comments to mention changes to this warning should still be feasible.

See https://clang.llvm.org/docs/DiagnosticsReference.html#wmicrosoft-template :
declaration of A shadows template parameter

[zmodem]

I guess this http://llvm.org/viewvc/llvm-project?rev=371753&view=rev

Reid, do you think it would make sense to give the warning a separate -W flag, and would you like to mention it in the release notes?

[rnk]

How about -Wmicrosoft-template-shadow?

[zmodem]

How about -Wmicrosoft-template-shadow?

sgtm, do you want to do a patch?

[zmodem]

Sent https://reviews.llvm.org/D75121

[zmodem]

Committed in 41a6612

And pushed to 10.x in f87cc45