Skip to content

Commit e5bdbf6

Browse files
committed
[AMDGPU] Still set up the two SGPRs for queue ptr even it is COV5
1 parent fb858b4 commit e5bdbf6

File tree

518 files changed

+109235
-124510
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

518 files changed

+109235
-124510
lines changed

llvm/lib/Target/AMDGPU/AMDGPUCallLowering.cpp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -472,9 +472,7 @@ static void allocateHSAUserSGPRs(CCState &CCInfo,
472472
CCInfo.AllocateReg(DispatchPtrReg);
473473
}
474474

475-
const Module *M = MF.getFunction().getParent();
476-
if (UserSGPRInfo.hasQueuePtr() &&
477-
AMDGPU::getAMDHSACodeObjectVersion(*M) < AMDGPU::AMDHSA_COV5) {
475+
if (UserSGPRInfo.hasQueuePtr()) {
478476
Register QueuePtrReg = Info.addQueuePtr(TRI);
479477
MF.addLiveIn(QueuePtrReg, &AMDGPU::SGPR_64RegClass);
480478
CCInfo.AllocateReg(QueuePtrReg);

llvm/lib/Target/AMDGPU/SIISelLowering.cpp

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2393,9 +2393,7 @@ void SITargetLowering::allocateSpecialInputSGPRs(
23932393
if (UserSGPRInfo.hasDispatchPtr())
23942394
allocateSGPR64Input(CCInfo, ArgInfo.DispatchPtr);
23952395

2396-
const Module *M = MF.getFunction().getParent();
2397-
if (UserSGPRInfo.hasQueuePtr() &&
2398-
AMDGPU::getAMDHSACodeObjectVersion(*M) < AMDGPU::AMDHSA_COV5)
2396+
if (UserSGPRInfo.hasQueuePtr())
23992397
allocateSGPR64Input(CCInfo, ArgInfo.QueuePtr);
24002398

24012399
// Implicit arg ptr takes the place of the kernarg segment pointer. This is a
@@ -2446,9 +2444,7 @@ void SITargetLowering::allocateHSAUserSGPRs(CCState &CCInfo,
24462444
CCInfo.AllocateReg(DispatchPtrReg);
24472445
}
24482446

2449-
const Module *M = MF.getFunction().getParent();
2450-
if (UserSGPRInfo.hasQueuePtr() &&
2451-
AMDGPU::getAMDHSACodeObjectVersion(*M) < AMDGPU::AMDHSA_COV5) {
2447+
if (UserSGPRInfo.hasQueuePtr()) {
24522448
Register QueuePtrReg = Info.addQueuePtr(TRI);
24532449
MF.addLiveIn(QueuePtrReg, &AMDGPU::SGPR_64RegClass);
24542450
CCInfo.AllocateReg(QueuePtrReg);

llvm/test/CodeGen/AMDGPU/GlobalISel/addsubu64.ll

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -6,30 +6,30 @@ define amdgpu_kernel void @s_add_u64(ptr addrspace(1) %out, i64 %a, i64 %b) {
66
; GFX11-LABEL: s_add_u64:
77
; GFX11: ; %bb.0: ; %entry
88
; GFX11-NEXT: s_clause 0x1
9-
; GFX11-NEXT: s_load_b128 s[4:7], s[2:3], 0x24
10-
; GFX11-NEXT: s_load_b64 s[0:1], s[2:3], 0x34
9+
; GFX11-NEXT: s_load_b128 s[0:3], s[4:5], 0x24
10+
; GFX11-NEXT: s_load_b64 s[4:5], s[4:5], 0x34
1111
; GFX11-NEXT: v_mov_b32_e32 v2, 0
1212
; GFX11-NEXT: s_waitcnt lgkmcnt(0)
13-
; GFX11-NEXT: s_add_u32 s0, s6, s0
14-
; GFX11-NEXT: s_addc_u32 s1, s7, s1
13+
; GFX11-NEXT: s_add_u32 s2, s2, s4
14+
; GFX11-NEXT: s_addc_u32 s3, s3, s5
1515
; GFX11-NEXT: s_delay_alu instid0(SALU_CYCLE_1)
16-
; GFX11-NEXT: v_dual_mov_b32 v0, s0 :: v_dual_mov_b32 v1, s1
17-
; GFX11-NEXT: global_store_b64 v2, v[0:1], s[4:5]
16+
; GFX11-NEXT: v_dual_mov_b32 v0, s2 :: v_dual_mov_b32 v1, s3
17+
; GFX11-NEXT: global_store_b64 v2, v[0:1], s[0:1]
1818
; GFX11-NEXT: s_nop 0
1919
; GFX11-NEXT: s_sendmsg sendmsg(MSG_DEALLOC_VGPRS)
2020
; GFX11-NEXT: s_endpgm
2121
;
2222
; GFX12-LABEL: s_add_u64:
2323
; GFX12: ; %bb.0: ; %entry
2424
; GFX12-NEXT: s_clause 0x1
25-
; GFX12-NEXT: s_load_b128 s[4:7], s[2:3], 0x24
26-
; GFX12-NEXT: s_load_b64 s[0:1], s[2:3], 0x34
25+
; GFX12-NEXT: s_load_b128 s[0:3], s[4:5], 0x24
26+
; GFX12-NEXT: s_load_b64 s[4:5], s[4:5], 0x34
2727
; GFX12-NEXT: v_mov_b32_e32 v2, 0
2828
; GFX12-NEXT: s_wait_kmcnt 0x0
29-
; GFX12-NEXT: s_add_nc_u64 s[0:1], s[6:7], s[0:1]
29+
; GFX12-NEXT: s_add_nc_u64 s[2:3], s[2:3], s[4:5]
3030
; GFX12-NEXT: s_delay_alu instid0(SALU_CYCLE_1)
31-
; GFX12-NEXT: v_dual_mov_b32 v0, s0 :: v_dual_mov_b32 v1, s1
32-
; GFX12-NEXT: global_store_b64 v2, v[0:1], s[4:5]
31+
; GFX12-NEXT: v_dual_mov_b32 v0, s2 :: v_dual_mov_b32 v1, s3
32+
; GFX12-NEXT: global_store_b64 v2, v[0:1], s[0:1]
3333
; GFX12-NEXT: s_nop 0
3434
; GFX12-NEXT: s_sendmsg sendmsg(MSG_DEALLOC_VGPRS)
3535
; GFX12-NEXT: s_endpgm
@@ -58,30 +58,30 @@ define amdgpu_kernel void @s_sub_u64(ptr addrspace(1) %out, i64 %a, i64 %b) {
5858
; GFX11-LABEL: s_sub_u64:
5959
; GFX11: ; %bb.0: ; %entry
6060
; GFX11-NEXT: s_clause 0x1
61-
; GFX11-NEXT: s_load_b128 s[4:7], s[2:3], 0x24
62-
; GFX11-NEXT: s_load_b64 s[0:1], s[2:3], 0x34
61+
; GFX11-NEXT: s_load_b128 s[0:3], s[4:5], 0x24
62+
; GFX11-NEXT: s_load_b64 s[4:5], s[4:5], 0x34
6363
; GFX11-NEXT: v_mov_b32_e32 v2, 0
6464
; GFX11-NEXT: s_waitcnt lgkmcnt(0)
65-
; GFX11-NEXT: s_sub_u32 s0, s6, s0
66-
; GFX11-NEXT: s_subb_u32 s1, s7, s1
65+
; GFX11-NEXT: s_sub_u32 s2, s2, s4
66+
; GFX11-NEXT: s_subb_u32 s3, s3, s5
6767
; GFX11-NEXT: s_delay_alu instid0(SALU_CYCLE_1)
68-
; GFX11-NEXT: v_dual_mov_b32 v0, s0 :: v_dual_mov_b32 v1, s1
69-
; GFX11-NEXT: global_store_b64 v2, v[0:1], s[4:5]
68+
; GFX11-NEXT: v_dual_mov_b32 v0, s2 :: v_dual_mov_b32 v1, s3
69+
; GFX11-NEXT: global_store_b64 v2, v[0:1], s[0:1]
7070
; GFX11-NEXT: s_nop 0
7171
; GFX11-NEXT: s_sendmsg sendmsg(MSG_DEALLOC_VGPRS)
7272
; GFX11-NEXT: s_endpgm
7373
;
7474
; GFX12-LABEL: s_sub_u64:
7575
; GFX12: ; %bb.0: ; %entry
7676
; GFX12-NEXT: s_clause 0x1
77-
; GFX12-NEXT: s_load_b128 s[4:7], s[2:3], 0x24
78-
; GFX12-NEXT: s_load_b64 s[0:1], s[2:3], 0x34
77+
; GFX12-NEXT: s_load_b128 s[0:3], s[4:5], 0x24
78+
; GFX12-NEXT: s_load_b64 s[4:5], s[4:5], 0x34
7979
; GFX12-NEXT: v_mov_b32_e32 v2, 0
8080
; GFX12-NEXT: s_wait_kmcnt 0x0
81-
; GFX12-NEXT: s_sub_nc_u64 s[0:1], s[6:7], s[0:1]
81+
; GFX12-NEXT: s_sub_nc_u64 s[2:3], s[2:3], s[4:5]
8282
; GFX12-NEXT: s_delay_alu instid0(SALU_CYCLE_1)
83-
; GFX12-NEXT: v_dual_mov_b32 v0, s0 :: v_dual_mov_b32 v1, s1
84-
; GFX12-NEXT: global_store_b64 v2, v[0:1], s[4:5]
83+
; GFX12-NEXT: v_dual_mov_b32 v0, s2 :: v_dual_mov_b32 v1, s3
84+
; GFX12-NEXT: global_store_b64 v2, v[0:1], s[0:1]
8585
; GFX12-NEXT: s_nop 0
8686
; GFX12-NEXT: s_sendmsg sendmsg(MSG_DEALLOC_VGPRS)
8787
; GFX12-NEXT: s_endpgm

0 commit comments

Comments
 (0)