[ELF][test] Fix section sh_type and sh_flags

MaskRay · MaskRay · commit d6d640ebae65 · 2020-02-19T22:01:42.000-08:00
A future MC change may add a warning/error when a .section directive
specifies incorrect sh_flags/sh_type.
diff --git a/lld/test/ELF/Inputs/eh-frame-end.s b/lld/test/ELF/Inputs/eh-frame-end.s
diff --git a/lld/test/ELF/Inputs/eh-frame-pcrel-overflow.s b/lld/test/ELF/Inputs/eh-frame-pcrel-overflow.s
@@ -3,7 +3,7 @@
 foo:
   ret
 
-.section .eh_frame, "a"
+.section .eh_frame,"a",@unwind
   .long 12   # Size
   .long 0x00 # ID
   .byte 0x01 # Version.
diff --git a/lld/test/ELF/Inputs/mips-nonalloc.s b/lld/test/ELF/Inputs/mips-nonalloc.s
diff --git a/lld/test/ELF/Inputs/ppc64-sort-small-cm-relocs-input4.s b/lld/test/ELF/Inputs/ppc64-sort-small-cm-relocs-input4.s
@@ -10,7 +10,7 @@ getRodata:
     lwa 3, .LC0@toc(2)
     blr
 
-    .section        .rodata,"aMS",@progbits,8
+    .section        .rodata,"a",@progbits
     .quad _start
 
     .section        .toc,"aw",@progbits
diff --git a/lld/test/ELF/comdat-discarded-reloc.s b/lld/test/ELF/comdat-discarded-reloc.s
@@ -32,7 +32,7 @@ bar:
   .quad .text.bar1
 
 ## Don't warn on .eh_frame, .debug*, .zdebug*, or .gcc_except_table
-.section .eh_frame,"a"
+.section .eh_frame,"a",@unwind
   .quad .text.bar1
 
 .section .debug_foo
diff --git a/lld/test/ELF/compress-debug-sections-reloc.s b/lld/test/ELF/compress-debug-sections-reloc.s
@@ -17,7 +17,7 @@
 a_sym:
 nop
 
-.section .debug_str,"",@progbits
+.section .debug_str,"MS",@progbits,1
 .long a_sym
 .long a_debug_sym
 
diff --git a/lld/test/ELF/eh-frame-begin-end.s b/lld/test/ELF/eh-frame-begin-end.s
@@ -1,6 +1,7 @@
 // REQUIRES: x86
 // RUN: llvm-mc -filetype=obj -triple=amd64-unknown-openbsd %s -o %t.o
-// RUN: llvm-mc -filetype=obj -triple=amd64-unknown-openbsd %p/Inputs/eh-frame-end.s -o %t2.o
+// RUN: echo '.section .eh_frame,"a",@unwind; .long 0' | \
+// RUN:   llvm-mc -filetype=obj -triple=amd64-unknown-openbsd - -o %t2.o
 // RUN: ld.lld %t.o %t2.o -o %t
 // RUN: llvm-readobj --sections %t | FileCheck %s
 
@@ -13,5 +14,5 @@
 // CHECK-NEXT: Offset: 0x120
 // CHECK-NEXT: Size: 4
 
-	.section ".eh_frame", "a", @progbits
+.section .eh_frame,"a",@unwind
 __EH_FRAME_BEGIN__:
diff --git a/lld/test/ELF/eh-frame-marker.s b/lld/test/ELF/eh-frame-marker.s
@@ -15,6 +15,6 @@
 // CHECK:      Name: foo
 // CHECK-NEXT: Value: [[ADDR]]
 
-        .section .eh_frame
+        .section .eh_frame,"a",@unwind
 foo:
         .long 0
diff --git a/lld/test/ELF/eh-frame-negative-pcrel-sdata2.s b/lld/test/ELF/eh-frame-negative-pcrel-sdata2.s
@@ -57,7 +57,7 @@
 _start:
  nop
 
-.section .eh_frame, "a"
+.section .eh_frame,"a",@unwind
   .long 16   # Size
   .long 0x00 # ID
   .byte 0x01 # Version.
diff --git a/lld/test/ELF/eh-frame-negative-pcrel-sdata4.s b/lld/test/ELF/eh-frame-negative-pcrel-sdata4.s
@@ -57,7 +57,7 @@
 _start:
  nop
 
-.section .eh_frame, "a"
+.section .eh_frame,"a",@unwind
   .long 16   # Size
   .long 0x00 # ID
   .byte 0x01 # Version.
diff --git a/lld/test/ELF/eh-frame-negative-pcrel-sdata8.s b/lld/test/ELF/eh-frame-negative-pcrel-sdata8.s
@@ -57,7 +57,7 @@
 _start:
  nop
 
-.section .eh_frame, "a"
+.section .eh_frame,"a",@unwind
   .long 16   # Size
   .long 0x00 # ID
   .byte 0x01 # Version.
diff --git a/lld/test/ELF/eh-frame-pcrel-overflow.s b/lld/test/ELF/eh-frame-pcrel-overflow.s
@@ -11,7 +11,7 @@
 _start:
   ret
 
-.section .eh_frame, "a"
+.section .eh_frame,"a",@unwind
   .long 12   # Size
   .long 0x00 # ID
   .byte 0x01 # Version.
diff --git a/lld/test/ELF/eh-frame-value-format1.s b/lld/test/ELF/eh-frame-value-format1.s
@@ -3,7 +3,7 @@
 # RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %s -o %t
 # RUN: ld.lld --eh-frame-hdr %t -o /dev/null
 
-.section .eh_frame
+.section .eh_frame,"a",@unwind
   .byte 0x14
   .byte 0x00
   .byte 0x00
diff --git a/lld/test/ELF/eh-frame-value-format2.s b/lld/test/ELF/eh-frame-value-format2.s
@@ -3,7 +3,7 @@
 # RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %s -o %t
 # RUN: ld.lld --eh-frame-hdr %t -o /dev/null
 
-.section .eh_frame
+.section .eh_frame,"a",@unwind
   .byte 0x14
   .byte 0x00
   .byte 0x00
diff --git a/lld/test/ELF/eh-frame-value-format3.s b/lld/test/ELF/eh-frame-value-format3.s
@@ -3,7 +3,7 @@
 # RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %s -o %t
 # RUN: ld.lld --eh-frame-hdr %t -o /dev/null
 
-.section .eh_frame
+.section .eh_frame,"a",@unwind
   .byte 0x0E
   .byte 0x00
   .byte 0x00
diff --git a/lld/test/ELF/eh-frame-value-format4.s b/lld/test/ELF/eh-frame-value-format4.s
@@ -3,7 +3,7 @@
 # RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %s -o %t
 # RUN: ld.lld --eh-frame-hdr %t -o /dev/null
 
-.section .eh_frame
+.section .eh_frame,"a",@unwind
   .byte 0x0E
   .byte 0x00
   .byte 0x00
diff --git a/lld/test/ELF/eh-frame-value-format5.s b/lld/test/ELF/eh-frame-value-format5.s
@@ -3,7 +3,7 @@
 # RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %s -o %t
 # RUN: ld.lld --eh-frame-hdr %t -o /dev/null
 
-.section .eh_frame
+.section .eh_frame,"a",@unwind
   .byte 0x14
   .byte 0x00
   .byte 0x00
diff --git a/lld/test/ELF/eh-frame-value-format6.s b/lld/test/ELF/eh-frame-value-format6.s
@@ -3,7 +3,7 @@
 # RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %s -o %t
 # RUN: ld.lld --eh-frame-hdr %t -o /dev/null
 
-.section .eh_frame
+.section .eh_frame,"a",@unwind
   .byte 0x14
   .byte 0x00
   .byte 0x00
diff --git a/lld/test/ELF/eh-frame-value-format7.s b/lld/test/ELF/eh-frame-value-format7.s
@@ -53,7 +53,7 @@
 foo:
  nop
 
-.section .eh_frame
+.section .eh_frame,"a",@unwind
   .long 12   # Size
   .long 0x00 # ID
   .byte 0x01 # Version.
diff --git a/lld/test/ELF/eh-frame-value-format8.s b/lld/test/ELF/eh-frame-value-format8.s
@@ -52,7 +52,7 @@
 foo:
  nop
 
-.section .eh_frame, "ax"
+.section .eh_frame,"a",@unwind
   .long 12   # Size
   .long 0x00 # ID
   .byte 0x01 # Version.
diff --git a/lld/test/ELF/eh-frame-value-format9.s b/lld/test/ELF/eh-frame-value-format9.s
@@ -4,7 +4,7 @@
 # RUN: not ld.lld --eh-frame-hdr %t.o -o /dev/null 2>&1 | FileCheck %s
 # CHECK: error: unknown FDE size encoding
 
-.section .eh_frame, "ax"
+.section .eh_frame,"a",@unwind
   .long 12   # Size
   .long 0x00 # ID
   .byte 0x01 # Version.
diff --git a/lld/test/ELF/ehframe-relocation.s b/lld/test/ELF/ehframe-relocation.s
@@ -23,7 +23,7 @@
 // DISASM-NEXT:   201154: {{.*}} movq 2097440, %rax
 // DISASM-NEXT:   20115c: {{.*}} movq 2097445, %rax
 
-.section .eh_frame,"ax",@unwind
+.section .eh_frame,"a",@unwind
 
 .section .text
 .globl _start
diff --git a/lld/test/ELF/icf16.s b/lld/test/ELF/icf16.s
@@ -9,7 +9,7 @@
 
 # CHECK-NOT: selected
 
-.section ".eh_frame", "a", @progbits
+.section ".eh_frame", "a", @unwind
 .globl foo
 foo:
   .quad 0
diff --git a/lld/test/ELF/invalid-cie-length.s b/lld/test/ELF/invalid-cie-length.s
@@ -3,7 +3,7 @@
 // RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %s -o %t
 // RUN: not ld.lld %t -o /dev/null 2>&1 | FileCheck %s
 
-.section .eh_frame
+.section .eh_frame,"a",@unwind
 .byte 0
 
 // CHECK:      error: corrupted .eh_frame: CIE/FDE too small
diff --git a/lld/test/ELF/invalid-cie-length2.s b/lld/test/ELF/invalid-cie-length2.s
@@ -3,7 +3,7 @@
 // RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %s -o %t
 // RUN: not ld.lld %t -o /dev/null 2>&1 | FileCheck %s
 
-.section .eh_frame
+.section .eh_frame,"a",@unwind
 .long 42
 
 // CHECK:      error: corrupted .eh_frame: CIE/FDE ends past the end of the section
diff --git a/lld/test/ELF/invalid-cie-length3.s b/lld/test/ELF/invalid-cie-length3.s
@@ -3,7 +3,7 @@
 // RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %s -o %t
 // RUN: not ld.lld %t -o /dev/null 2>&1 | FileCheck %s
 
-.section .eh_frame
+.section .eh_frame,"a",@unwind
 .long 0xFFFFFFFC
 
 // CHECK:      error: corrupted .eh_frame: CIE/FDE ends past the end of the section
diff --git a/lld/test/ELF/invalid-cie-length4.s b/lld/test/ELF/invalid-cie-length4.s
@@ -3,7 +3,7 @@
 // RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %s -o %t
 // RUN: not ld.lld %t -o /dev/null 2>&1 | FileCheck %s
 
-.section .eh_frame
+.section .eh_frame,"a",@unwind
 .long 0xFFFFFFFF
 .byte 0
 
diff --git a/lld/test/ELF/invalid-cie-length5.s b/lld/test/ELF/invalid-cie-length5.s
@@ -3,7 +3,7 @@
 // RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %s -o %t
 // RUN: not ld.lld %t -o /dev/null 2>&1 | FileCheck %s
 
- .section .eh_frame
+ .section .eh_frame,"a",@unwind
  .long 0xFFFFFFFF
  .quad 0xFFFFFFFFFFFFFFF4
 
diff --git a/lld/test/ELF/invalid-cie-reference.s b/lld/test/ELF/invalid-cie-reference.s
@@ -3,7 +3,7 @@
 // RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %s -o %t
 // RUN: not ld.lld %t -o /dev/null 2>&1 | FileCheck %s
 
-        .section .eh_frame
+        .section .eh_frame,"a",@unwind
         .long 0x14
         .long 0x0
         .byte 0x01
diff --git a/lld/test/ELF/invalid-eh-frame.s b/lld/test/ELF/invalid-eh-frame.s
@@ -6,7 +6,7 @@
 # CHECK:      error: corrupted .eh_frame: unexpected end of CIE
 # CHECK-NEXT: >>> defined in {{.*}}:(.eh_frame+0x8)
 
-.section .eh_frame
+.section .eh_frame,"a",@unwind
   .byte 0x04
   .byte 0x00
   .byte 0x00
diff --git a/lld/test/ELF/invalid-eh-frame2.s b/lld/test/ELF/invalid-eh-frame2.s
@@ -6,7 +6,7 @@
 # CHECK:      error: corrupted .eh_frame: corrupted CIE (failed to read string)
 # CHECK-NEXT: >>> defined in {{.*}}:(.eh_frame+0x9)
 
-.section .eh_frame
+.section .eh_frame,"a",@unwind
 .align 1
   .byte 0x08
   .byte 0x00
diff --git a/lld/test/ELF/invalid-eh-frame3.s b/lld/test/ELF/invalid-eh-frame3.s
@@ -6,7 +6,7 @@
 # CHECK:      error: corrupted .eh_frame: corrupted CIE (failed to read LEB128)
 # CHECK-NEXT: >>> defined in {{.*}}:(.eh_frame+0xC)
 
-.section .eh_frame
+.section .eh_frame,"a",@unwind
   .byte 0x08
   .byte 0x00
   .byte 0x00
diff --git a/lld/test/ELF/invalid-eh-frame4.s b/lld/test/ELF/invalid-eh-frame4.s
@@ -5,7 +5,7 @@
 
 # CHECK: corrupted .eh_frame: unknown .eh_frame augmentation string:
 
-.section .eh_frame
+.section .eh_frame,"a",@unwind
   .byte 0x0E
   .byte 0x00
   .byte 0x00
diff --git a/lld/test/ELF/invalid-eh-frame5.s b/lld/test/ELF/invalid-eh-frame5.s
@@ -5,7 +5,7 @@
 
 # CHECK: corrupted .eh_frame: unknown .eh_frame augmentation string:
 
-.section .eh_frame
+.section .eh_frame,"a",@unwind
   .byte 0x0E
   .byte 0x00
   .byte 0x00
diff --git a/lld/test/ELF/invalid-eh-frame6.s b/lld/test/ELF/invalid-eh-frame6.s
@@ -6,7 +6,7 @@
 # CHECK: error: corrupted .eh_frame: unknown FDE encoding
 # CHECK-NEXT: >>> defined in {{.*}}:(.eh_frame+0xE)
 
-.section .eh_frame
+.section .eh_frame,"a",@unwind
   .byte 0x0E
   .byte 0x00
   .byte 0x00
diff --git a/lld/test/ELF/invalid-eh-frame7.s b/lld/test/ELF/invalid-eh-frame7.s
@@ -5,7 +5,7 @@
 
 # CHECK: error: corrupted .eh_frame: DW_EH_PE_aligned encoding is not supported
 
-.section .eh_frame
+.section .eh_frame,"a",@unwind
   .byte 0x0E
   .byte 0x00
   .byte 0x00
diff --git a/lld/test/ELF/invalid-eh-frame8.s b/lld/test/ELF/invalid-eh-frame8.s
@@ -5,7 +5,7 @@
 
 # CHECK: error: corrupted .eh_frame: corrupted CIE
 
-.section .eh_frame
+.section .eh_frame,"a",@unwind
   .byte 0x0E
   .byte 0x00
   .byte 0x00
diff --git a/lld/test/ELF/invalid-eh-frame9.s b/lld/test/ELF/invalid-eh-frame9.s
@@ -5,7 +5,7 @@
 
 # CHECK: error: corrupted .eh_frame: CIE is too small
 
-.section .eh_frame
+.section .eh_frame,"a",@unwind
   .byte 0x03
   .byte 0x00
   .byte 0x00
diff --git a/lld/test/ELF/invalid-fde-rel.s b/lld/test/ELF/invalid-fde-rel.s
@@ -7,7 +7,7 @@
 // This resembles what gold -r produces when it discards the section
 // the fde points to.
 
-        .section .eh_frame
+        .section .eh_frame,"a",@unwind
         .long 0x14
         .long 0x0
         .byte 0x01
diff --git a/lld/test/ELF/invalid/eh-frame-hdr-no-out.s b/lld/test/ELF/invalid/eh-frame-hdr-no-out.s
@@ -4,7 +4,7 @@
 
 // CHECK: error: corrupted .eh_frame: FDE version 1 or 3 expected, but got 2
 
-.section .eh_frame
+.section .eh_frame,"a",@unwind
   .byte 0x08
   .byte 0x00
   .byte 0x00
diff --git a/lld/test/ELF/linkerscript/Inputs/compress-debug-sections.s b/lld/test/ELF/linkerscript/Inputs/compress-debug-sections.s
@@ -1,3 +1,3 @@
-.section .debug_str
+.section .debug_str,"MS",@progbits,1
   .asciz "CCC"
   .asciz "DDD"
diff --git a/lld/test/ELF/linkerscript/compress-debug-sections-custom.s b/lld/test/ELF/linkerscript/compress-debug-sections-custom.s
@@ -26,7 +26,7 @@
 a_sym:
 nop
 
-.section .debug_str,"",@progbits
+.section .debug_str,"MS",@progbits,1
 .long a_sym
 .long a_debug_sym
 
diff --git a/lld/test/ELF/linkerscript/compress-debug-sections.s b/lld/test/ELF/linkerscript/compress-debug-sections.s
@@ -31,6 +31,6 @@
 # ZLIBFLAGS-NEXT:    Flags [
 # ZLIBFLAGS-NEXT:      SHF_COMPRESSED
 
-.section .debug_str
+.section .debug_str,"MS",@progbits,1
   .asciz "AAA"
   .asciz "BBB"
diff --git a/lld/test/ELF/mips-micro-relocs.s b/lld/test/ELF/mips-micro-relocs.s
@@ -71,5 +71,5 @@ __start:
   .data
   .gpword __start                 # R_MIPS_GPREL32
 
-  .section .debug_info
+  .section .debug_info,"",@0x7000001e
   .word __start                   # R_MIPS_32
diff --git a/lld/test/ELF/mips-nonalloc.s b/lld/test/ELF/mips-nonalloc.s
diff --git a/lld/test/ELF/no-augmentation.s b/lld/test/ELF/no-augmentation.s
diff --git a/lld/test/ELF/ppc64-ld-got-dtprel.s b/lld/test/ELF/ppc64-ld-got-dtprel.s
