Skip to content

Commit c73d6fd

Browse files
committed
Add another FIXME
1 parent 337fae7 commit c73d6fd

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

bolt/lib/Target/AArch64/AArch64MCPlusBuilder.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -533,6 +533,10 @@ class AArch64MCPlusBuilder : public MCPlusBuilder {
533533
return false;
534534
};
535535

536+
// FIXME: Not all load instructions are handled by this->mayLoad(Inst).
537+
// On the other hand, MCInstrDesc::mayLoad() is permitted to return
538+
// true for non-load instructions (such as AArch64::HINT) which
539+
// would result in false negatives.
536540
if (mayLoad(Inst)) {
537541
// The first Use operand is the base address register.
538542
unsigned BaseRegIndex = Desc.getNumDefs();

0 commit comments

Comments
 (0)