Skip to content

Commit c5dafab

Browse files
Apply suggestions from code review
Co-authored-by: Michael Buch <[email protected]>
1 parent 153c158 commit c5dafab

File tree

1 file changed

+3
-8
lines changed

1 file changed

+3
-8
lines changed

lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1156,15 +1156,11 @@ lldb_private::PlatformDarwin::ResolveSDKPathFromDebugInfo(
11561156

11571157
ModuleSP exe_module_sp = target->GetExecutableModule();
11581158
if (!exe_module_sp)
1159-
return llvm::createStringError(
1160-
llvm::inconvertibleErrorCode(),
1161-
llvm::formatv("Failed to get module from target"));
1159+
return llvm::createStringError("Failed to get module from target");
11621160

11631161
SymbolFile *sym_file = exe_module_sp->GetSymbolFile();
11641162
if (!sym_file)
1165-
return llvm::createStringError(
1166-
llvm::inconvertibleErrorCode(),
1167-
llvm::formatv("Failed to get symbol file from module"));
1163+
return llvm::createStringError("Failed to get symbol file from module");
11681164

11691165
XcodeSDK merged_sdk;
11701166
for (unsigned i = 0; i < sym_file->GetNumCompileUnits(); ++i) {
@@ -1185,9 +1181,8 @@ lldb_private::PlatformDarwin::ResolveSDKPathFromDebugInfo(
11851181
return FileSpec(*path_or_err);
11861182

11871183
return llvm::createStringError(
1188-
llvm::inconvertibleErrorCode(),
11891184
llvm::formatv("Failed to resolve SDK path: {0}",
1190-
llvm::toString(path_or_err.takeError())));
1185+
llvm::toString(path_or_err.takeError()));
11911186
}
11921187

11931188
ConstString PlatformDarwin::GetFullNameForDylib(ConstString basename) {

0 commit comments

Comments
 (0)