Skip to content

Commit aa2fe4e

Browse files
authored
[PowerPC] Remove some unused SDNodes and FastISel workaround (NFC) (#153964)
These nodes have never been used since introduction in 2013/2015.
1 parent 0d8aa9d commit aa2fe4e

File tree

3 files changed

+8
-42
lines changed

3 files changed

+8
-42
lines changed

llvm/lib/Target/PowerPC/PPCISelLowering.cpp

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1787,11 +1787,8 @@ const char *PPCTargetLowering::getTargetNodeName(unsigned Opcode) const {
17871787
case PPCISD::ADDI_DTPREL_L: return "PPCISD::ADDI_DTPREL_L";
17881788
case PPCISD::PADDI_DTPREL:
17891789
return "PPCISD::PADDI_DTPREL";
1790-
case PPCISD::VADD_SPLAT: return "PPCISD::VADD_SPLAT";
1791-
case PPCISD::SC: return "PPCISD::SC";
1792-
case PPCISD::CLRBHRB: return "PPCISD::CLRBHRB";
1793-
case PPCISD::MFBHRBE: return "PPCISD::MFBHRBE";
1794-
case PPCISD::RFEBB: return "PPCISD::RFEBB";
1790+
case PPCISD::VADD_SPLAT:
1791+
return "PPCISD::VADD_SPLAT";
17951792
case PPCISD::XXSWAPD: return "PPCISD::XXSWAPD";
17961793
case PPCISD::SWAP_NO_CHAIN: return "PPCISD::SWAP_NO_CHAIN";
17971794
case PPCISD::BUILD_FP128: return "PPCISD::BUILD_FP128";

llvm/lib/Target/PowerPC/PPCISelLowering.h

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -430,20 +430,6 @@ namespace llvm {
430430
/// optimizations due to constant folding.
431431
VADD_SPLAT,
432432

433-
/// CHAIN = SC CHAIN, Imm128 - System call. The 7-bit unsigned
434-
/// operand identifies the operating system entry point.
435-
SC,
436-
437-
/// CHAIN = CLRBHRB CHAIN - Clear branch history rolling buffer.
438-
CLRBHRB,
439-
440-
/// GPRC, CHAIN = MFBHRBE CHAIN, Entry, Dummy - Move from branch
441-
/// history rolling buffer entry.
442-
MFBHRBE,
443-
444-
/// CHAIN = RFEBB CHAIN, State - Return from event-based branch.
445-
RFEBB,
446-
447433
/// VSRC, CHAIN = XXSWAPD CHAIN, VSRC - Occurs only for little
448434
/// endian. Maps to an xxswapd instruction that corrects an lxvd2x
449435
/// or stxvd2x instruction. The chain is necessary because the

llvm/lib/Target/PowerPC/PPCInstrInfo.td

Lines changed: 6 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -365,16 +365,6 @@ def PPCeh_sjlj_longjmp : SDNode<"PPCISD::EH_SJLJ_LONGJMP",
365365
SDTypeProfile<0, 1, [SDTCisPtrTy<0>]>,
366366
[SDNPHasChain, SDNPSideEffect]>;
367367

368-
def SDT_PPCsc : SDTypeProfile<0, 1, [SDTCisInt<0>]>;
369-
def PPCsc : SDNode<"PPCISD::SC", SDT_PPCsc,
370-
[SDNPHasChain, SDNPSideEffect]>;
371-
372-
def PPCclrbhrb : SDNode<"PPCISD::CLRBHRB", SDTNone,
373-
[SDNPHasChain, SDNPSideEffect]>;
374-
def PPCmfbhrbe : SDNode<"PPCISD::MFBHRBE", SDTIntBinOp, [SDNPHasChain]>;
375-
def PPCrfebb : SDNode<"PPCISD::RFEBB", SDT_PPCsc,
376-
[SDNPHasChain, SDNPSideEffect]>;
377-
378368
def PPCvcmp : SDNode<"PPCISD::VCMP" , SDT_PPCvcmp, []>;
379369
def PPCvcmp_rec : SDNode<"PPCISD::VCMP_rec", SDT_PPCvcmp, [SDNPOutGlue]>;
380370

@@ -1673,7 +1663,7 @@ let isBranch = 1, isTerminator = 1, Size = 0 in {
16731663
// System call.
16741664
let PPC970_Unit = 7 in {
16751665
def SC : SCForm<17, 1, 0, (outs), (ins i32imm:$LEV),
1676-
"sc $LEV", IIC_BrB, [(PPCsc (i32 imm:$LEV))]>;
1666+
"sc $LEV", IIC_BrB, []>;
16771667
}
16781668

16791669
// We mark SCV as having no scheduling model since it is only meant to be used
@@ -1685,21 +1675,14 @@ let Predicates = [IsISA3_0], hasNoSchedulingInfo = 1 in {
16851675
}
16861676

16871677
// Branch history rolling buffer.
1688-
def CLRBHRB : XForm_0<31, 430, (outs), (ins), "clrbhrb", IIC_BrB,
1689-
[(PPCclrbhrb)]>,
1678+
def CLRBHRB : XForm_0<31, 430, (outs), (ins), "clrbhrb", IIC_BrB, []>,
16901679
PPC970_DGroup_Single;
1691-
// The $dmy argument used for MFBHRBE is not needed; however, including
1692-
// it avoids automatic generation of PPCFastISel::fastEmit_i(), which
1693-
// interferes with necessary special handling (see PPCFastISel.cpp).
1694-
def MFBHRBE : XFXForm_3p<31, 302, (outs gprc:$RT),
1695-
(ins u10imm:$imm, u10imm:$dmy),
1696-
"mfbhrbe $RT, $imm", IIC_BrB,
1697-
[(set i32:$RT,
1698-
(PPCmfbhrbe imm:$imm, imm:$dmy))]>,
1680+
1681+
def MFBHRBE : XFXForm_3p<31, 302, (outs gprc:$RT), (ins u10imm:$imm),
1682+
"mfbhrbe $RT, $imm", IIC_BrB, []>,
16991683
PPC970_DGroup_First;
17001684

1701-
def RFEBB : XLForm_S<19, 146, (outs), (ins u1imm:$S), "rfebb $S",
1702-
IIC_BrB, [(PPCrfebb (i32 imm:$S))]>,
1685+
def RFEBB : XLForm_S<19, 146, (outs), (ins u1imm:$S), "rfebb $S", IIC_BrB, []>,
17031686
PPC970_DGroup_Single;
17041687

17051688
def : InstAlias<"rfebb", (RFEBB 1)>;

0 commit comments

Comments
 (0)