Addressed review comments

Author: H-G-Hristov

libcxx/include/__config

@@ -1216,18 +1216,14 @@ typedef __char32_t char32_t;
 #  endif
 
 // TODO(LLVM 22): Remove this macro once LLVM19 support ends.
-#  if __has_builtin(__reference_constructs_from_temporary) ||                                                          \
-      (defined(_LIBCPP_CLANG_VER) &&                                                                                   \
-       ((!defined(__ANDROID__) && _LIBCPP_CLANG_VER >= 1901) || (defined(__ANDROID__) && _LIBCPP_CLANG_VER >= 1900)))
+#  if __has_builtin(__reference_constructs_from_temporary)
 #    define _LIBCPP_HAS_REFERENCE_CONSTRUCTS_FROM_TEMPORARY 1
 #  else
 #    define _LIBCPP_HAS_REFERENCE_CONSTRUCTS_FROM_TEMPORARY 0
 #  endif
 
 // TODO(LLVM 22): Remove this macro once LLVM19 support ends.
-#  if __has_builtin(__reference_converts_from_temporary) ||                                                            \
-      (defined(_LIBCPP_CLANG_VER) &&                                                                                   \
-       ((!defined(__ANDROID__) && _LIBCPP_CLANG_VER >= 1901) || (defined(__ANDROID__) && _LIBCPP_CLANG_VER >= 2000)))
+#  if __has_builtin(__reference_converts_from_temporary)
 #    define _LIBCPP_HAS_REFERENCE_CONVERTS_FROM_TEMPORARY 1
 #  else
 #    define _LIBCPP_HAS_REFERENCE_CONVERTS_FROM_TEMPORARY 0

libcxx/include/__type_traits/reference_constructs_from_temporary.h

@@ -20,9 +20,6 @@ _LIBCPP_BEGIN_NAMESPACE_STD
 
 #if _LIBCPP_HAS_REFERENCE_CONSTRUCTS_FROM_TEMPORARY
 
-template <class _Tp, class _Up>
-const bool __reference_constructs_from_temporary_v = __reference_constructs_from_temporary(_Tp, _Up);
-
 #  if _LIBCPP_STD_VER >= 23
 
 template <class _Tp, class _Up>
@@ -31,7 +28,7 @@ struct _LIBCPP_TEMPLATE_VIS _LIBCPP_NO_SPECIALIZATIONS reference_constructs_from
 
 template <class _Tp, class _Up>
 _LIBCPP_NO_SPECIALIZATIONS inline constexpr bool reference_constructs_from_temporary_v =
-    __reference_constructs_from_temporary_v<_Tp, _Up>;
+    __reference_constructs_from_temporary(_Tp, _Up);
 
 #  endif
 

libcxx/include/__type_traits/reference_converts_from_temporary.h

@@ -20,9 +20,6 @@ _LIBCPP_BEGIN_NAMESPACE_STD
 
 #if _LIBCPP_HAS_REFERENCE_CONVERTS_FROM_TEMPORARY
 
-template <class _Tp, class _Up>
-const bool __reference_converts_from_temporary_v = __reference_converts_from_temporary(_Tp, _Up);
-
 #  if _LIBCPP_STD_VER >= 23
 
 template <class _Tp, class _Up>
@@ -31,7 +28,7 @@ struct _LIBCPP_TEMPLATE_VIS _LIBCPP_NO_SPECIALIZATIONS reference_converts_from_t
 
 template <class _Tp, class _Up>
 _LIBCPP_NO_SPECIALIZATIONS inline constexpr bool reference_converts_from_temporary_v =
-    __reference_converts_from_temporary_v<_Tp, _Up>;
+    __reference_converts_from_temporary(_Tp, _Up);
 
 #  endif
 

libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/reference_constructs_from_temporary.pass.cpp

@@ -9,7 +9,7 @@
 // REQUIRES: std-at-least-c++23
 
 // These compilers don't support std::reference_converts_from_temporary yet.
-// UNSUPPORTED: apple-clang-15, apple-clang-16
+// UNSUPPORTED: android, apple-clang-15, apple-clang-16, clang-19.1
 
 // <type_traits>
 

libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/reference_converts_from_temporary.pass.cpp

@@ -9,7 +9,7 @@
 // REQUIRES: std-at-least-c++23
 
 // These compilers don't support std::reference_converts_from_temporary yet.
-// UNSUPPORTED: android && clang-19.0, apple-clang-15, apple-clang-16, clang-18
+// UNSUPPORTED: android, apple-clang-15, apple-clang-16, clang-18, clang-19.1
 
 // <type_traits>