Use llvm_unreachable after a fully covered/always-returning switch

dwblaikie · dwblaikie · commit 819e540208d5 · 2020-03-26T20:09:57.000-07:00
diff --git a/clang/lib/Basic/Targets/X86.cpp b/clang/lib/Basic/Targets/X86.cpp
@@ -1842,7 +1842,7 @@ Optional<unsigned> X86TargetInfo::getCPUCacheLineSize() const {
     case CK_Generic:
       return None;
   }
-  return None;
+  llvm_unreachable("Unknown CPU kind");
 }
 
 bool X86TargetInfo::validateOutputSize(const llvm::StringMap<bool> &FeatureMap,

Original file line number	Diff line number	Diff line change
`@@ -1842,7 +1842,7 @@ Optional<unsigned> X86TargetInfo::getCPUCacheLineSize() const {`
`1842`	`1842`	`case CK_Generic:`
`1843`	`1843`	`return None;`
`1844`	`1844`	`}`
`1845`		`- return None;`
	`1845`	`+ llvm_unreachable("Unknown CPU kind");`
`1846`	`1846`	`}`
`1847`	`1847`
`1848`	`1848`	`bool X86TargetInfo::validateOutputSize(const llvm::StringMap<bool> &FeatureMap,`