Skip to content

Commit 7f876ac

Browse files
authored
Revert "Finish deleting the le32/le64 targets (#98497)"
This reverts commit 2369a54.
1 parent bbcb3d6 commit 7f876ac

File tree

18 files changed

+157
-4
lines changed

18 files changed

+157
-4
lines changed

clang/docs/ReleaseNotes.rst

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,6 @@ code bases.
4040
- Setting the deprecated CMake variable ``GCC_INSTALL_PREFIX`` (which sets the
4141
default ``--gcc-toolchain=``) now leads to a fatal error.
4242

43-
- The ``le32`` and ``le64`` targets have been removed.
44-
4543
C/C++ Language Potentially Breaking Changes
4644
-------------------------------------------
4745

clang/docs/tools/clang-formatted-files.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -362,6 +362,7 @@ clang/lib/Basic/Targets/BPF.cpp
362362
clang/lib/Basic/Targets/BPF.h
363363
clang/lib/Basic/Targets/Hexagon.h
364364
clang/lib/Basic/Targets/Lanai.h
365+
clang/lib/Basic/Targets/Le64.h
365366
clang/lib/Basic/Targets/M68k.h
366367
clang/lib/Basic/Targets/MSP430.h
367368
clang/lib/Basic/Targets/NVPTX.cpp

clang/lib/Basic/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,7 @@ add_clang_library(clangBasic
102102
Targets/DirectX.cpp
103103
Targets/Hexagon.cpp
104104
Targets/Lanai.cpp
105+
Targets/Le64.cpp
105106
Targets/LoongArch.cpp
106107
Targets/M68k.cpp
107108
Targets/MSP430.cpp

clang/lib/Basic/Targets.cpp

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
#include "Targets/DirectX.h"
2424
#include "Targets/Hexagon.h"
2525
#include "Targets/Lanai.h"
26+
#include "Targets/Le64.h"
2627
#include "Targets/LoongArch.h"
2728
#include "Targets/M68k.h"
2829
#include "Targets/MSP430.h"
@@ -343,6 +344,17 @@ std::unique_ptr<TargetInfo> AllocateTarget(const llvm::Triple &Triple,
343344
return std::make_unique<M68kTargetInfo>(Triple, Opts);
344345
}
345346

347+
case llvm::Triple::le32:
348+
switch (os) {
349+
case llvm::Triple::NaCl:
350+
return std::make_unique<NaClTargetInfo<PNaClTargetInfo>>(Triple, Opts);
351+
default:
352+
return nullptr;
353+
}
354+
355+
case llvm::Triple::le64:
356+
return std::make_unique<Le64TargetInfo>(Triple, Opts);
357+
346358
case llvm::Triple::ppc:
347359
switch (os) {
348360
case llvm::Triple::Linux:

clang/lib/Basic/Targets/Le64.cpp

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
//===--- Le64.cpp - Implement Le64 target feature support -----------------===//
2+
//
3+
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
4+
// See https://llvm.org/LICENSE.txt for license information.
5+
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
6+
//
7+
//===----------------------------------------------------------------------===//
8+
//
9+
// This file implements Le64 TargetInfo objects.
10+
//
11+
//===----------------------------------------------------------------------===//
12+
13+
#include "Le64.h"
14+
#include "Targets.h"
15+
#include "clang/Basic/Builtins.h"
16+
#include "clang/Basic/MacroBuilder.h"
17+
#include "clang/Basic/TargetBuiltins.h"
18+
19+
using namespace clang;
20+
using namespace clang::targets;
21+
22+
ArrayRef<Builtin::Info> Le64TargetInfo::getTargetBuiltins() const {
23+
return {};
24+
}
25+
26+
void Le64TargetInfo::getTargetDefines(const LangOptions &Opts,
27+
MacroBuilder &Builder) const {
28+
DefineStd(Builder, "unix", Opts);
29+
defineCPUMacros(Builder, "le64", /*Tuning=*/false);
30+
}

clang/lib/Basic/Targets/Le64.h

Lines changed: 64 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,64 @@
1+
//===--- Le64.h - Declare Le64 target feature support -----------*- C++ -*-===//
2+
//
3+
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
4+
// See https://llvm.org/LICENSE.txt for license information.
5+
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
6+
//
7+
//===----------------------------------------------------------------------===//
8+
//
9+
// This file declares Le64 TargetInfo objects.
10+
//
11+
//===----------------------------------------------------------------------===//
12+
13+
#ifndef LLVM_CLANG_LIB_BASIC_TARGETS_LE64_H
14+
#define LLVM_CLANG_LIB_BASIC_TARGETS_LE64_H
15+
16+
#include "clang/Basic/TargetInfo.h"
17+
#include "clang/Basic/TargetOptions.h"
18+
#include "llvm/Support/Compiler.h"
19+
#include "llvm/TargetParser/Triple.h"
20+
21+
namespace clang {
22+
namespace targets {
23+
24+
class LLVM_LIBRARY_VISIBILITY Le64TargetInfo : public TargetInfo {
25+
26+
public:
27+
Le64TargetInfo(const llvm::Triple &Triple, const TargetOptions &)
28+
: TargetInfo(Triple) {
29+
NoAsmVariants = true;
30+
LongWidth = LongAlign = PointerWidth = PointerAlign = 64;
31+
MaxAtomicPromoteWidth = MaxAtomicInlineWidth = 64;
32+
resetDataLayout("e-m:e-v128:32-v16:16-v32:32-v96:32-n8:16:32:64-S128");
33+
}
34+
35+
void getTargetDefines(const LangOptions &Opts,
36+
MacroBuilder &Builder) const override;
37+
38+
ArrayRef<Builtin::Info> getTargetBuiltins() const override;
39+
40+
BuiltinVaListKind getBuiltinVaListKind() const override {
41+
return TargetInfo::PNaClABIBuiltinVaList;
42+
}
43+
44+
std::string_view getClobbers() const override { return ""; }
45+
46+
ArrayRef<const char *> getGCCRegNames() const override {
47+
return std::nullopt;
48+
}
49+
50+
ArrayRef<TargetInfo::GCCRegAlias> getGCCRegAliases() const override {
51+
return std::nullopt;
52+
}
53+
54+
bool validateAsmConstraint(const char *&Name,
55+
TargetInfo::ConstraintInfo &Info) const override {
56+
return false;
57+
}
58+
59+
bool hasProtectedVisibility() const override { return false; }
60+
};
61+
62+
} // namespace targets
63+
} // namespace clang
64+
#endif // LLVM_CLANG_LIB_BASIC_TARGETS_LE64_H

clang/lib/Basic/Targets/OSTargets.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -841,6 +841,9 @@ class LLVM_LIBRARY_VISIBILITY NaClTargetInfo : public OSTargetInfo<Target> {
841841
"i64:64-i128:128-n8:16:32:64-S128");
842842
} else if (Triple.getArch() == llvm::Triple::mipsel) {
843843
// Handled on mips' setDataLayout.
844+
} else {
845+
assert(Triple.getArch() == llvm::Triple::le32);
846+
this->resetDataLayout("e-p:32:32-i64:64");
844847
}
845848
}
846849
};

clang/lib/CodeGen/CodeGenModule.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,8 @@ createTargetCodeGenInfo(CodeGenModule &CGM) {
116116
default:
117117
return createDefaultTargetCodeGenInfo(CGM);
118118

119+
case llvm::Triple::le32:
120+
return createPNaClTargetCodeGenInfo(CGM);
119121
case llvm::Triple::m68k:
120122
return createM68kTargetCodeGenInfo(CGM);
121123
case llvm::Triple::mips:

clang/lib/CodeGen/ItaniumCXXABI.cpp

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -576,6 +576,13 @@ CodeGen::CGCXXABI *CodeGen::CreateItaniumCXXABI(CodeGenModule &CGM) {
576576
return new XLCXXABI(CGM);
577577

578578
case TargetCXXABI::GenericItanium:
579+
if (CGM.getContext().getTargetInfo().getTriple().getArch()
580+
== llvm::Triple::le32) {
581+
// For PNaCl, use ARM-style method pointers so that PNaCl code
582+
// does not assume anything about the alignment of function
583+
// pointers.
584+
return new ItaniumCXXABI(CGM, /*UseARMMethodPtrABI=*/true);
585+
}
579586
return new ItaniumCXXABI(CGM);
580587

581588
case TargetCXXABI::Microsoft:

clang/lib/Driver/ToolChains/Clang.cpp

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3822,6 +3822,12 @@ static void RenderBuiltinOptions(const ToolChain &TC, const llvm::Triple &T,
38223822
if (UseBuiltins)
38233823
A->render(Args, CmdArgs);
38243824
}
3825+
3826+
// le32-specific flags:
3827+
// -fno-math-builtin: clang should not convert math builtins to intrinsics
3828+
// by default.
3829+
if (TC.getArch() == llvm::Triple::le32)
3830+
CmdArgs.push_back("-fno-math-builtin");
38253831
}
38263832

38273833
bool Driver::getDefaultModuleCachePath(SmallVectorImpl<char> &Result) {

0 commit comments

Comments
 (0)