Skip to content

Commit 6b93675

Browse files
[LoopVectorize][AArch64][SVE] Generate wide active lane masks
This patch makes the LoopVectorize generate lane masks longer than the VF to allow the target to better utilise the instruction set. The vectorizer emit one or more wide `llvm.get.active.lane.mask.*` calls plus several `llvm.vector.extract.*` calls to yield the required number of VF-wide masks. The motivating exammple is a vectorised loop with unroll factor 2 that can use the SVE2.1 `whilelo` instruction with predicate pair result, or a SVE `whilelo` instruction with smaller element size plus `punpklo`/`punpkhi`. How wide is the lane mask that the vectoriser emits is controlled by a TargetTransformInfo hook `getMaxPredicateLength`.The default impementation (return the same length as the VF) keeps the change non-functional for targets that can't or are not prepared to handle wider lane masks.
1 parent 3373074 commit 6b93675

23 files changed

+3045
-1146
lines changed

llvm/include/llvm/Analysis/TargetTransformInfo.h

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1241,6 +1241,8 @@ class TargetTransformInfo {
12411241
/// and the number of execution units in the CPU.
12421242
unsigned getMaxInterleaveFactor(ElementCount VF) const;
12431243

1244+
ElementCount getMaxPredicateLength(ElementCount VF) const;
1245+
12441246
/// Collect properties of V used in cost analysis, e.g. OP_PowerOf2.
12451247
static OperandValueInfo getOperandInfo(const Value *V);
12461248

@@ -1999,6 +2001,9 @@ class TargetTransformInfo::Concept {
19992001
virtual bool shouldPrefetchAddressSpace(unsigned AS) const = 0;
20002002

20012003
virtual unsigned getMaxInterleaveFactor(ElementCount VF) = 0;
2004+
2005+
virtual ElementCount getMaxPredicateLength(ElementCount VF) const = 0;
2006+
20022007
virtual InstructionCost getArithmeticInstrCost(
20032008
unsigned Opcode, Type *Ty, TTI::TargetCostKind CostKind,
20042009
OperandValueInfo Opd1Info, OperandValueInfo Opd2Info,
@@ -2622,6 +2627,11 @@ class TargetTransformInfo::Model final : public TargetTransformInfo::Concept {
26222627
unsigned getMaxInterleaveFactor(ElementCount VF) override {
26232628
return Impl.getMaxInterleaveFactor(VF);
26242629
}
2630+
2631+
ElementCount getMaxPredicateLength(ElementCount VF) const override {
2632+
return Impl.getMaxPredicateLength(VF);
2633+
}
2634+
26252635
unsigned getEstimatedNumberOfCaseClusters(const SwitchInst &SI,
26262636
unsigned &JTSize,
26272637
ProfileSummaryInfo *PSI,

llvm/include/llvm/Analysis/TargetTransformInfoImpl.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -531,6 +531,8 @@ class TargetTransformInfoImplBase {
531531

532532
unsigned getMaxInterleaveFactor(ElementCount VF) const { return 1; }
533533

534+
ElementCount getMaxPredicateLength(ElementCount VF) const { return VF; }
535+
534536
InstructionCost getArithmeticInstrCost(
535537
unsigned Opcode, Type *Ty, TTI::TargetCostKind CostKind,
536538
TTI::OperandValueInfo Opd1Info, TTI::OperandValueInfo Opd2Info,

llvm/include/llvm/CodeGen/BasicTTIImpl.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -890,6 +890,8 @@ class BasicTTIImplBase : public TargetTransformInfoImplCRTPBase<T> {
890890

891891
unsigned getMaxInterleaveFactor(ElementCount VF) { return 1; }
892892

893+
ElementCount getMaxPredicateLength(ElementCount VF) const { return VF; }
894+
893895
InstructionCost getArithmeticInstrCost(
894896
unsigned Opcode, Type *Ty, TTI::TargetCostKind CostKind,
895897
TTI::OperandValueInfo Opd1Info = {TTI::OK_AnyValue, TTI::OP_None},

llvm/lib/Analysis/TargetTransformInfo.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -816,6 +816,10 @@ unsigned TargetTransformInfo::getMaxInterleaveFactor(ElementCount VF) const {
816816
return TTIImpl->getMaxInterleaveFactor(VF);
817817
}
818818

819+
ElementCount TargetTransformInfo::getMaxPredicateLength(ElementCount VF) const {
820+
return TTIImpl->getMaxPredicateLength(VF);
821+
}
822+
819823
TargetTransformInfo::OperandValueInfo
820824
TargetTransformInfo::getOperandInfo(const Value *V) {
821825
OperandValueKind OpInfo = OK_AnyValue;

llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3362,6 +3362,15 @@ unsigned AArch64TTIImpl::getMaxInterleaveFactor(ElementCount VF) {
33623362
return ST->getMaxInterleaveFactor();
33633363
}
33643364

3365+
ElementCount AArch64TTIImpl::getMaxPredicateLength(ElementCount VF) const {
3366+
// Do not create masks bigger than `<vscale x 16 x i1>`.
3367+
unsigned N = ST->hasSVE() ? 16 : 0;
3368+
// Do not create masks that are more than twice the VF.
3369+
N = std::min(N, 2 * VF.getKnownMinValue());
3370+
return VF.isScalable() ? ElementCount::getScalable(N)
3371+
: ElementCount::getFixed(N);
3372+
}
3373+
33653374
// For Falkor, we want to avoid having too many strided loads in a loop since
33663375
// that can exhaust the HW prefetcher resources. We adjust the unroller
33673376
// MaxCount preference below to attempt to ensure unrolling doesn't create too

llvm/lib/Target/AArch64/AArch64TargetTransformInfo.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -157,6 +157,8 @@ class AArch64TTIImpl : public BasicTTIImplBase<AArch64TTIImpl> {
157157

158158
unsigned getMaxInterleaveFactor(ElementCount VF);
159159

160+
ElementCount getMaxPredicateLength(ElementCount VF) const;
161+
160162
bool prefersVectorizedAddressing() const;
161163

162164
InstructionCost getMaskedMemoryOpCost(unsigned Opcode, Type *Src,

llvm/lib/Transforms/Vectorize/LoopVectorizationPlanner.h

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -196,6 +196,14 @@ class VPBuilder {
196196
VPValue *createICmp(CmpInst::Predicate Pred, VPValue *A, VPValue *B,
197197
DebugLoc DL = {}, const Twine &Name = "");
198198

199+
VPValue *createGetActiveLaneMask(VPValue *IV, VPValue *TC, DebugLoc DL,
200+
const Twine &Name = "") {
201+
auto *ALM = new VPActiveLaneMaskRecipe(IV, TC, DL, Name);
202+
if (BB)
203+
BB->insert(ALM, InsertPt);
204+
return ALM;
205+
}
206+
199207
//===--------------------------------------------------------------------===//
200208
// RAII helpers.
201209
//===--------------------------------------------------------------------===//

llvm/lib/Transforms/Vectorize/LoopVectorize.cpp

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -597,6 +597,10 @@ class InnerLoopVectorizer {
597597
/// count of the original loop for both main loop and epilogue vectorization.
598598
void setTripCount(Value *TC) { TripCount = TC; }
599599

600+
ElementCount getMaxPredicateLength(ElementCount VF) const {
601+
return TTI->getMaxPredicateLength(VF);
602+
}
603+
600604
protected:
601605
friend class LoopVectorizationPlanner;
602606

@@ -7525,7 +7529,8 @@ LoopVectorizationPlanner::executePlan(
75257529
LLVM_DEBUG(BestVPlan.dump());
75267530

75277531
// Perform the actual loop transformation.
7528-
VPTransformState State(BestVF, BestUF, LI, DT, ILV.Builder, &ILV, &BestVPlan,
7532+
VPTransformState State(BestVF, BestUF, TTI.getMaxPredicateLength(BestVF), LI,
7533+
DT, ILV.Builder, &ILV, &BestVPlan,
75297534
OrigLoop->getHeader()->getContext());
75307535

75317536
// 0. Generate SCEV-dependent code into the preheader, including TripCount,

llvm/lib/Transforms/Vectorize/VPlan.cpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -214,12 +214,13 @@ VPBasicBlock::iterator VPBasicBlock::getFirstNonPhi() {
214214
return It;
215215
}
216216

217-
VPTransformState::VPTransformState(ElementCount VF, unsigned UF, LoopInfo *LI,
217+
VPTransformState::VPTransformState(ElementCount VF, unsigned UF,
218+
ElementCount MaxPred, LoopInfo *LI,
218219
DominatorTree *DT, IRBuilderBase &Builder,
219220
InnerLoopVectorizer *ILV, VPlan *Plan,
220221
LLVMContext &Ctx)
221-
: VF(VF), UF(UF), LI(LI), DT(DT), Builder(Builder), ILV(ILV), Plan(Plan),
222-
LVer(nullptr),
222+
: VF(VF), UF(UF), MaxPred(MaxPred), LI(LI), DT(DT), Builder(Builder),
223+
ILV(ILV), Plan(Plan), LVer(nullptr),
223224
TypeAnalysis(Plan->getCanonicalIV()->getScalarType(), Ctx) {}
224225

225226
Value *VPTransformState::get(VPValue *Def, const VPIteration &Instance) {

llvm/lib/Transforms/Vectorize/VPlan.h

Lines changed: 47 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -234,13 +234,14 @@ struct VPIteration {
234234
/// VPTransformState holds information passed down when "executing" a VPlan,
235235
/// needed for generating the output IR.
236236
struct VPTransformState {
237-
VPTransformState(ElementCount VF, unsigned UF, LoopInfo *LI,
238-
DominatorTree *DT, IRBuilderBase &Builder,
237+
VPTransformState(ElementCount VF, unsigned UF, ElementCount MaxPred,
238+
LoopInfo *LI, DominatorTree *DT, IRBuilderBase &Builder,
239239
InnerLoopVectorizer *ILV, VPlan *Plan, LLVMContext &Ctx);
240240

241241
/// The chosen Vectorization and Unroll Factors of the loop being vectorized.
242242
ElementCount VF;
243243
unsigned UF;
244+
ElementCount MaxPred;
244245

245246
/// If EVL (Explicit Vector Length) is not nullptr, then EVL must be a valid
246247
/// value set during plan transformation, possibly a default value = whole
@@ -1167,7 +1168,6 @@ class VPInstruction : public VPRecipeWithIRFlags {
11671168
Not,
11681169
SLPLoad,
11691170
SLPStore,
1170-
ActiveLaneMask,
11711171
ExplicitVectorLength,
11721172
CalculateTripCountMinusVF,
11731173
// Increment the canonical IV separately for each unrolled part.
@@ -1321,6 +1321,50 @@ class VPInstruction : public VPRecipeWithIRFlags {
13211321
}
13221322
};
13231323

1324+
class VPActiveLaneMaskRecipe : public VPRecipeWithIRFlags {
1325+
const std::string Name;
1326+
1327+
public:
1328+
VPActiveLaneMaskRecipe(VPValue *IV, VPValue *TC, DebugLoc DL = {},
1329+
const Twine &Name = "")
1330+
: VPRecipeWithIRFlags(VPDef::VPActiveLaneMaskSC,
1331+
std::initializer_list<VPValue *>{IV, TC}, DL),
1332+
Name(Name.str()) {}
1333+
1334+
VP_CLASSOF_IMPL(VPDef::VPActiveLaneMaskSC)
1335+
1336+
VPRecipeBase *clone() override {
1337+
SmallVector<VPValue *, 2> Operands(operands());
1338+
assert(Operands.size() == 2 && "by construction");
1339+
auto *New = new VPActiveLaneMaskRecipe(Operands[0], Operands[1],
1340+
getDebugLoc(), Name);
1341+
New->transferFlags(*this);
1342+
return New;
1343+
}
1344+
1345+
void execute(VPTransformState &State) override;
1346+
1347+
#if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP)
1348+
/// Print the recipe.
1349+
void print(raw_ostream &O, const Twine &Indent,
1350+
VPSlotTracker &SlotTracker) const override;
1351+
#endif
1352+
1353+
bool onlyFirstLaneUsed(const VPValue *Op) const override {
1354+
assert(is_contained(operands(), Op) &&
1355+
"Op must be an operand of the recipe");
1356+
1357+
return true;
1358+
}
1359+
1360+
bool onlyFirstPartUsed(const VPValue *Op) const override {
1361+
assert(is_contained(operands(), Op) &&
1362+
"Op must be an operand of the recipe");
1363+
1364+
return false;
1365+
}
1366+
};
1367+
13241368
/// VPWidenRecipe is a recipe for producing a copy of vector type its
13251369
/// ingredient. This recipe covers most of the traditional vectorization cases
13261370
/// where each ingredient transforms into a vectorized version of itself.

0 commit comments

Comments
 (0)